[PATCH v2 0/1] MR4892: msvcp140: Add stub for _XGetLastError.

[Vijay Kiran Kamuju (＠infyquest)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46904

--
  v2: msvcp140: Add stub for _XGetLastError.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4892

[PATCH v2 1/1] msvcp140: Add stub for _XGetLastError.

[Vijay Kiran Kamuju]

From: Vijay Kiran Kamuju <infyquest(a)gmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46904
---
 dlls/msvcp140/msvcp140.spec | 2 +-
 dlls/msvcp90/exception.c    | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/dlls/msvcp140/msvcp140.spec b/dlls/msvcp140/msvcp140.spec
index c04e870eb72..bc18d7b5be8 100644
--- a/dlls/msvcp140/msvcp140.spec
+++ b/dlls/msvcp140/msvcp140.spec
@@ -1672,7 +1672,7 @@
 @ cdecl ?_Winerror_map(a)std@@YAHH(a)Z(long) _Winerror_map
 @ cdecl -arch=win32 ?_Winerror_message(a)std@@YAKKPADK(a)Z(long ptr long) _Winerror_message
 @ cdecl -arch=win64 ?_Winerror_message(a)std@@YAKKPEADK(a)Z(long ptr long) _Winerror_message
-@ stub ?_XGetLastError(a)std@@YAXXZ
+@ cdecl ?_XGetLastError(a)std@@YAXXZ() _XGetLastError
 @ cdecl ?_XLgamma(a)std@@YAMM(a)Z(float) std__XLgamma_float
 @ cdecl ?_XLgamma(a)std@@YANN(a)Z(double) std__XLgamma_double
 @ cdecl ?_XLgamma(a)std@@YAOO(a)Z(double) std__XLgamma_double
diff --git a/dlls/msvcp90/exception.c b/dlls/msvcp90/exception.c
index 01cb2bb5dab..4cfa70c4c72 100644
--- a/dlls/msvcp90/exception.c
+++ b/dlls/msvcp90/exception.c
@@ -997,6 +997,14 @@ bool __cdecl MSVCP__uncaught_exception(void)
     return __uncaught_exception();
 }
 
+#if _MSVCP_VER >= 140
+/* ?_XGetLastError(a)std@@YAXXZ */
+void __cdecl _XGetLastError(void)
+{
+    FIXME("stub\n");
+}
+#endif
+
 #if _MSVCP_VER >= 110
 typedef struct
 {
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4892

[PATCH v2 0/1] MR4892: msvcp140: Add stub for _XGetLastError. - closed

[Piotr Caban (＠piotr)]

This merge request was closed by Piotr Caban.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4892

[Piotr Caban (＠piotr)]

I have created !4893 that also contains implementation. I don't think that stub without implementation is useful in this case.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4892#note_58275

[Vijay Kiran Kamuju (＠infyquest)]

On Sat Jan 20 19:43:48 2024 +0000, Piotr Caban wrote:
> I have created !4893 that also contains implementation. I don't think
> that stub without implementation is useful in this case.
> Piotr, according to the bug report we might also need to implement the regex exceptions 
> @ stub ?_Xregex_error(a)std@@YAXW4error_type(a)regex_constants@1@@Z
> ,which is almost the same as,
> @ stub ?_Xbad(a)tr1@std@@YAXW4error_type(a)regex_constants@12@@Z

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4892#note_58278