[PATCH v2 0/1] MR2736: Draft: Reset presentation flags when session_clear_presentation is called.

[Santino Mazza (＠tati1454)]

This prevents hangs when a program sets a new topology after stopping the current
topology, because if we don't reset the flags to 0 the session will not subscribe
to the events of the new topology sources.

--
  v2: mf/session: Reset presentation flags when session_clear_presentation is called.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2736

[PATCH v2 1/1] mf/session: Reset presentation flags when session_clear_presentation is called.

[Santino Mazza]

From: Santino Mazza <smazza(a)codeweavers.com>

This prevents hangs when a program sets a new topology after stopping the current
topology, because if we don't reset the flags to 0 the session will not subscribe
to the events of the new topology sources.
---
 dlls/mf/session.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/mf/session.c b/dlls/mf/session.c
index 7d6a65d3f55..8b29c8487fb 100644
--- a/dlls/mf/session.c
+++ b/dlls/mf/session.c
@@ -800,6 +800,7 @@ static void session_clear_presentation(struct media_session *session)
 
     IMFTopology_Clear(session->presentation.current_topology);
     session->presentation.topo_status = MF_TOPOSTATUS_INVALID;
+    session->presentation.flags = 0;
 
     LIST_FOR_EACH_ENTRY_SAFE(source, source2, &session->presentation.sources, struct media_source, entry)
     {
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2736

[PATCH v2 1/1] mf/session: Reset presentation flags when session_clear_presentation is called.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=132338

Your paranoid android.


=== debian11 (32 bit report) ===

qasf:
asfreader.c:233: Test failed: Got name L"Raw Audio 0".
asfreader.c:238: Test failed: Got id L"Raw Audio 0".

[PATCH v2 0/1] MR2736: Draft: Reset presentation flags when session_clear_presentation is called. - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2736