[PATCH 0/1] MR6847: evr: Use D3DCREATE_MULTITHREADED device creation flag.
Fixes a random crash in Disagea 5 intro video when D3D9 buffers are locked and Presented concurrently. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6847
From: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/evr/presenter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/evr/presenter.c b/dlls/evr/presenter.c index f1f1f0f8112..7ad59ccc958 100644 --- a/dlls/evr/presenter.c +++ b/dlls/evr/presenter.c @@ -2136,7 +2136,7 @@ static HRESULT video_presenter_init_d3d(struct video_presenter *presenter) present_params.Flags = D3DPRESENTFLAG_VIDEO; present_params.PresentationInterval = D3DPRESENT_INTERVAL_IMMEDIATE; hr = IDirect3D9_CreateDevice(d3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, GetDesktopWindow(), - D3DCREATE_HARDWARE_VERTEXPROCESSING, &present_params, &device); + D3DCREATE_HARDWARE_VERTEXPROCESSING | D3DCREATE_MULTITHREADED, &present_params, &device); IDirect3D9_Release(d3d); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/6847
Please add a test for default device creation parameters, just for this flag, because they set more and it's not clear if we need them all. It's fine to add that to test_presenter_video_window(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6847#note_88033
participants (2)
-
Nikolay Sivov (@nsivov) -
Rémi Bernon