[Bug 37896] New: EM_SETPASSWORDCHAR ineffective when edit control does not have WS_BORDER set
https://bugs.winehq.org/show_bug.cgi?id=37896 Bug ID: 37896 Summary: EM_SETPASSWORDCHAR ineffective when edit control does not have WS_BORDER set Product: Wine Version: 1.7.33 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: winehq-bugzilla(a)richardpayne.name Distribution: --- I have two identical edit controls with ES_PASSWORD set via EM_SETPASSWORDCHAR. Identical, that is, apart from 1 having WS_BORDER set and the other not. The one without WS_BORDER does not conceal its contents as it should when a password char is specified. The one with WS_BORDER set works as expected. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 halwine <bugs.winehq.org(a)netaxiom.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.winehq.org(a)netaxiom.ne | |t --- Comment #1 from halwine <bugs.winehq.org(a)netaxiom.net> --- Many 1Password users are experiencing this issue. See the following pages: https://discussions.agilebits.com/discussion/comment/174037 https://discussions.agilebits.com/discussion/comment/187689 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #2 from halwine <bugs.winehq.org(a)netaxiom.net> --- Btw, this is 1Password, a paid-for app for Windows, OS X, IOS and Android. https://agilebits.com/onepassword -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #3 from halwine <bugs.winehq.org(a)netaxiom.net> --- Although this report has been raised for Wine 1.7, I'm using version 1.4, where the issue also exists. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 winehq-bugzilla(a)richardpayne.name changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://appdb.winehq.org/ob | |jectManager.php?sClass=vers | |ion&iId=31904 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 Mike <mike(a)agilebits.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mike(a)agilebits.com --- Comment #4 from Mike <mike(a)agilebits.com> --- Hi guys, My name is Mike Tselikman, I work with AgileBits, the creator of 1Password. We would love to help in any way we can with this issue as it does affect many of our customers running 1Password for Windows on Linux with the help of WINE. #38253 looks like a duplicate of this report as well. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winebugzilla(a)lesath.de --- Comment #5 from Austin English <austinenglish(a)gmail.com> --- *** Bug 38253 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> --- The control is apparently ES_MULTILINE, which doesn't support passwords according to MSDN. It may be useful to write a test to confirm that. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #7 from winehq-bugzilla(a)richardpayne.name --- Interesting. I wonder why it works correctly on Windows! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #8 from Mike <mike(a)agilebits.com> --- Thanks for the info, we'll look into ES_MULTILINE, and follow up. [Our bug ID: OPW-348] -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #9 from winehq-bugzilla(a)richardpayne.name --- Just to clarify my previous comment. Windows XP does not hide the edit control's contents when ES_MULTILINE is set but Windows 7 does. So basically, running 1Password on WINE functions in the same way as running it on WinXP. Running it on WINE differs from how it runs on Win7. Is this a bug in Windows 7 or a change in the specifications of the edit control? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #10 from Bruno Jesus <00cpxxx(a)gmail.com> --- I manually tested this and it's true: >= Win 7 (I don't have vista to test) ignores ES_MULTILINE and always displays the * for passwords. The same test app in <= XP displays * only when ES_MULTILINE is not set. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #11 from Mike <mike(a)agilebits.com> --- Hi guys, Just want to give you an update. We could not turn off ES_MULTILINE, so we turned on WS_BORDER selectively for XP. We've shipped this in the latest 4.3.1 update, which should work now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #12 from Wolfram Sobotta <winebugzilla(a)lesath.de> --- I can confirm, that this bug is closed in the actual version 4.6.x of 1password. It works in Wine 1.6.2. Could anybody close this bug? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #13 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Wolfram Sobotta from comment #12)
I can confirm, that this bug is closed in the actual version 4.6.x of 1password. It works in Wine 1.6.2.
Could anybody close this bug?
It should stay open, if nothing was fixed in Wine. Application workarounds are irrelevant. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=37896 KRosUser <kyle.kcsoftwares(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.kcsoftwares(a)gmail.com --- Comment #14 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- Created attachment 79070 --> http://bugs.winehq.org/attachment.cgi?id=79070 Wine 10.12 and 1Password 1Password 4.6.0.604 Wine 10.12 shows it correctly with 1Password 1Password 4.6.0.604 To be marked as RESOLVED ? Do you have the sample test app from the 1st comment to test / or re-open a ticket with more details ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #15 from Nikolay Sivov <bunglehead(a)gmail.com> --- Why would it be marked as resolved? It's not important if current application version started to work, it's important that original issue is fixed. For testing you'll need anything like ControlSpy to see what the current behavior is. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #16 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- I tested with the "original 4.6.0" not with the most recent one. Anyway a test application would be there the best option. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #17 from Janne <janne.kekkonen@gmail.com> --- Created attachment 81602 --> http://bugs.winehq.org/attachment.cgi?id=81602 test application screenshots Hello, Following up on the comments, I put together a small test application. The test application has four Edit controls: two are single-line and two are multiline. The password mask is set using the EM_SETPASSWORDCHAR message. I tested the application on Windows 2000, XP, and 11, as well as Wine: On Windows 2000 & XP: Edit controls with ES_MULTILINE show plain text instead of asterisks (*). On Windows 11: All edit controls display asterisks (*). On Wine 11.13: Tested in a 32-bit prefix configured as Win2k, WinXP, and Win11. In all configurations, every edit control showed asterisks (*). It appears Wine's implementation differs from native Windows, at least on 2000 and XP. Please see the attached picture. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=37896 --- Comment #18 from Janne <janne.kekkonen@gmail.com> --- Created attachment 81603 --> http://bugs.winehq.org/attachment.cgi?id=81603 test application Attached zip file contains the test application and source code for it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=37896 Alexandre Julliard <julliard@winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|EM_SETPASSWORDCHAR |EM_SETPASSWORDCHAR |ineffective when edit |ineffective on multiline |control does not have |edit controls |WS_BORDER set | Fixed by SHA1| |4669c1f55e8ab722060426c7edc | |6b724da3a7a8e Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #19 from Alexandre Julliard <julliard@winehq.org> --- Wine follows the behavior of recent Windows versions, so this is working as expected. It was fixed by 4669c1f55e8ab722060426c7edc6b724da3a7a8e. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=37896 Alexandre Julliard <julliard@winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #20 from Alexandre Julliard <julliard@winehq.org> --- Closing bugs fixed in 11.15. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (3)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla
-
WineHQ Bugzilla