[Bug 48577] New: DISPLAYCONFIG_VIDEO_OUTPUT_TECHNOLOGY and other enums are the wrong size
https://bugs.winehq.org/show_bug.cgi?id=48577 Bug ID: 48577 Summary: DISPLAYCONFIG_VIDEO_OUTPUT_TECHNOLOGY and other enums are the wrong size Product: Wine Version: 5.1 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: bshanks(a)codeweavers.com Distribution: --- When building for 64-bit with MinGW or MSVC, sizeof(DISPLAYCONFIG_VIDEO_OUTPUT_TECHNOLOGY)=4. But when building against Wine headers, sizeof(DISPLAYCONFIG_VIDEO_OUTPUT_TECHNOLOGY)=8. It seems that when gcc/clang finds constants too large to be represented by a signed int, like 'DISPLAYCONFIG_OUTPUT_TECHNOLOGY_INTERNAL = 0x80000000', it increases the enum size to match, but MSVC doesn't. This was tracked a few years ago in MinGW bug #456 <https://sourceforge.net/p/mingw-w64/bugs/456/> and fixed by casting the constants to int: <https://sourceforge.net/p/mingw-w64/mingw-w64/ci/5d61ecd2d087a3a1bdaa9db9027...> tomConstants in tom.h and RecordCreateOptionsEnum in adoint_backcompat.h were also fixed in the same commit, and I can confirm those are also the wrong size in Wine's headers. There may be other enums that need to be fixed though. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48577 Brendan Shanks <bshanks(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |61d0cc78b24cf591746ab62d212 | |59fe3b8e4d7e2 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Brendan Shanks <bshanks(a)codeweavers.com> --- After looking through MinGW and Wine headers, I only found those 3 that were the wrong size. Fixed in ca2ad6acbf8c6c1bcb899f9ff4137a35c8f79a06, 0e408452a4fa8b4b1e02ec4bb16cba6822200b61, and 61d0cc78b24cf591746ab62d21259fe3b8e4d7e2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48577 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #2 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48577 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48577 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|5.0.x |--- --- Comment #3 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 5.0.x milestone from bug fixes included in 5.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla