[Bug 34162] New: CGDirectPaletteRef has been deprecated so winemac.drv can't be compiled in Mavericks.
http://bugs.winehq.org/show_bug.cgi?id=34162 Bug #: 34162 Summary: CGDirectPaletteRef has been deprecated so winemac.drv can't be compiled in Mavericks. Product: Wine Version: 1.6 Platform: x86-64 OS/Version: Mac OS X Status: UNCONFIRMED Severity: critical Priority: P2 Component: winemac.drv AssignedTo: wine-bugs(a)winehq.org ReportedBy: parahexen(a)gmail.com Classification: Unclassified gdi.c:144:5: error: use of undeclared identifier 'CGDirectPaletteRef' CGDirectPaletteRef palette; ^ gdi.c:190:5: error: use of undeclared identifier 'palette' palette = CGPaletteCreateWithDisplay(mainDisplay); ^ gdi.c:191:9: error: use of undeclared identifier 'palette' if (palette) ^ gdi.c:193:52: error: use of undeclared identifier 'palette' palette_size = CGPaletteGetNumberOfSamples(palette); ^ gdi.c:194:26: error: use of undeclared identifier 'palette' CGPaletteRelease(palette); ^ 5 errors generated. make[1]: *** [gdi.o] Error 1 make: *** [dlls/winemac.drv] Error 2 make: *** Waiting for unfinished jobs.... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com, | |ken(a)codeweavers.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 --- Comment #1 from Ken Thomases <ken(a)codeweavers.com> 2013-08-08 16:07:00 CDT --- Curious that it doesn't complain about the functions being undeclared. Presumably the functions use some type to declare their parameter and return types. I'll have to investigate. It may also be that the right solution is to simply remove that code, since we don't properly deal with palette display modes, anyway. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 --- Comment #2 from Parahexen <parahexen(a)gmail.com> 2013-08-08 16:21:44 CDT --- Created attachment 45553 --> http://bugs.winehq.org/attachment.cgi?id=45553 /System/Library/Frameworks/CoreGraphics.framework/Versions/A/Headers/CGDirectDisplay.h /usr/local/bin/gcc-4.2 -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wwrite-strings -Wpointer-arith -fno-omit-frame-pointer -I/opt/X11/include -I/usr/include/libxml2 -Os -w -pipe -march=core2 -msse4 -mmacosx-version-min=10.9 -arch i386 -m32 -o main.o main.c /usr/local/bin/gcc-4.2 -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wwrite-strings -Wpointer-arith -fno-omit-frame-pointer -I/opt/X11/include -I/usr/include/libxml2 -Os -w -pipe -march=core2 -msse4 -mmacosx-version-min=10.9 -arch i386 -m32 -o clipping.o clipping.c gdi.c:144:5: error: use of undeclared identifier 'CGDirectPaletteRef' CGDirectPaletteRef palette; ^ clang -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wwrite-strings -Wpointer-arith -fno-omit-frame-pointer -I/opt/X11/include -I/usr/include/libxml2 -Os -w -pipe -march=core2 -msse4 -mmacosx-version-min=10.9 -arch i386 -m32 -o image.o image.c gdi.c:190:5: error: use of undeclared identifier 'palette' palette = CGPaletteCreateWithDisplay(mainDisplay); ^ gdi.c:191:9: error: use of undeclared identifier 'palette' if (palette) ^ gdi.c:193:52: error: use of undeclared identifier 'palette' palette_size = CGPaletteGetNumberOfSamples(palette); ^ gdi.c:194:26: error: use of undeclared identifier 'palette' CGPaletteRelease(palette); ^ 5 errors generated. make[1]: *** [gdi.o] Error 1 make[1]: *** Waiting for unfinished jobs.... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 --- Comment #3 from Parahexen <parahexen(a)gmail.com> 2013-08-08 16:24:13 CDT --- additional info are shown on: https://github.com/mxcl/homebrew/issues/21552 http://sourceforge.net/mailarchive/message.php?msg_id=31200911 http://ftp.cc.uoc.gr/mirrors/macports/release/ports/devel/libsdl/files/no-CG... ref to old file against the attachment, https://github.com/mpc-hc/mpc-hc/blob/master/include/qt/CGDirectDisplay.h line 59: typedef struct _CGDirectPaletteRef* CGDirectPaletteRef; -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 --- Comment #4 from Ken Thomases <ken(a)codeweavers.com> 2013-08-08 16:41:53 CDT --- You can't attach Apple SDK files, especially from NDA'ed prerelease software, here. Please delete that. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2013-08-08 16:55:15 CDT --- The content of attachment 45553 has been deleted by Austin English <austinenglish(a)gmail.com> who provided the following reason: Copyrighted / nda The token used to delete this attachment was generated at 2013-08-08 16:54:52 CDT. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 --- Comment #6 from Austin English <austinenglish(a)gmail.com> 2013-08-08 16:55:35 CDT --- (In reply to comment #4)
You can't attach Apple SDK files, especially from NDA'ed prerelease software, here. Please delete that.
Done -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 --- Comment #7 from Ken Thomases <ken(a)codeweavers.com> 2013-08-09 16:40:20 CDT --- Created attachment 45562 --> http://bugs.winehq.org/attachment.cgi?id=45562 Avoid using display palette API Here's a patch which should fix the problem. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 Parahexen <parahexen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #8 from Parahexen <parahexen(a)gmail.com> 2013-08-09 18:39:51 CDT --- it works, thanks a lot. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch Status|RESOLVED |REOPENED Resolution|FIXED | Ever Confirmed|0 |1 --- Comment #9 from Bruno Jesus <00cpxxx(a)gmail.com> 2013-08-09 19:16:04 CDT --- (In reply to comment #8)
it works, thanks a lot.
Bugs are marked as fixed when the patch is commited in git. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |4b24fce4e2390fbcc0e6ba8fc60 | |7595c3d05df02 Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #10 from Bruno Jesus <00cpxxx(a)gmail.com> 2013-08-15 13:27:41 CDT --- Patch commited: http://source.winehq.org/git/wine.git/?a=commit;h=4b24fce4e2390fbcc0e6ba8fc6... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #11 from Alexandre Julliard <julliard(a)winehq.org> 2013-08-30 13:05:05 CDT --- Closing bugs fixed in 1.7.1. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.6.x -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34162 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.6.x |--- --- Comment #12 from Alexandre Julliard <julliard(a)winehq.org> 2013-11-15 13:39:39 CST --- Removing 1.6.x milestone from bugs included in 1.6.1. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org