[Bug 56925] New: msys2-64/cygwin64: unlink of read-only file fails
https://bugs.winehq.org/show_bug.cgi?id=56925 Bug ID: 56925 Summary: msys2-64/cygwin64: unlink of read-only file fails Product: Wine Version: 9.12 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: wineserver Assignee: wine-bugs(a)winehq.org Reporter: bernhardu(a)mailbox.org Distribution: --- Created attachment 76744 --> https://bugs.winehq.org/attachment.cgi?id=76744 A few notes and backtraces in wine and cygwin. In another attempt to check the state of msys2 or cygwin I found following issue trying to update a msys2-64 installation: # LANG=C pacman -Suy :: Synchronizing package databases... ... warning: could not remove lock file /var/lib/pacman/db.lck error: failed to init transaction (unable to lock database) error: could not lock database: File exists ... A simpler version to reproduce is this: rm -f test.txt LANG=C wine cmd echo test > test.txt attrib +r test.txt c:\msys64\usr\bin\rm.exe -f -v test.txt Returns: /usr/bin/rm: cannot remove 'test.txt': Permission denied This tests were done with a wine tree including patches for this bugs: 52105 55138 53574 54995 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56925 Bernhard Übelacker <bernhardu(a)mailbox.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56925 --- Comment #1 from Bernhard Übelacker <bernhardu(a)mailbox.org> --- Created attachment 76745 --> https://bugs.winehq.org/attachment.cgi?id=76745 0001-wineserver-Allow-NtOpenFile-with-read-only-files.patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56925 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56925 Joel Holdsworth <joel(a)airwebreathe.org.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joel(a)airwebreathe.org.uk -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56925 nicolas <juan3(a)yandex.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |juan3(a)yandex.com --- Comment #2 from nicolas <juan3(a)yandex.com> --- Is there a reason why this bugfix has been delayed? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56925 --- Comment #3 from Bernhard Übelacker <bernhardu(a)mailbox.org> --- (In reply to nicolas from comment #2)
Is there a reason why this bugfix has been delayed?
Hello nicolas, this is not actively delayed, I just did not yet get confident enough a merge request with a patch has chances for integration and there is time to react to comments to the merge request. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=56925 Bernhard Übelacker <bernhardu(a)mailbox.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76745|0 |1 is obsolete| | --- Comment #4 from Bernhard Übelacker <bernhardu(a)mailbox.org> --- Created attachment 78509 --> http://bugs.winehq.org/attachment.cgi?id=78509 server: Allow NtOpenFile with read-only files. (rebased wine-10.7) Still present with wine-10.7. The patches from bug #55138, bug #53574 and bug #57424 need to be applied to be able to reach below issue. The command "pacman -S rsync" shows the message: #### warning: could not remove lock file /var/lib/pacman/db.lck #### Applying attached patch makes the installation of rsync succeed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=56925 --- Comment #5 from Joel Holdsworth <joel(a)airwebreathe.org.uk> --- Patches submitted: https://gitlab.winehq.org/wine/wine/-/merge_requests/8030 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=56925 --- Comment #6 from Bernhard Übelacker <bernhardu@mailbox.org> --- Hello Joel, I found my last version here had some unwanted side effects as it was allowed to open read only files with too many flags. Maybe you want to add those test from this version of my patch: https://gitlab.winehq.org/bernhardu/wine/-/commit/29b85eb4a2b223fda61b211bb8... I think this is the issue that shows up in the latest pipeline of your MR: https://gitlab.winehq.org/wine/wine/-/jobs/248168#L1518 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=56925 --- Comment #7 from Joel Holdsworth <joel@airwebreathe.org.uk> --- From testing I can see that the CI failures represent real regressions that were being caused by the MR. I added your additional tests into the patch-set: https://gitlab.winehq.org/wine/wine/-/merge_requests/8030/diffs?commit_id=13... I also made changes to fix the test in server/file.c: https://gitlab.winehq.org/wine/wine/-/merge_requests/8030/diffs?commit_id=71... . I think the MR should be in good shape now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla