[Bug 51696] New: ntoskrnl.exe:ntoskrnl outputs too much traces (and broke the Wine tests entirely)
https://bugs.winehq.org/show_bug.cgi?id=51696 Bug ID: 51696 Summary: ntoskrnl.exe:ntoskrnl outputs too much traces (and broke the Wine tests entirely) Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: ntoskrnl Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com Distribution: --- ntoskrnl.exe:ntoskrnl outputs more than 200kB of traces: $ ./wine dlls/ntoskrnl.exe/tests/ntoskrnl.exe_test.exe ntoskrnl
ntoskrnl.report
$ tail -n3 ntoskrnl.report 0270:ntoskrnl: 96 tests executed (1 marked as todo, 0 failures), 0 skipped. 0020:ntoskrnl: Silenced 5475 todos, 0 skips and 0 traces. 0020:ntoskrnl: 21296 tests executed (1967 marked as todo, 0 failures), 0 skipped. $ ls -l ntoskrnl.report -rw-r--r-- 1 fgouget fgouget 208428 août 28 18:37 ntoskrnl.report $ grep "Test marked todo:" ntoskrnl.report | wc -cl 1994 204531 This is not a problem of a runaway test or even that many trace() statements. It's just that there are too many todos despite the vast majority being silenced already. The big issue is that adding so much data to a full Winetest run pushes it over the 1.5MB limit (before and after debiant2 WineTest reports): -rw-r--r-- 1 fgouget fgouget 1477298 août 28 20:27 /tmp/job96432_1_1_win32.report -rw-r--r-- 1 fgouget fgouget 1689913 août 28 20:24 /tmp/job96543_1_1_win32.report The commit that introduced the extra todos is: commit 8d37962b43e5074bc0421611267dc41593114f85 Author: Zebediah Figura <zfigura(a)codeweavers.com> AuthorDate: Thu Aug 26 20:54:10 2021 -0500 ntoskrnl/tests: Add more tests for IRP status handling. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> Also the TestBot warned about this issue when the patch was submitted, though that did not carry over to sending an email to wine-devel or marking the patch as failed on the patches website (bug 51695). https://testbot.winehq.org/JobDetails.pl?Key=96439#k401 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51696 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |8d37962b43e5074bc0421611267 | |dc41593114f85 Keywords| |regression, source, | |testcase Severity|normal |blocker -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51696 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #1 from Zebediah Figura <z.figura12(a)gmail.com> --- ntoskrnl should hopefully be outputting a reasonable number of todo messages now. There are a bunch of commits that fixed the todos introduced, but the last relevant one is <https://source.winehq.org/git/wine.git/commitdiff/1eb56b20baefcdccaafbb622ca...>. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51696 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from François Gouget <fgouget(a)codeweavers.com> --- Yes, this looks pretty good now (4.5kB, even better than before). I have reenabled running ntoskrnl.exe:ntoskrnl. Thanks for cleaning this up! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51696 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #3 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 6.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla