[Bug 48569] New: Infinite drag & drop loop in WinSCP
https://bugs.winehq.org/show_bug.cgi?id=48569 Bug ID: 48569 Summary: Infinite drag & drop loop in WinSCP Product: Wine Version: 5.0 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: mgruber_72(a)yahoo.de Distribution: --- Created attachment 66395 --> https://bugs.winehq.org/attachment.cgi?id=66395 Wine command line output I'm using Ubuntu 18.04 LTS and Wine 5.0 from the official WineHQ repository. The Wine prefix is clean. Steps to reproduce: 1. Get the portable version of WinSCP (currently https://winscp.net/download/WinSCP-5.15.9-Portable.zip). 2. Extract it, execute WinSCP.exe and connect to a SFTP server. 3. In the remote server window try to drag & drop a remote sample file (like /tmp/test.txt) into a remote folder (like /tmp/testdir). 4. The Move path dialogue appears flickering in an indefinite loop until WinSCP crashes. I've been in contact with the WinSCP developer Martin Přikryl about this issue. We've done quite extensive testing with various debug builds and he came to the conclusion, that Wine creates an infinite drag & drop loop after releasing the mouse button causing WinSCP to crash. This behaviour does not happen on native Windows. Attached is the command line output of wine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 mgruber <mgruber_72(a)yahoo.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Distribution|--- |Ubuntu Severity|normal |major -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 --- Comment #1 from mgruber <mgruber_72(a)yahoo.de> --- I should add that this is not a regression introduced in Wine 5.0. I was also able to replicate this bug with the Wine 4.x from the stock Ubuntu Bionic repository. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 mgruber <mgruber_72(a)yahoo.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Infinite drag & drop loop |Infinite drag & drop loop |in WinSCP |crashes WinSCP -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 mgruber <mgruber_72(a)yahoo.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mgruber_72(a)yahoo.de --- Comment #2 from mgruber <mgruber_72(a)yahoo.de> --- Created attachment 66405 --> https://bugs.winehq.org/attachment.cgi?id=66405 Winedebug.log with the last ~800 lines I've attached a Winedebug.log. If a longer one is needed, let me know. I can also include a debug log of WinSCP. Any feedback would be much appreciated. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 mgruber <mgruber_72(a)yahoo.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|5.0 |5.1 Component|-unknown |user32 --- Comment #3 from mgruber <mgruber_72(a)yahoo.de> --- The problem persists on Wine-Devel 5.1 on Ubuntu 19.10 Eoan. An endless amount of "Move to" listboxes is being created until WinSCP crashes. I changed the affected component to user32, since this seems to be reponsible for listbox creation - correct the bug report if I'm wrong. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 Martin Prikryl <martin(a)winscp.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin(a)winscp.net --- Comment #4 from Martin Prikryl <martin(a)winscp.net> --- I'm the author of WinSCP. Some more details: WinSCP detects that an item (a file) was dropped in IDropSource::QueryContinueDrag. Still within the method WinSCP shows a dialog box. In the dialog message loop, Wine calls IDropSource::QueryContinueDrag again (what does not happen on Windows). In the response to that WinSCP displays another dialog and this goes on until the stack overflows. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 --- Comment #5 from mgruber <mgruber_72(a)yahoo.de> --- Could this be related to https://bugs.winehq.org/show_bug.cgi?id=38054? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 mgruber <mgruber_72(a)yahoo.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|user32 |ole32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 mgruber <mgruber_72(a)yahoo.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|x86 |x86-64 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 Roman Pišl <rpisl(a)seznam.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rpisl(a)seznam.cz --- Comment #6 from Roman Pišl <rpisl(a)seznam.cz> --- Created attachment 66427 --> https://bugs.winehq.org/attachment.cgi?id=66427 Fix for the crash Attached patch fixes the issue and shows the cause. But I can't tell whether this is a correct solution for the issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 --- Comment #7 from Roman Pišl <rpisl(a)seznam.cz> --- Patches sent for review: https://source.winehq.org/patches/data/178952 https://source.winehq.org/patches/data/178953 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 --- Comment #8 from Roman Pišl <rpisl(a)seznam.cz> --- Fix commited: https://source.winehq.org/git/wine.git/commit/808d8b87a040e4de44e2691d3a9e29... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 --- Comment #9 from mgruber <mgruber_72(a)yahoo.de> --- Excellent, thank you. It's only a shame that the patch missed Wine 5.2 by just 3 days, so I guess it will reside in Staging for a while until the next Dev release. Or are there chances this might trickle down directly into a maintenance release of 5.0? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 --- Comment #10 from Roman Pišl <rpisl(a)seznam.cz> --- It was commited directly to Wine (into devel, not staging) so it will be included in Wine 5.3 (in ~2 weeks). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |808d8b87a040e4de44e2691d3a9 | |e29f871616ca0 CC| |dark.shadow4(a)web.de Status|UNCONFIRMED |RESOLVED --- Comment #11 from Fabian Maurer <dark.shadow4(a)web.de> --- Marking fixed as of comment 8. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #12 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48569 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|5.0.x |--- --- Comment #13 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 5.0.x milestone from bug fixes included in 5.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla