[Bug 48386] New: Some CPU features are not reported for Intel CPU (Detroit: Become Human is affected)
https://bugs.winehq.org/show_bug.cgi?id=48386 Bug ID: 48386 Summary: Some CPU features are not reported for Intel CPU (Detroit: Become Human is affected) Product: Wine Version: 5.0-rc3 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs(a)winehq.org Reporter: gofmanp(a)gmail.com Distribution: --- Created attachment 66146 --> https://bugs.winehq.org/attachment.cgi?id=66146 ntdll: Detect more processor features on Intel CPU. Split off from bug #48291. The application reads CPU features from shared user data area and requires or benefits from certain CPU features. Some features from CPUID level 0x80000001 are currently recognized for AMD only while they are available on Intel as well. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48386 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |48389 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48386 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |48291 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48386 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/ntdll-User_share | |d_data_fields Status|UNCONFIRMED |STAGED -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48386 Matteo Bruni <matteo.mystral(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |fc8e9bac5f03c68dcd176831e53 | |648de5b20dd5d Resolution|--- |FIXED Status|STAGED |RESOLVED --- Comment #1 from Matteo Bruni <matteo.mystral(a)gmail.com> --- Fixed by <https://source.winehq.org/git/wine.git/commitdiff/fc8e9bac5f03c68dcd176831e5...>, thank you Paul. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48386 --- Comment #2 from Matteo Bruni <matteo.mystral(a)gmail.com> --- (In reply to Matteo Bruni from comment #1)
Fixed by <https://source.winehq.org/git/wine.git/commitdiff/ fc8e9bac5f03c68dcd176831e53648de5b20dd5d>, thank you Paul.
Actually, I don't know if that patch is enough to fix this bug. Paul, is that the case? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48386 --- Comment #3 from Paul Gofman <gofmanp(a)gmail.com> --- (In reply to Matteo Bruni from comment #2)
(In reply to Matteo Bruni from comment #1)
Actually, I don't know if that patch is enough to fix this bug. Paul, is that the case?
Yes, I tested Detroit Become Human still works this way. My initial patch had more things in it but they are either not quite correct (1) or not needed (2), so I cleaned those for upstream after testing. 1. Additional bits from cpuid on Intel pulled from AMD branch. Those are actually AMD specific. They seem to be always 0 on Intel (so it has no effect), but relying on them seems not quite correct as Intel manual refers those as reserved. 2. PF_RDWRFSGSBASE_AVAILABLE processor feature This CPU feature is available on Windows on real hardware (at least where I tested it) but is not available under VMs (testbot and my local VirtualBox). There is cpuid flag for that which is set on Windows but is not set on Linux (Linux denies rdfsbase / rdgsbase through machine status word). So adding that was a bit not straightforward and as soon as I figured it is not actually needed here I thought it can wait until some application wants that. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48386 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48386 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48386 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|5.0.x |--- --- Comment #5 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 5.0.x milestone from bug fixes included in 5.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=48386 Bug 48386 depends on bug 48291, which changed state. Bug 48291 Summary: Multiple applications crash due to direct use of x86_64 SYSCALL instruction (Detroit: Become Human, Red Dead Redemption 2, Arknights: Endfield) http://bugs.winehq.org/show_bug.cgi?id=48291 What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |RESOLVED Resolution|--- |FIXED -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla