[Bug 47486] New: GsView draws one menu item with white background
https://bugs.winehq.org/show_bug.cgi?id=47486 Bug ID: 47486 Summary: GsView draws one menu item with white background Product: Wine Version: 4.11 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: dark.shadow4(a)web.de Distribution: --- Created attachment 64866 --> https://bugs.winehq.org/attachment.cgi?id=64866 Screenshot on wine See screenshot. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47486 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://ghostgum.com.au/down | |load/gsv50w32.exe Keywords| |download See Also| |https://jira.reactos.org/br | |owse/CORE-13935 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47486 --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Issue still present in wine-6.16 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47486 --- Comment #2 from Fabian Maurer <dark.shadow4(a)web.de> --- Turns out the problem are the used bitmaps that are displayed in the menu. It works when the bitmap has the color table {0x000000, 0xffffff} but it breaks with the color table {0xffffff, 0x000000}. On windows, the white is in both cases replaced with the background color, in Wine it only works in the first case. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47486 --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 70630 --> https://bugs.winehq.org/attachment.cgi?id=70630 Patch to allow white as first in color table Attaching a patch to allow white as first in color table. Quote from the code I changed:
* Note : If the first color in the color table is white followed by * black, we can't convert it to a monochrome DDB with * SetDIBits, because black and white would be inverted.
Not sure what exactly that means, it works for this usecase at least. Would probably need some adjustments... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47486 --- Comment #4 from Fabian Maurer <dark.shadow4(a)web.de> --- I need to write some tests, I'll be coming back to this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47486 --- Comment #5 from Fabian Maurer <dark.shadow4(a)web.de> --- Still present as of wine-7.7. Might also affect gdi32, which also uses a "is_dib_monochrome" function. Needs tests though. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47486 --- Comment #6 from Fabian Maurer <dark.shadow4(a)web.de> --- Still present in wine-9.11, but you need to disable the Light theme -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=47486 --- Comment #8 from KRosUser <kyle.kcsoftwares@gmail.com> --- A possible fix/patch https://github.com/reactos/reactos/pull/8588/files -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=47486 --- Comment #9 from KRosUser <kyle.kcsoftwares@gmail.com> --- A good fix is available here : https://github.com/reactos/reactos/commit/076699bff6a8c80668f670d8e39952f159... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=47486 Dmitry Timoshkov <dmitry@baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://jira.reactos.org/br | |owse/CORE-13935 | --- Comment #10 from Dmitry Timoshkov <dmitry@baikal.ru> --- (In reply to KRosUser from comment #9)
A good fix is available here : https://github.com/reactos/reactos/commit/ 076699bff6a8c80668f670d8e39952f1590a19d3
You've been asked multiple times already to stop posting reactos references here. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=47486 --- Comment #11 from KRosUser <kyle.kcsoftwares@gmail.com> --- Duplicate of bug51743 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=47486 --- Comment #12 from Fabian Maurer <dark.shadow4@web.de> --- Are you sure this is the same issue? I intentionally made the other for the hovered issue, not the white background. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=47486 --- Comment #13 from KRosUser <kyle.kcsoftwares@gmail.com> --- My mistake then. Did you see the fix proposal in user 32 cursoricon.c ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=47486 --- Comment #14 from Fabian Maurer <dark.shadow4@web.de> --- Yeah, there's also an attached patch from me here :) I'm currently not active in Wine development though. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (3)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla
-
WineHQ Bugzilla