[Bug 60518] New: GetRequestedRuntimeInfo crashes with pVersion=NULL and cchBuffer=0

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=60518

            Bug ID: 60518
           Summary: GetRequestedRuntimeInfo crashes with pVersion=NULL and
                    cchBuffer=0
           Product: Wine
           Version: 11.19
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: mscoree
          Assignee: [e-mail]
          Reporter: [e-mail]
  Target Milestone: ---
      Distribution: ---

Created attachment 82376
  --> http://bugs.winehq.org/attachment.cgi?id=82376
Log of `WINEDEBUG=+mscoree,+seh wine "$HOME/Downloads/launch.msi"`

The current Bay ROES installer (https://bayphoto.com/order/bay-roes/) runs a
custom DLL during installation, which eventually calls GetRequestedRuntimeInfo
with pVersion=NULL and cchBuffer=0 (probably trying to size an output buffer).
The implementation does not check cchBuffer != 0 before doing a write to
pVersion. (This write is trying to preserve v/V from the input buffer.) When
pVersion is NULL, this crashes.

Log of installation attempt is attached.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 60518] GetRequestedRuntimeInfo crashes with pVersion=NULL and cchBuffer=0

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=60518

--- Comment #1 from George Hilliard <[e-mail]> ---
Created attachment 82377
  --> http://bugs.winehq.org/attachment.cgi?id=82377
0001-mscoree-Respect-output-buffer-length-when-preserving.patch

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 60518] GetRequestedRuntimeInfo crashes with pVersion=NULL and cchBuffer=0

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=60518

--- Comment #2 from George Hilliard <[e-mail]> ---
Attached a patch which fixes this and adds a test for NULL, 0 input.

After an additional `winetricks dotnet48`, Bay ROES now installs and runs.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 60518] GetRequestedRuntimeInfo crashes with pVersion=NULL and cchBuffer=0

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=60518

Austin English <[e-mail]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, Installer
                URL|                            |https://bayphoto.com/order/
                   |                            |bay-roes/

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.