[Bug 44130] New: Possible access to unintended variable in "dlls/comctl32/ imagelist.c" line 299

https://bugs.winehq.org/show_bug.cgi?id=44130

            Bug ID: 44130
           Summary: Possible access to unintended variable in
                    "dlls/comctl32/imagelist.c" line 299
           Product: Wine
           Version: 2.22
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: wine-bugs(a)winehq.org
          Reporter: petrum(a)gmail.com
      Distribution: ---

While experimenting with a CodeSonar plugin we develop, we noticed a
potential bug in file "dlls/comctl32/imagelist.c" line 299 function 
add_with_alpha

mask_info->bmiHeader = info->bmiHeader;
mask_info->bmiHeader.biBitCount = 1;
mask_info->bmiHeader.biSizeImage = mask_width * height;
//299 line is the next one
if (!(mask_bits = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, /*HERE*/
info->bmiHeader.biSizeImage )))
    goto done;
if (!GetDIBits( hdc, hbmMask, 0, height, mask_bits, mask_info, DIB_RGB_COLORS
)) goto done;

Shouldn't you access mask_info (instead of info)?

Regards,
Petru Florin Mihancea

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 44130] Possible access to unintended variable in "dlls/comctl32/ imagelist.c" line 299

https://bugs.winehq.org/show_bug.cgi?id=44130

Fabian Maurer <dark.shadow4(a)web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dark.shadow4(a)web.de

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 44130] Possible access to unintended variable in "dlls/comctl32/ imagelist.c" line 299

https://bugs.winehq.org/show_bug.cgi?id=44130

Nikolay Sivov <bunglehead(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |5dd9a1f00e7cbc30b306b8290c1
                   |                            |8b781f27e6af2
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> ---
This is fixed now,
http://source.winehq.org/git/wine.git/?a=commit;h=5dd9a1f00e7cbc30b306b8290c....
Thanks for the report.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 44130] Possible access to unintended variable in "dlls/comctl32/ imagelist.c" line 299

https://bugs.winehq.org/show_bug.cgi?id=44130

Alexandre Julliard <julliard(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard <julliard(a)winehq.org> ---
Closing bugs fixed in 3.0-rc2.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 44130] Possible access to unintended variable in "dlls/comctl32/ imagelist.c" line 299

https://bugs.winehq.org/show_bug.cgi?id=44130

Michael Stefaniuc <mstefani(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.0.x

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 44130] Possible access to unintended variable in "dlls/comctl32/ imagelist.c" line 299

https://bugs.winehq.org/show_bug.cgi?id=44130

Michael Stefaniuc <mstefani(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2.0.x                       |---

--- Comment #3 from Michael Stefaniuc <mstefani(a)winehq.org> ---
Removing the 2.0.x milestone from bugs included in 2.0.5.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.