[Bug 20703] New: ACDSee crashing after creating new folder
http://bugs.winehq.org/show_bug.cgi?id=20703 Summary: ACDSee crashing after creating new folder Product: Wine Version: 1.1.33 Platform: PC URL: http://www.oldversion.com/download_ACDSee_3.10.html OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: lahmbi5675(a)gmx.de Created an attachment (id=24734) --> (http://bugs.winehq.org/attachment.cgi?id=24734) Console output ACDSee crasing after creating new folder I'm using quite old versions of ACDSee, 2.45 and 3.1, German version. Wine version is 1.1.33, mode is win98. Steps to reproduce: Start ACDSee, left-click on the listview control, a context menu will appear, click on "New folder". You will see a "New folder" item in the listview, which is editable and has text cursor on it. Press Enter, ACDSee crashes. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 --- Comment #1 from lahmbi5675(a)gmx.de 2009-11-14 11:08:11 --- It should of course read "right-click on the listview control" to get a context menu. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 Wylda <wylda(a)volny.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thestig(a)google.com, | |wylda(a)volny.cz --- Comment #2 from Wylda <wylda(a)volny.cz> 2009-11-14 13:36:21 --- Looks like crash is caused by Lei Zhang commit... 1. Confirming for ACDSee 2.45 (German), please consider UNCONFIRMED->NEW and KEYWORDS: +REGRESSION, +DOWNLOAD 2. Did a regression test between 1.1.7 and 1.1.8: 10d3ea30b766aa63ed9590a1a90ac913b9875f70 is first bad commit commit 10d3ea30b766aa63ed9590a1a90ac913b9875f70 Author: Lei Zhang <thestig(a)google.com> Date: Wed Oct 29 01:58:46 2008 -0700 comctl32: Don't notify if listview edit box contents have not changed. :040000 040000 60726c8f487831c6b185b5ad3da8594d7da9096a 8611baf514846fdc51f3443cfcb1c1ba02a77dea M dlls 3. No other bug report suffers from this commit. 4. Revert of this patch on top of wine-1.1.8 fails due to other code changes. 5. Adding author of this patch to CC. --private keyword: bisected -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression Component|-unknown |comctl32 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-11-14 13:53:49 --- (In reply to comment #2)
Looks like crash is caused by Lei Zhang commit...
1. Confirming for ACDSee 2.45 (German), please consider UNCONFIRMED->NEW and KEYWORDS: +REGRESSION, +DOWNLOAD
2. Did a regression test between 1.1.7 and 1.1.8:
10d3ea30b766aa63ed9590a1a90ac913b9875f70 is first bad commit commit 10d3ea30b766aa63ed9590a1a90ac913b9875f70 Author: Lei Zhang <thestig(a)google.com> Date: Wed Oct 29 01:58:46 2008 -0700
comctl32: Don't notify if listview edit box contents have not changed.
:040000 040000 60726c8f487831c6b185b5ad3da8594d7da9096a 8611baf514846fdc51f3443cfcb1c1ba02a77dea M dlls
Looks valid for me. Native fires LVN_ENDLABELEDIT if text didn't changed too. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-11-14 20:39:17 --- Created an attachment (id=24745) --> (http://bugs.winehq.org/attachment.cgi?id=24745) Always send LVN_ENDLABELEDIT notification Try this patch please over 1.1.33. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 --- Comment #5 from Wylda <wylda(a)volny.cz> 2009-11-14 21:34:44 --- Created an attachment (id=24748) --> (http://bugs.winehq.org/attachment.cgi?id=24748) Crash log from patched wine-1.1.33 (In reply to comment #4)
Created an attachment (id=24745) --> (http://bugs.winehq.org/attachment.cgi?id=24745) [details] Always send LVN_ENDLABELEDIT notification
Try this patch please over 1.1.33.
Unfortunately still crashes, even when i applied your patch. Fresh console log from patched wine-1.1.33 attached. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bunglehead(a)gmail.com --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-11-14 22:43:07 --- (In reply to comment #5)
Unfortunately still crashes, even when i applied your patch. Fresh console log from patched wine-1.1.33 attached.
Ok. So the reason is that dispinfo data isn't available at a point we request it, two ways to check this: - ask Lei what this patch was for; - test native behaviour for crash in LVN_GETDISPINFO handler in notification window, probably we should add exception handler. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 --- Comment #7 from Lei Zhang <thestig(a)google.com> 2009-11-15 21:41:34 --- My patch was to fix bug 15756. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-11-16 07:32:40 --- (In reply to comment #7)
My patch was to fix bug 15756.
Fix is wrong unfortunately. LVN_ENDLABELEDIT is sent anyway, ControlSpy shows that. For this bug problem seems to be in LVN_GETDISPINFO sent at wrong time, when parent isn't ready for that (notification sent from LISTVIEW_GetItemT to get current text). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 --- Comment #9 from Wylda <wylda(a)volny.cz> 2010-02-28 01:31:55 --- This bisected regression is still not fixed in wine-1.1.39-163-g583f0f0. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 --- Comment #10 from Wylda <wylda(a)volny.cz> 2010-04-17 14:54:19 --- FIXED in wine-1.1.43. Particular commit (wine-1.1.40-100-g4f20455): http://source.winehq.org/git/wine.git/?a=commit;h=4f20455e4c467d79a044558816... Thanks Jeff. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 Wylda <wylda(a)volny.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lats(a)yless4u.com.au -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #11 from Austin English <austinenglish(a)gmail.com> 2010-04-17 15:06:47 --- Reported fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #12 from Alexandre Julliard <julliard(a)winehq.org> 2010-05-07 13:29:38 --- Closing bugs fixed in 1.1.44. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |4f20455e4c467d79a044558816a | |7cae90552b03e -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20703 Wylda <wylda(a)volny.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |10d3ea30b766aa63ed9590a1a90 | |ac913b9875f70 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org