[Bug 45299] New: Adoble flash player online installer fails the download
https://bugs.winehq.org/show_bug.cgi?id=45299 Bug ID: 45299 Summary: Adoble flash player online installer fails the download Product: Wine Version: 3.9 Hardware: x86 URL: https://admdownload.adobe.com/bin/live/flashplayer29_a _install.exe OS: Linux Status: NEW Keywords: download, regression Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: dark.shadow4(a)web.de Distribution: --- The installer errors with "Connection error". It works with wine-2.12, but fails with wine-2.13. I'll add a regression test tomorrow. The same issue affects ReactOS, see https://jira.reactos.org/browse/CORE-13952. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://jira.reactos.org/br | |owse/CORE-13952 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adoble flash player online |Adobe flash player online |installer fails the |installer fails the |download |download -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |5226865c5324f366ad6974ddb82 | |91adc20759019 --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Bisected to commit 5226865c5324f366ad6974ddb8291adc20759019 Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 18 00:25:15 2017 +0200 winhttp: Cache and reuse persistent HTTP connections. However, it doesn't revert cleanly, there were other changes in the same code. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 --- Comment #2 from Hans Leidekker <hans(a)meelstraat.net> --- (In reply to Fabian Maurer from comment #1)
Bisected to commit 5226865c5324f366ad6974ddb8291adc20759019 Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 18 00:25:15 2017 +0200
winhttp: Cache and reuse persistent HTTP connections.
However, it doesn't revert cleanly, there were other changes in the same code.
The problem is that the connection object is moved to the connection cache when we're finished reading data while the flash player installer wants to retrieve the server certificate after consuming the data. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 --- Comment #3 from Hans Leidekker <hans(a)meelstraat.net> --- Created attachment 61563 --> https://bugs.winehq.org/attachment.cgi?id=61563 patch This patch should help. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://admdownload.adobe.c |https://admdownload.adobe.c |om/bin/live/flashplayer29_a |om/bin/live/flashplayer30_a |_install.exe |_install.exe --- Comment #4 from Fabian Maurer <dark.shadow4(a)web.de> --- Only a bit, it still errors - but when clicking on retry it downloads up to 17%, then gives an "Connection Error". -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 --- Comment #5 from Hans Leidekker <hans(a)meelstraat.net> --- (In reply to Fabian Maurer from comment #4)
Only a bit, it still errors - but when clicking on retry it downloads up to 17%, then gives an "Connection Error".
I get a different message. It tells me that the installer is outdated and needs to be downloaded again. I get the same message on Windows. Can you attach a +winhttp trace? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 --- Comment #6 from Fabian Maurer <dark.shadow4(a)web.de> --- I edited the download link, you need https://admdownload.adobe.com/bin/live/flashplayer30_a_install.exe for testing now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 --- Comment #7 from Hans Leidekker <hans(a)meelstraat.net> --- (In reply to Fabian Maurer from comment #6)
I edited the download link, you need https://admdownload.adobe.com/bin/live/flashplayer30_a_install.exe for testing now.
Thanks, I've submitted a patch that fixes this installer. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 --- Comment #8 from Fabian Maurer <dark.shadow4(a)web.de> --- Great, thank you. Out of curiosity, why did your other patch not work? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 --- Comment #9 from Hans Leidekker <hans(a)meelstraat.net> --- (In reply to Fabian Maurer from comment #8)
Great, thank you.
Out of curiosity, why did your other patch not work?
It didn't cover the case where the app closes the request and then creates a new request for the same host. That didn't show up in my testing because the first request succeeded with the initial patch and then the installer bailed out because it had found that the installer was too old. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 Hans Leidekker <hans(a)meelstraat.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |f5ea51d36092b162ca49555c927 | |ba51608f64f92 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #10 from Hans Leidekker <hans(a)meelstraat.net> --- Fixed by f5ea51d36092b162ca49555c927ba51608f64f92. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 Hans Leidekker <hans(a)meelstraat.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |winhttp -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #11 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.11. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45299 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |--- --- Comment #12 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 3.0.x milestone from bugs included in 3.0.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org