[Bug 50433] New: 'MsiBreak' custom action debugging aid should use custom action's name from 'CustomAction' table (currently uses 'Target' field)
https://bugs.winehq.org/show_bug.cgi?id=50433 Bug ID: 50433 Summary: 'MsiBreak' custom action debugging aid should use custom action's name from 'CustomAction' table (currently uses 'Target' field) Product: Wine Version: 6.0-rc4 Hardware: x86-64 OS: Linux Status: NEW Severity: trivial Priority: P2 Component: msi Assignee: wine-bugs(a)winehq.org Reporter: focht(a)gmx.net Distribution: --- Hello folks, I always have to remember that Wine uses 'Target' field/name from the 'CustomAction' table instead of the custom action's name when debugging custom actions. Fooled me quite a number of times in these 13 years. I'm aware that very few people might be concerned/affected with this inconsistency but still. https://docs.microsoft.com/en-us/windows/win32/msi/debugging-custom-actions I requested the installer debugging aid in 2007 in bug 8243 ("Feature: Add MsiBreak to aid debugging custom actions"): https://source.winehq.org/git/wine.git/commitdiff/60e95ee6e8ea4a4f43a6c170c9... ("msi: Add handling for MsiBreak.") My follow-up comment https://bugs.winehq.org/show_bug.cgi?id=8243#c7 was ignored. Maybe because I didn't bother to create a follow-up bug and/or didn't complain loud enough ;-) --- quote --- Please fix the evaluation to use "action" msi_custom_action_info member instead of "target" to make it feature compatible with Windows MSI server. --- quote --- Some example (from bug 21987): --- snip --- ... 01b0:trace:msi:ACTION_CustomAction Handling custom action L"CreateAdobePDFPrinter" (c41 L"AdobeIsf" L"SetupAdobePDFPrinter") ... 01b0:trace:msi:HANDLE_CustomType1 Calling function L"SetupAdobePDFPrinter" from L"C:\\users\\focht\\Temp\\msi48b7.tmp" ... 02f8:Ret PE DLL (proc=0160618A,module=01600000 L"msi48b7.tmp",reason=PROCESS_ATTACH,res=00000000) retval=1 ... 02f8:Ret KERNEL32.LoadLibraryW() retval=01600000 ret=100210f6 02f8:Call KERNEL32.GetProcAddress(01600000,0016df28 "SetupAdobePDFPrinter") ret=1002110a 02f8:Ret KERNEL32.GetProcAddress() retval=01602bea ret=1002110a ... --- snip --- To have this work for Wine 'MsiBreak=SetupAdobePDFPrinter' is needed but 'MsiBreak=CreateAdobePDFPrinter' would be correct. $ wine --version wine-6.0-rc4 Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50433 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, Installer URL| |https://web.archive.org/web | |/20061114115407/http://ardo | |wnload.adobe.com/pub/adobe/ | |acrobat/win/7x/7.0/misc/AcT | |R7EFG.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50433 temp82(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |temp82(a)luukku.com --- Comment #1 from temp82(a)luukku.com --- https://source.winehq.org/patches/data/223998 got merged. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50433 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |b74b634335c8d843e6dc2ef21e5 | |d9248ca05bae9 Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, this is fixed by commit https://source.winehq.org/git/wine.git/commitdiff/b74b634335c8d843e6dc2ef21e... ("msi: Use custom action name for MsiBreak handling."). Thanks Hans Thanks Jarkko for the reminder. It seems Wine has regressed. The original custom action 'CreateAdobePDFPrinter' isn't reached anymore (hangs before). I will check if this is a known bug. Using an earlier custom action for validation: --- snip --- $ MsiBreak=CreatePortMonitor WINEDEBUG=+seh,+loaddll,+msi,+msgbox wine msiexec -i AcroPro.msi ... 0100:trace:msi:ACTION_CustomAction Handling custom action L"CreatePortMonitor" (c41 L"AdobeIsf" L"SetupPortMonitor") ... 0100:trace:msi:HANDLE_CustomType1 Calling function L"SetupPortMonitor" from L"C:\\users\\focht\\Temp\\msibd.tmp" 0100:trace:msi:wait_thread_handle waiting for L"CreatePortMonitor" 0238:trace:msi:__wine_msi_call_dll_function {ef2d1a17-b09a-4f4b-b946-32146ff682a7} 0210:trace:msi:alloc_msihandle 004655C0 -> 1 0238:trace:msi:alloc_msi_remote_handle 1 -> 1 0238:trace:loaddll:build_module Loaded L"C:\\windows\\syswow64\\WINSPOOL.DRV" at 024F0000: builtin 0238:trace:loaddll:build_module Loaded L"C:\\users\\focht\\Temp\\msibd.tmp" at 023B0000: native 0238:trace:loaddll:build_module Loaded L"C:\\windows\\syswow64\\uxtheme.dll" at 02520000: builtin 0238:trace:msgbox:MSGBOX_OnInit L"To debug your custom action, attach your debugger to process 264 (0x108) and press OK" --- snip --- https://www.virustotal.com/gui/file/d9270dc2abfb3c0e216af188343dbd0058c60253... $ sha1sum AcTR7EFG.exe 4f1ff389ea71f21d624083d65bbe5a74e4760079 AcTR7EFG.exe $ du -sh AcTR7EFG.exe 116M AcTR7EFG.exe $ wine --version wine-7.0-119-gc09a5da1575 Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50433 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #3 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50433 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |7.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50433 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|7.0.x |--- --- Comment #4 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 7.0.x milestone from bug fixes included in 7.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla