[Bug 58228] New: Move child object page unable to fully load because it is too long
http://bugs.winehq.org/show_bug.cgi?id=58228 Bug ID: 58228 Summary: Move child object page unable to fully load because it is too long Product: WineHQ Apps Database Version: unspecified Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: appdb-unknown Assignee: wine-bugs(a)winehq.org Reporter: dimesio(a)earthlink.net Distribution: --- When merging entries, the page that shows the entries to move the child objects to displays as one long list in alphabetical order. That list is now so long that the page cannot fully load: Ooops! Something has gone terribly wrong! Our monkey train has derailed! Worry not, a webmaster gopher help army has been dispatched and is on the way. If this error continues to be a problem, please report it to us on our Forums error details: Error Message: Maximum execution time of 60 seconds exceeded File: query.php:119 Discovered while trying to merge 千千静听 (TTPlayer) https://appdb.winehq.org/objectManager.php?sClass=application&iId=11003 with TTPlayer https://appdb.winehq.org/objectManager.php?sClass=application&iId=6077. The move child objects page only got as far as the H's before timing out. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 Jens Reyer <jre.winesim(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jre.winesim(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |46461 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 --- Comment #1 from Rosanne DiMesio <dimesio@earthlink.net> --- Still a problem; I ran into this again while trying to move a test assigned to an invalid entry, as reported on the forum (https://forum.winehq.org/viewtopic.php?p=151282#p151282). Since the entry to be moved to was World of Warcraft, I had to temporarily rename it to 00 World of Warcraft to get it to display on the first page, then rename it back after the move. That worked, but we shouldn't have to do that. Other long displays, such as the list of operating systems, break the display into pages, defaulting to 25 items per page but with the option to increase it to 50, 100, or 200. We need something like that for the list to merge entries. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 Stian Low <wineryyyyy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wineryyyyy@gmail.com --- Comment #2 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Rosanne DiMesio from comment #1)
Still a problem; I ran into this again while trying to move a test assigned
MR-47 pending fix: - https://gitlab.winehq.org/winehq/appdb/-/merge_requests/47 I was concerned this bug may have been caused by my changes to support Bugzilla separation from AppDB last year to solve traffic problems but it was reported before I ever contributed to WineHQ and I've never touched the files until now so it was not related but I figured it was fairly straightforward enough to fix while I checked. Please let me know if it breaks anything. I do not have enough time for further testing at the moment. Paging features are automatically supported for CMS apps without any code changes where AppDB may be able to migrate to eventually as an upgrade: - https://bugs.winehq.org/show_bug.cgi?id=60100 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 --- Comment #3 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #2)
MR-47 pending fix: - https://gitlab.winehq.org/winehq/appdb/-/merge_requests/47
MR-47 merged. Please let me know if it breaks anything or if anything else should be changed. Otherwise this bug may be closed as fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 --- Comment #4 from Rosanne DiMesio <dimesio@earthlink.net> --- (In reply to Stian Low from comment #3)
(In reply to Stian Low from comment #2)
MR-47 pending fix: - https://gitlab.winehq.org/winehq/appdb/-/merge_requests/47
MR-47 merged.
Please let me know if it breaks anything or if anything else should be changed.
Otherwise this bug may be closed as fixed.
This is not fixed. I just tried to move the Steam version of Melty Blood to Melty Blood:Actress Again:Current Code and there is no pager. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 --- Comment #5 from Stian Low <wineryyyyy@gmail.com> --- Created attachment 81792 --> http://bugs.winehq.org/attachment.cgi?id=81792 Screenshots paging for "Move child objects" for GNU Emacs for my Super Maintainer account (In reply to Rosanne DiMesio from comment #4)
This is not fixed. I just tried to move the Steam version of Melty Blood to Melty Blood:Actress Again:Current Code and there is no pager.
Thanks for testing. Did I mistake "Move child objects" to merge entries for a different webpage that also needs paging support? Please let me know any other pages that need paging support. It should be fairly easy to apply the same paging feature to any other webpage that may need it. Also, "Move child objects" button seems restricted to only admins and super maintainers of apps but the move page lists all apps. Should merge/move list be limited to only those other apps to which super maintainers share the same role access? I did not attempt to merge any to check if a super maintainer may merge their app with one that they are not super maintainer. It seems to violate the current roles/security model unless I'm misunderstanding super maintainers role which DB assigns per app rather than a global role like 'admin'. I originally tested for localhost as admin and assumed the entire move/merge child list was based on having full permissions which seems a false assumption based on live server listing all apps for merge access for my super maintainership for GNU Emacs. If merge apps list needs to be limited/restricted for super maintainers then it should probably be handled by a separate bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 --- Comment #6 from Rosanne DiMesio <dimesio@earthlink.net> --- What I clicked on was "Move to a different application", which moves a single version and all its child objects to a different application entry. Sorry, I didn't realize the page it displayed was a different one. That definitely needs paging. As for permissions, you are correct, super maintainers should not be able to merge an app they maintain with one they do not maintain. If they can, it is a bug, but not one I would see, since my account is an admin account. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 --- Comment #7 from Stian Low <wineryyyyy@gmail.com> --- Created attachment 81797 --> http://bugs.winehq.org/attachment.cgi?id=81797 Screenshots button (right side greyed/hovered button) corresponding to paging support (left side): MR-49 pending to support paging for other app and version move child and parent operations: - https://gitlab.winehq.org/winehq/appdb/-/merge_requests/49 (In reply to Rosanne DiMesio from comment #6)
Sorry, I didn't realize the page it displayed was a different one. That definitely needs paging.
No worries. I thought the others might also need support also but didn't have much time to spend expanding further and forgot to raise it.
As for permissions, you are correct, super maintainers should not be able to merge an app they maintain with one they do not maintain. If they can, it is a bug, but not one I would see, since my account is an admin account.
Thanks for clarifying. I'll open a separate bug for limiting move listings per super/maintainer access as suggested. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 --- Comment #8 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #7)
Created attachment 81797 [details] Screenshots button (right side greyed/hovered button) corresponding to paging support (left side):
Correction: Flip left side (buttons) for right side (paging). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 --- Comment #9 from Stian Low <wineryyyyy@gmail.com> --- May be even better to add search/filtering to deal with the lengthiest lists but at least paging will keep SQL from timing out. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 --- Comment #10 from Rosanne DiMesio <dimesio@earthlink.net> --- (In reply to Stian Low from comment #9)
May be even better to add search/filtering to deal with the lengthiest lists but at least paging will keep SQL from timing out.
Move to another application now has a pager; thanks. You are right about adding search/filtering--even if I set the page to 200 items/page there are still 84 pages. But at least it doesn't time out. The bad news is the Submit app link is now broken. I filed bug 60176 for that. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58228 --- Comment #11 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Rosanne DiMesio from comment #10)
Move to another application now has a pager; thanks. You are right about adding search/filtering--even if I set the page to 200 items/page there are still 84 pages. But at least it doesn't time out.
The bad news is the Submit app link is now broken. I filed bug 60176 for that.
Thanks for testing. Sorry for breaking. I should have tested submitting some apps rather than just inserting records directly into DB to save time testing paging. MR-50 pending one line fix to bug accidentally introduced by MR-47. Removing the hidden field seems not to break paging features added by MR-49 so it was just a left over from testing that should not have been included for MR-47. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla