[Bug 58744] New: Missing Type on get_type within dlls/msi/suminfo.c

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58744

            Bug ID: 58744
           Summary: Missing Type on get_type within dlls/msi/suminfo.c
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: msi
          Assignee: wine-bugs(a)winehq.org
          Reporter: matgrioni(a)gmail.com
      Distribution: ---

For a certain use case I wanted to run Microsoft Keyboard Layout Creator
(MSKLC) on a serverless function and therefore was trying to get it to run on
Wine.

The application takes a keyboard layout definition and then has functionality
to create a MSI which contains the DLL for the created keyboard. When running
this compilation step, the MSI creation was failing and I was able to identify
that the MSI creation process with MSKLC was calling MsiSummaryInfoSetPropertyW
with property PID_EDITTIME which is missing from /dlls/msi/suminfo.c:get_type
and should have type VT_FILETIME according to this documentation:
https://learn.microsoft.com/en-us/windows/win32/msi/summaryinfo-summaryinfo.

By adding PID_EDITTIME to the function, I was able to unblock this part.

Overall it's a trivial problem and fix, I figure in part it hasn't been run
into is that the use case of *creating* an MSI (rather than running it), is
quite small, and it seems the EDITTIME property may not be read from on
installation.

I created a bug for it, since I was having issues creating a fork and the
problem is quite trivial, and my ability to contribute to wine will probably
not extend much beyond this issue :)

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 58744] Missing Type on get_type within dlls/msi/suminfo.c

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58744

Hans Leidekker <hans(a)meelstraat.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |3c97358fb00fa715c1b9ad183d5
                   |                            |53ae052db01c9
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Hans Leidekker <hans(a)meelstraat.net> ---
Fixed by 3c97358fb00fa715c1b9ad183d553ae052db01c9. Thanks for the bug report!

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 58744] Missing Type on get_type within dlls/msi/suminfo.c

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58744

Alexandre Julliard <julliard(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard <julliard(a)winehq.org> ---
Closing bugs fixed in 10.16.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.