[Bug 44820] New: Processes might terminate with incorrect exit code due to race-condition when threads are killed during shutdown
https://bugs.winehq.org/show_bug.cgi?id=44820 Bug ID: 44820 Summary: Processes might terminate with incorrect exit code due to race-condition when threads are killed during shutdown Product: Wine Version: 3.4 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs(a)winehq.org Reporter: focht(a)gmx.net Distribution: --- Hello folks, to track https://github.com/wine-staging/wine-staging/tree/master/patches/ntdll-Threa... Unfortunately there is no further information/details, I just found this: https://wine-staging.com/news/2015-03-07-release-1.7.38.html -> https://github.com/wine-staging/wine-staging/blob/v1.7.38/debian/changelog --- quote --- * Added patch to fix race-condition when threads are killed during shutdown. --- quote --- https://github.com/wine-staging/wine-staging/blob/master/patches/ntdll-Threa... --- quote --- When exit_thread is executed, nb_threads is decremented before the thread is fully shutdown. When another thread runs ExitProcess() this will cause a SIGQUIT signal to all threads, effectively decrementing nb_threads twice. The process will terminate with a wrong exitcode then because the refcount reaches zero too early. Currently Wine has no locking protection of LdrShutdownProcess(), so it can only be executed safely when all other threads have terminated before. Most likely there are more Wine bugs in this area, but the attached patch should fix the most critical one (messed up refcounting of threads) for now. --- quote --- Sadly no applications are mentioned that could be used to validate the problem. $ wine --version wine-3.4 Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44820 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/ntdll-Threading Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44820 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44820 tokktokk <fdsfgs(a)krutt.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs(a)krutt.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=44820 Giacomo Orlandi <gia_@inwind.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gia_@inwind.it --- Comment #1 from Giacomo Orlandi <gia_@inwind.it> --- The staging patch linked here was removed from Staging by Elizabeth Figura in the following commit: https://gitlab.winehq.org/wine/wine-staging/-/commit/e1966ac26ea98127005fc8c... In that commit there a is a nice explanation of the issue and how it was resolved. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=44820 Zeb Figura <z.figura12@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |2334f4e64582a518e4d5a762747 | |2a0d817b147ef CC| |z.figura12@gmail.com Resolution|--- |FIXED Status|STAGED |RESOLVED --- Comment #2 from Zeb Figura <z.figura12@gmail.com> --- I think we can call this fixed by 2334f4e64582a518e4d5a7627472a0d817b147ef. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=44820 Alexandre Julliard <julliard@winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #3 from Alexandre Julliard <julliard@winehq.org> --- Closing bugs fixed in 11.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=44820 Giacomo Orlandi <gia_@inwind.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gia_@inwind.it | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla