[Bug 54037] New: user32:msg - test_SendMessage_other_thread() sometimes gets a todo success (GitLab CI)
https://bugs.winehq.org/show_bug.cgi?id=54037 Bug ID: 54037 Summary: user32:msg - test_SendMessage_other_thread() sometimes gets a todo success (GitLab CI) Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com Distribution: --- user32:msg - test_SendMessage_other_thread() sometimes gets a todo success: msg.c:19067: Test succeeded inside todo block: WaitForSingleObject failed, ret:0 msg.c:19091: Test succeeded inside todo block: wrong status 00000000 See https://test.winehq.org/data/patterns.html#user32:msg This happens about once a month on the Debian VMs in the TestBot nightly WineTest runs, but is also known to impact the GitLab CI (e.g. MR!1596 MR!1519 ). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54037 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54037 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.pouech(a)gmail.com, | |rbernon(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54037 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd(a)gmail.com --- Comment #1 from François Gouget <fgouget(a)codeweavers.com> --- The 'wrong status 0' unexpected success last happened on 2023-09-12. The 'WaitForSingleObject' unexpected success is still happening regularly however, including on the GitLab CI (the TestBot failed to recognize it for a while because of the additional thread_2). msg.c:19713: Test succeeded inside todo block: thread_2: WaitForSingleObject failed, ret:0 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54037 --- Comment #2 from Esme Povirk <madewokherd(a)gmail.com> --- Documenting so I don't have to figure this out again: There's an obvious race condition the SendMessage_thread_2 case. The thread calls SetParent immediately before a SendMessage. The expectation is that on Wine the foreground thread will wait for QS_SENDMESSAGE, wake (incorrectly) after the SetParent call, and then process one posted message from the queue, leaving the background thread stuck in its SendMessage call. However, if the background thread's SendMessage call happens before the foreground thread processes the posted message, the foreground thread will handle both posted messages in a single GetMessage call. I don't think this test case is appropriate for testing that SetParent doesn't use an internal message on Windows. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54037 Esme Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |886b778aaa13c5b36a6996c7610 | |5f5a80e97446e Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Esme Povirk <madewokherd(a)gmail.com> --- Replaced this with a simpler (and hopefully more robust) test. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54037 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 9.0-rc1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla