[Bug 33456] New: D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used
http://bugs.winehq.org/show_bug.cgi?id=33456 Bug #: 33456 Summary: D3DXMatrixTransformation: Broken calculation when scalingrotation and scaling is used Product: Wine Version: unspecified Platform: x86 OS/Version: Linux Status: NEW Keywords: testcase Severity: normal Priority: P2 Component: directx-d3dx9 AssignedTo: wine-bugs(a)winehq.org ReportedBy: kgbricola(a)web.de CC: wine-bugs(a)winehq.org Classification: Unclassified Created attachment 44286 --> http://bugs.winehq.org/attachment.cgi?id=44286 D3DXMatrixTransformation test case - 22 failed tests While trying to improve the speed of D3DXMatrixTransformation(), I found that the calculation when using scalingrotation and scaling at the same time is wrong. The full formula is (according to msdn): Mout = (Msc)-1 * (Msr)-1 * Ms * Msr * Msc * (Mrc)-1 * Mr * Mrc * Mt while the failing part is: (Msr)-1 * Ms * Msr So this might not be the correct equivalent: ... D3DXMatrixRotationQuaternion(&m4, pscalingrotation); //Msr D3DXMatrixInverse(&m2, NULL, &m4); //Msr-1 D3DXMatrixScaling(&m3, pscaling->x, pscaling->y, pscaling->z); //Ms ... D3DXMatrixMultiply(&m1, &m1, &m2); D3DXMatrixMultiply(&m1, &m1, &m3); D3DXMatrixMultiply(&m1, &m1, &m4); ... This may affect other functions as well (e.g. D3DXMatrixTransformation2D()). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 --- Comment #1 from Austin English <austinenglish(a)gmail.com> --- This is your friendly reminder that there has been no bug activity for over a year. Is this still an issue in current (1.7.37 or newer) wine? If so, please attach the terminal output in 1.7.37 (see http://wiki.winehq.org/FAQ#get_log). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #2 from joaopa <jeremielapuree(a)yahoo.fr> --- Bug still there in current wine -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 Paul Gofman <gofmanp(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gofmanp(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 --- Comment #3 from joaopa <jeremielapuree(a)yahoo.fr> --- Created attachment 53994 --> https://bugs.winehq.org/attachment.cgi?id=53994 Fix for D3DXMatrixTransformation This patches fixes the Rico's tests and a bunch of new added tests. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair(a)hotmail.com --- Comment #4 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- (In reply to joaopa from comment #3)
Created attachment 53994 [details] Fix for D3DXMatrixTransformation
This patches fixes the Rico's tests and a bunch of new added tests.
Was this patch ever sent to wine-patches? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 --- Comment #5 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- All test pass. http://testbot.winehq.org/JobDetails.pl?Key=22350 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 --- Comment #6 from joaopa <jeremielapuree(a)yahoo.fr> ---
Was this patch ever sent to wine-patches?
No -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 --- Comment #7 from joaopa <jeremielapuree(a)yahoo.fr> --- Bug still there in current wine -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 --- Comment #8 from joaopa <jeremielapuree(a)yahoo.fr> --- Bug still there in current wine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 --- Comment #9 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- (In reply to joaopa from comment #8) Would you consider sending your patch to wine-devel? Or maybe it could be considered for addition in staging? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53994|0 |1 is obsolete| | --- Comment #10 from joaopa <jeremielapuree(a)yahoo.fr> --- Created attachment 62754 --> https://bugs.winehq.org/attachment.cgi?id=62754 Updated patch Patch was sent to wine-devel. But it does not appear in listing of submitted patches. So attaching it here to not lose it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/d3dx9_36-D3DXMat | |rixTransformation -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 --- Comment #11 from joaopa <jeremielapuree(a)yahoo.fr> --- Matteo's patch is in GIT. Can an administrator close this bug as FIXED? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |f54260a789387ab40de3d80291a | |d9000176dabe1 Status|STAGED |RESOLVED --- Comment #12 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Fixed by https://source.winehq.org/git/wine.git/?a=commit;h=f54260a789387ab40de3d8029... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 4.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33456 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |--- --- Comment #14 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 4.0.x milestone from bug fixes included in 4.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org