[Bug 57329] New: Desktop files generated by Wine do not conform to the Desktop Entry Specification
https://bugs.winehq.org/show_bug.cgi?id=57329 Bug ID: 57329 Summary: Desktop files generated by Wine do not conform to the Desktop Entry Specification Product: Wine Version: 9.20 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: meator.dev(a)gmail.com Distribution: --- Desktop files generated by Wine do not conform to the latest (and older) version to of the Desktop Entry Specification, primarily the Exec key specification: https://specifications.freedesktop.org/desktop-entry-spec/1.5/exec-variables... For example, this is how the desktop file for Notepad++ looks like (located at /home/meator/.local/share/applications/wine/Programs/Notepad++.desktop): [Desktop Entry] Name=Notepad++ Exec=env WINEPREFIX="/home/meator/.wine" wine C:\\\\ProgramData\\\\Microsoft\\\\Windows\\\\Start\\ Menu\\\\Programs\\\\Notepad++.lnk Type=Application StartupNotify=true Path=/home/meator/.wine/dosdevices/c:/Program Files/Notepad++ Icon=7ABC_notepad++.0 StartupWMClass=notepad++.exe I will ignore the `env WINEPREFIX="/home/meator/.wine"` part of Exec now. The Exec key parsing is done in two rounds (that's why there are so many backslashes). The first round is common to all keys of type string, localestring and iconstring (which includes the Exec key). The standard mandates:
The escape sequences \s, \n, \t, \r, and \\ are supported for values of type string, localestring and iconstring, meaning ASCII space, newline, tab, carriage return, and backslash, respectively.
This is how the command line looks after undoing the first layer of escapes:
wine C:\\users\\meator\\AppData\\Roaming\\Microsoft\\Windows\\Start\ Menu\\Programs\\Microsoft\ Office\ PowerPoint\ Viewer\ 2003.lnk
Then the Exec quoting continues. The standard mandates:
Quoting must be done by enclosing the argument between double quotes and escaping the double quote character, backtick character ("`"), dollar sign ("$") and backslash character ("\") by preceding it with an additional backslash character. Implementations must undo quoting before expanding field codes and before passing the argument to the executable program. Reserved characters are space (" "), tab, newline, double quote, single quote ("'"), backslash character ("\"), greater-than sign (">"), less-than sign ("<"), tilde ("~"), vertical bar ("|"), ampersand ("&"), semicolon (";"), dollar sign ("$"), asterisk ("*"), question mark ("?"), hash mark ("#"), parenthesis ("(") and (")") and backtick character ("`").
The first problem is that the second argument is not enclosed in double quotes, so all escapes in it are unspecified. The second problem is that `\ ` space escape is used, which is not specified (this is the most severe problem). It is specified as a "reserved character", but not as a character requiring a backslash escape. Because of these issues, fully conformant desktop file parsers will fail to parse desktop files generated by Wine. This is how a fixed Notepad++ desktop file looks like: [Desktop Entry] Name=Notepad++ Exec=env "WINEPREFIX=/home/meator/.wine" wine "C:\\\\ProgramData\\\\Microsoft\\\\Windows\\\\Start Menu\\\\Programs\\\\Notepad++.lnk" Type=Application StartupNotify=true Path=/home/meator/.wine/dosdevices/c:/Program Files/Notepad++ Icon=7ABC_notepad++.0 StartupWMClass=notepad++.exe I have also quoted `WINEPREFIX=/home/meator/.wine` in whole, because the entire argument should be quoted according to the standard (but I consider this issue to be less important). System info =========== OS: Void Linux Wine version: wine-9.20 (downloaded through package manager) Notepad++ download: https://github.com/notepad-plus-plus/notepad-plus-plus/releases/download/v8.... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57329 --- Comment #1 from meator.dev(a)gmail.com --- Created attachment 77310 --> https://bugs.winehq.org/attachment.cgi?id=77310 Modified version of generated Notepad++ desktop file which conforms to the Desktop Entry Specification -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57329 Michael Pfister <schoko.bombe44(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |schoko.bombe44(a)gmail.com --- Comment #2 from Michael Pfister <schoko.bombe44(a)gmail.com> --- I ran into this exact issue using an app-launcher that was adhering to desktop entry specifications as by https://specifications.freedesktop.org/desktop-entry-spec/latest/exec-variab.... This is an example of one of the Exec lines in my wine desktop entries: Exec=env WINEPREFIX="/home/michael/.wine" wine C:\\\\users\\\\michael\\\\AppData\\\\Roaming\\\\Microsoft\\\\Windows\\\\Start\\ Menu\\\\Programs\\\\Games\\\\Pinball.lnk The problem seems to be the space in Start\\ Menu. It is not eligible for plain desktop entry spec implementations running the command directly since the Exec key rule "Arguments are separated by a space." applies. This behavior is also visible in my system journal. I have added the relevant lines to the "Attachments" section. I posted the original issue on https://github.com/albertlauncher/albert/issues/1486 but then came to the realization that this is a problem with wine incorrectly setting the Exec paths on wine desktop entries. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57329 --- Comment #3 from Michael Pfister <schoko.bombe44(a)gmail.com> --- Created attachment 77471 --> https://bugs.winehq.org/attachment.cgi?id=77471 A system journal log where this issue can be seen in action. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57329 Rose Hellsing <rose@pinkro.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rose@pinkro.se --- Comment #4 from Rose Hellsing <rose@pinkro.se> --- I'm unable to reproduce this bug, looking at the git log this was fixed by commit dffc7d70802497ab6015b065e3ed02dec6626666 (which also mentions this bug) So this bug should probably be marked as resolved -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57329 Austin English <austinenglish@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |dffc7d70802497ab6015b065e3e | |d02dec6626666 Status|UNCONFIRMED |RESOLVED --- Comment #5 from Austin English <austinenglish@gmail.com> --- (In reply to Rose Hellsing from comment #4)
I'm unable to reproduce this bug, looking at the git log this was fixed by commit dffc7d70802497ab6015b065e3ed02dec6626666 (which also mentions this bug)
So this bug should probably be marked as resolved
Fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57329 Alexandre Julliard <julliard@winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard@winehq.org> --- Closing bugs fixed in 11.10. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla