[Bug 49172] New: Always true condition `code > 0xffff` in vbscript/global.c
https://bugs.winehq.org/show_bug.cgi?id=49172 Bug ID: 49172 Summary: Always true condition `code > 0xffff` in vbscript/global.c Product: Wine Version: 5.8 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: vbscript Assignee: wine-bugs(a)winehq.org Reporter: mikrutrafal54(a)gmail.com Distribution: --- code > 0xffff is always true - probably code > 0 should look like code < 0 https://github.com/wine-mirror/wine/blob/59987bc9ecdd0dbafd768a95c21a14884bc... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49172 Robert Wilhelm <sloper42(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sloper42(a)yahoo.com --- Comment #1 from Robert Wilhelm <sloper42(a)yahoo.com> --- Tests show that err.raise should set err.number to 5 (=invalid argument) when parameter is 0 or >0xffff. Therefore I think it should read: if(code == 0 || code > 0xffff) return E_INVALIDARG; I send a patch to wine-devel. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49172 --- Comment #2 from Robert Wilhelm <sloper42(a)yahoo.com> --- This is fixed now with commit https://source.winehq.org/git/wine.git/commitdiff/7d48c52816e170eb44dcb64a23... and released in wine-5.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49172 Vijay Kamuju <infyquest(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |infyquest(a)gmail.com Fixed by SHA1| |7d48c52816e170eb44dcb64a236 | |345aaf9cad7fd Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #3 from Vijay Kamuju <infyquest(a)gmail.com> --- Fix confirmed -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49172 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.19. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49172 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49172 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|5.0.x |--- --- Comment #5 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 5.0.x milestone from bug fixes included in 5.0.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla