[Bug 60323] New: Supreme Commander: Forged Alliance crashes on start
http://bugs.winehq.org/show_bug.cgi?id=60323 Bug ID: 60323 Summary: Supreme Commander: Forged Alliance crashes on start Product: Wine Version: 11.0-rc1 Hardware: x86-64 OS: Linux Status: NEW Keywords: regression Severity: normal Priority: P2 Component: xactengine Assignee: wine-bugs@list.winehq.org Reporter: gijsvrm@gmail.com Target Milestone: --- Regression SHA1: d4479c27e6e9f1064849bda0397eef6ff2d82489 Distribution: --- I tested the GOG version using new-WOW64, but the crash is also present with old-WOW64. Bisection revealed: d4479c27e6e9f1064849bda0397eef6ff2d82489 is the first bad commit commit d4479c27e6e9f1064849bda0397eef6ff2d82489 Author: Alexandre Julliard <julliard@winehq.org> Date: Thu Dec 4 13:41:59 2025 +0100 faudio: Import upstream release 25.12. libs/faudio/include/FACT.h | 10 + libs/faudio/include/FAudio.h | 2 +- libs/faudio/src/FACT.c | 396 ++++++++--------- libs/faudio/src/FACT_internal.c | 687 ++++++++++++++---------------- libs/faudio/src/FACT_internal.h | 143 +++++-- libs/faudio/src/FAudio_internal.h | 1 + 6 files changed, 605 insertions(+), 634 deletions(-) After having a look at the crash site and looking at the commits between 25.11 and 25.12, I found that reverting the following commit made the crash go away: commit 3fda8da1223a231494805b2eab7b4a7f20d83286 Author: Elizabeth Figura <zfigura@codeweavers.com> Date: Mon Aug 11 21:55:37 2025 -0500 FACT: Always respect the encoded offsets in the sound bank file. Files which manually encode offsets typically do so for a reason. Asserting that the data is maximally packed is not conceptually correct, and it has already clearly broken parsing. Moreover, we should not be asserting on any invalid input. src/FACT_internal.c | 40 +++++++++++++--------------------------- 1 file changed, 13 insertions(+), 27 deletions(-) One thing I'm not clear on, since these dependencies are imported under /libs, does this still qualify as NOTOURBUG, or should it remain open until fixed upstream and then resolved FIXED once the fix is imported? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60323 Alexandre Julliard <julliard@winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |NOTOURBUG Status|NEW |RESOLVED --- Comment #1 from Alexandre Julliard <julliard@winehq.org> --- I'd say that's NOTOURBUG, particularly since it's possible to build with an external FAudio library. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60323 Alexandre Julliard <julliard@winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=60323 --- Comment #2 from Zeb Figura <z.figura12@gmail.com> --- Fixed in faudio with <https://github.com/FNA-XNA/FAudio/commit/63669eea859e91a88675700164a739b2163...>. Not sure if we should close this when faudio releases or when it's bundled with Wine, but neither have happened yet. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla