[Bug 58510] New: Submitting new test results lists all versions of Wine
http://bugs.winehq.org/show_bug.cgi?id=58510 Bug ID: 58510 Summary: Submitting new test results lists all versions of Wine Product: WineHQ Apps Database Version: unspecified Hardware: x86-64 URL: https://appdb.winehq.org/objectManager.php OS: Linux Status: NEW Keywords: download, regression, source Severity: normal Priority: P2 Component: appdb-unknown Assignee: wine-bugs(a)winehq.org Reporter: imwellcushtymelike(a)gmail.com Regression SHA1: a0e96bdcdbb5f3b950574685d9d9a66c9e9985a9 Distribution: --- Created attachment 78978 --> http://bugs.winehq.org/attachment.cgi?id=78978 HTML A recent change has made submitting a new test result list all versions of Wine, whereas before it was only the last few and the stable release. I'm guessing a0e96bdcdbb5f3b950574685d9d9a66c9e9985a9 may be the commit in question. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58510 Stian Low <wineryyyyy(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wineryyyyy(a)gmail.com --- Comment #1 from Stian Low <wineryyyyy(a)gmail.com> --- This bug was indeed spawned by: https://bugs.winehq.org/show_bug.cgi?id=58473 Test results are not displayed for applications https://bugs.winehq.org/show_bug.cgi?id=56706 AppDB does not properly separate the Bugzilla DB AppDB previously had a separate versions table from Bugzilla and part of the effort to separate them was to have AppDB use the Bugzilla versions list available via HTML at https://bugs.winehq.org/query.cgi?format=advanced. If the versions should not be synced then that may be justification for adding the versions DB table back to AppDB. If the list from Bugzilla is in proper order then it can be limited to only the latest range to narrow the list. Otherwise it may be further justification for just adding the DB table back and storing the versions separately. I'll take a look at the bugzilla repo to see if there's a way to grab a filtered list of versions as another possible solution to narrow the list. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58510 --- Comment #2 from Stian Low <wineryyyyy(a)gmail.com> --- The reasoning behind this change was that the same wine versions when creating a new bug report should be the same list when creating new app version test results. https://bugs.winehq.org/enter_bug.cgi?product=Wine Is there a flaw in that reasoning? Does it matter if all versions are listed? If the list is ordered from latest to oldest is that a sufficient fix so that you don't have to scroll all the way to the bottom? That was missing from the submitted solution. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58510 --- Comment #3 from Ken Sharp <imwellcushtymelike(a)gmail.com> ---
Does it matter if all versions are listed?
I don't really know. If you look at the message next to the box: “Version not listed? Your Wine is too old, upgrade!” Someone wants users to upgrade Wine. Perhaps test results for old versions of Wine are not very useful. Bug reports for old versions of Wine certainly aren't, but you can't hide old versions on Bugzilla because of old bug reports. If users never upgrade then we could have 1,000 results for the same version of Wine, and I doubt that is very useful. I guess it's a policy decision. How were the versions populated originally? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58510 --- Comment #4 from Stian Low <wineryyyyy(a)gmail.com> --- (In reply to Ken Sharp from comment #3)
How were the versions populated originally?
via winehq_appdb_stianlow/tables/bugzilla_tables.sql which was removed during the DB separation merge: -- WineHQ Bugzilla for AppDB Development /* * versions information */ CREATE TABLE `versions` ( `value` varchar(64) NOT NULL default '', `product_id` smallint(6) NOT NULL default '0', `id` mediumint(9) NOT NULL auto_increment, PRIMARY KEY (`id`), UNIQUE KEY `versions_product_id_idx` (`product_id`,`value`) ) ENGINE=MyISAM DEFAULT CHARSET=utf8 PACK_KEYS=1; -- -- Dumping data for table `versions` -- INSERT INTO `versions` VALUES ('unspecified',1,1); INSERT INTO `versions` VALUES ('CVS',1,2); INSERT INTO `versions` VALUES ('unspecified',2,3); INSERT INTO `versions` VALUES ('unspecified',3,4); INSERT INTO `versions` VALUES ('unspecified',4,5); INSERT INTO `versions` VALUES ('20010305',1,6); INSERT INTO `versions` VALUES ('20010216',1,7); INSERT INTO `versions` VALUES ('20010112',1,8); INSERT INTO `versions` VALUES ('20010326',1,9); -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58510 --- Comment #5 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Created attachment 78991 --> http://bugs.winehq.org/attachment.cgi?id=78991 It's already started! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58510 --- Comment #6 from Stian Low <wineryyyyy(a)gmail.com> --- (In reply to Ken Sharp from comment #5)
Created attachment 78991 [details] It's already started!
See pending merge request that attempts a quick fix: https://gitlab.winehq.org/winehq/appdb/-/merge_requests/28 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58510 --- Comment #7 from Stian Low <wineryyyyy(a)gmail.com> --- This bug may be closed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58510 --- Comment #8 from Rosanne DiMesio <dimesio(a)earthlink.net> --- (In reply to Stian Low from comment #7)
This bug may be closed.
This was not completely fixed. The dropdown list now starts with "unspecified" and "main", neither of which are valid versions. It also lists all the 10.0-rc* versions at the bottom of the list, but does not include 10.0, which is newer. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla