[Bug 11936] New: window to small in the vc2008 redist installer
http://bugs.winehq.org/show_bug.cgi?id=11936 Summary: window to small in the vc2008 redist installer Product: Wine Version: 0.9.57. Platform: PC URL: http://download.microsoft.com/download/1/1/1/1116b75a- 9ec3-481a-a3c8-1777b5381140/vcredist_x86.exe OS/Version: Linux Status: NEW Keywords: download, Installer Severity: normal Priority: P2 Component: msi AssignedTo: wine-bugs(a)winehq.org ReportedBy: wine.dev(a)web.de Created an attachment (id=11238) --> (http://bugs.winehq.org/attachment.cgi?id=11238) installer-window in wine The text of the buttons in the installer of the vc2008 runtime libraries are not readable. The location of the Buttons is the same as in w2k, but in wine, the heigh of the window is to small. (you need first: sh winetricks volnum) -- By by ... Detlef -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 --- Comment #1 from Detlef Riekenberg <wine.dev(a)web.de> 2008-03-08 16:56:40 --- Created an attachment (id=11239) --> (http://bugs.winehq.org/attachment.cgi?id=11239) +msi,+msidb,+win logfile with +msi,+msidb,+win -- By by ... Detlef -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 --- Comment #2 from Detlef Riekenberg <wine.dev(a)web.de> 2008-03-08 17:23:58 --- Created an attachment (id=11244) --> (http://bugs.winehq.org/attachment.cgi?id=11244) installer-window in w2k In w2k, window heigh is ok. -- By by ... Detlef -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 Lei Zhang <thestig(a)google.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|window to small in the |window too small in the |vc2008 redist installer |vc2008 redist installer -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 James Hawkins <truiken(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|msi |-unknown --- Comment #3 from James Hawkins <truiken(a)gmail.com> 2008-03-09 13:44:58 --- This installer does not use msi for dialogs...it draws the dialogs itself. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 James Hawkins <truiken(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msclrhd(a)gmail.com --- Comment #4 from James Hawkins <truiken(a)gmail.com> 2008-04-12 16:01:21 --- *** Bug 12511 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 Detlef Riekenberg <wine.dev(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dank(a)kegel.com --- Comment #5 from Detlef Riekenberg <wine.dev(a)web.de> 2008-05-23 04:12:18 --- *** Bug 13356 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 Detlef Riekenberg <wine.dev(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|window too small in the |window too small in the |vc2008 redist installer |"vc2008 redist installer" | |and "Firefox 3" [dogfoot] --- Comment #6 from Detlef Riekenberg <wine.dev(a)web.de> 2008-05-23 04:25:43 --- (From 13356) Screenshoot for Firefox 3 rc1: http://bugs.winehq.org/attachment.cgi?id=13253 Wine version was git from 22.05.2008 Affected Application from 12511 was Firefox 3 beta 4 (No screenshoot available) Wine version was git from 11.04.2008 -- By by ... Detlef -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|window too small in the |window too small in the |"vc2008 redist installer" |"vc2008 redist installer" |and "Firefox 3" [dogfoot] |and "Firefox 3" [dogfood] -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 Steve Dougherty <asksteved.com(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |asksteved.com(a)gmail.com --- Comment #7 from Steve Dougherty <asksteved.com(a)gmail.com> 2008-05-28 16:52:35 --- Confirming. The Firefox 3 RC1 default browser nag window is misized for me as well. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 --- Comment #8 from Steve Dougherty <asksteved.com(a)gmail.com> 2008-05-28 17:03:16 --- Created an attachment (id=13444) --> (http://bugs.winehq.org/attachment.cgi?id=13444) Another mis-sized Firefox window This is another small Firefox 3 (RC 1) window. It looks like all mis-sized windows are off by the same amount. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 --- Comment #9 from Reece Dunn <msclrhd(a)gmail.com> 2008-05-28 17:20:49 --- Not sure on the validity of this, but looking at the screenshots, it looks as if the dialogs are off by the height of the title bar. Therefore, my guess would be that there is an issue in the AdjustWindowRect API. Does anyone know if this is reproduced when Wine manages the window frames (either directly or in a virtual desktop)? Also, Firefox looks like a good candidate for diagnosing this issue, provided someone knows what the XUL engine is doing in this case. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 kingsamses(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kingsamses(a)gmail.com --- Comment #10 from kingsamses(a)gmail.com 2008-05-31 20:41:36 --- This bug occurs with Fx RC 1 in wine-rc1 with allow window manager to decorate and to manaage windows both unchecked in winecfg, and also in an emulated virtual desktop. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 Detlef Riekenberg <wine.dev(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pikmaster(a)wp.pl --- Comment #11 from Detlef Riekenberg <wine.dev(a)web.de> 2008-06-24 10:39:35 --- *** Bug 14061 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 Detlef Riekenberg <wine.dev(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|window too small in the |window size is too small in |"vc2008 redist installer" |the "vc2008 redist |and "Firefox 3" [dogfood] |installer" and "Firefox 3" | |[dogfood] -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 Andre Wisplinghoff <andre.wisplinghoff(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andre.wisplinghoff(a)gmail.com --- Comment #12 from Andre Wisplinghoff <andre.wisplinghoff(a)gmail.com> 2008-07-11 15:55:30 --- It's still the same with current git wine and Fx 3 Final. Also try goin fullscreen and back 2 times (press F11 4 times). For me, the Fx Window height is one title bar too big afterwards. The Window has some "negative top", you can move it down with ALT+Left Mouse and see that the title bar is actually there and was just invisible. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 --- Comment #13 from Andre Wisplinghoff <andre.wisplinghoff(a)gmail.com> 2008-07-11 16:58:43 --- I can't tell you why, but this helps here: --- a/dlls/user32/nonclient.c +++ b/dlls/user32/nonclient.c @@ -111,8 +111,8 @@ NC_AdjustRectOuter (LPRECT rect, DWORD style, BOOL menu, DWORD exStyle) { if (exStyle & WS_EX_TOOLWINDOW) rect->top -= GetSystemMetrics(SM_CYSMCAPTION); - else - rect->top -= GetSystemMetrics(SM_CYCAPTION); + // else + // rect->top -= GetSystemMetrics(SM_CYCAPTION); } if (menu) rect->top -= GetSystemMetrics(SM_CYMENU); } The fullscreen issue I mentioned in the last comment persists with this, though, so I think it is another bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 --- Comment #14 from Reece Dunn <msclrhd(a)gmail.com> 2008-07-12 02:55:51 --- (In reply to comment #13)
I can't tell you why, but this helps here:
So the issue is fixed when not adjusting the top of the rect by SM_CYCAPTION, or is there more? #> --- a/dlls/user32/nonclient.c
+++ b/dlls/user32/nonclient.c @@ -111,8 +111,8 @@ NC_AdjustRectOuter (LPRECT rect, DWORD style, BOOL menu, DWORD exStyle) { if (exStyle & WS_EX_TOOLWINDOW) rect->top -= GetSystemMetrics(SM_CYSMCAPTION); - else - rect->top -= GetSystemMetrics(SM_CYCAPTION); + // else + // rect->top -= GetSystemMetrics(SM_CYCAPTION); } if (menu) rect->top -= GetSystemMetrics(SM_CYMENU); }
We should be able to use this information to write a test to verify that the outer rect is not being decreased by SM_CYCAPTION on Windows.
The fullscreen issue I mentioned in the last comment persists with this, though, so I think it is another bug.
Sure. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 --- Comment #15 from Andre Wisplinghoff <andre.wisplinghoff(a)gmail.com> 2008-07-12 04:38:45 --- Created an attachment (id=14747) --> (http://bugs.winehq.org/attachment.cgi?id=14747) Wine with fix/hack in comparison to win2k posted earlier Yeah, the two uncommented lines were the only change I made. The two windows in firefox are now shown correctly, in the vc installer the buttons are also visible now. The attachment shows a fixed wine running vc installer vs one executed in win2k posted earlier. You can see that there is not as much space in wine at the bottom as there is in windows. I don't know if this is okay, wine takes up the same total height for the window as windows does, but in Wine, the title bar is larger in my setup, so there is not as much space for the content as in windows. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 --- Comment #16 from Andre Wisplinghoff <andre.wisplinghoff(a)gmail.com> 2008-07-12 15:25:17 --- I wrote a conformance test for this and it turns out that windows does the same as wine at the moment - it takes SM_CYCAPTION into account. Seems commenting out these lines just helped accidently. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 --- Comment #17 from Lei Zhang <thestig(a)google.com> 2008-07-15 17:42:25 --- Please give my patches a try: http://www.winehq.org/pipermail/wine-patches/2008-July/057868.html http://www.winehq.org/pipermail/wine-patches/2008-July/057870.html They seem to fix the firefox 3 about->credit dialog for me. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 --- Comment #18 from Andre Wisplinghoff <andre.wisplinghoff(a)gmail.com> 2008-07-16 19:29:49 --- Great work. Fixes all problems here - Fx default browser-, info- and multi-tab closing dialog, vcredist is also happy. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 Lei Zhang <thestig(a)google.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #19 from Lei Zhang <thestig(a)google.com> 2008-07-17 10:18:33 --- Patches committed. Marking this fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.0.1 --- Comment #20 from Alexandre Julliard <julliard(a)winehq.org> 2008-07-25 10:21:27 --- Nominating for 1.0.1. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11936 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #21 from Alexandre Julliard <julliard(a)winehq.org> 2008-07-25 12:59:12 --- Closing bugs fixed in 1.1.2. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=11936 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |focht(a)gmx.net Fixed by SHA1| |b3f4091b47e70681a9909bfccd1 | |9dee95657fabd URL|http://download.microsoft.c |https://web.archive.org/web |om/download/1/1/1/1116b75a- |/20121108124954/http://down |9ec3-481a-a3c8-1777b5381140 |load.microsoft.com/download |/vcredist_x86.exe |/1/1/1/1116b75a-9ec3-481a-a | |3c8-1777b5381140/vcredist_x | |86.exe Component|-unknown |user32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla