[Bug 59301] New: winehq wine 11.1 winemenubuilder.exe has encountered a serious problem

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=59301

            Bug ID: 59301
           Summary: winehq wine 11.1 winemenubuilder.exe has encountered a
                    serious problem
           Product: Wine
           Version: 11.1
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Debian

Created attachment 80240
  --> http://bugs.winehq.org/attachment.cgi?id=80240
winemenubuilder error log

Starting from update to 11.1 .
Open app and error window pops up as per title.
App then runs as normal.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 59301] winehq wine 11.1 winemenubuilder.exe has encountered a serious problem

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=59301

Austin English <[e-mail]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |programs

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 59301] winehq wine 11.1 winemenubuilder.exe has encountered a serious problem

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=59301

Bernhard Übelacker <[e-mail]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                URL|                            |https://www.photofiltre-stu
                   |                            |dio.com/utils/pfsx-setup-en
                   |                            |-10.14.2.exe
           Keywords|                            |download, source

--- Comment #1 from Bernhard Übelacker <[e-mail]> ---
I tried to collect some more information.
This I assume is the application:
https://www.photofiltre-studio.com/download-en.htm
https://www.photofiltre-studio.com/utils/pfsx-setup-en-10.14.2.exe

(Adding keyword source, because crash is inside winemenubuilder.)


I could reproduce the winemenubuilder inside a minimal VM, when
pretending to be on a XDG desktop and starting some unrelated application.

XDG_CURRENT_DESKTOP=KDE WINEDEBUG=+pid,+icon,+menubuilder wine winemine


It looks like the application creates file associations for PFI, PFS and PFV:
  HKCR\PhotoFiltre.Pfi\DefaultIcon
  (Default)="C:\\Program Files (x86)\\PhotoFiltre Studio X\\pfstudiox.exe,1"

Unfortunately this makes winemenubuilder to access some resources, which
do not look like a icon resource.
  grpIconDir->idReserved=13665
  grpIconDir->idType=30684
  grpIconDir->idCount=32102

I will attach a file with more details.


Wondering if notepad's OpenFile dialog shouldn't also show such icons
I simply created empty files with this endings, but it did not show other
icons.
Instead it prints: warn:icon:ICO_ExtractIconExW icon entry 0 not found

By comparing it with how the OpenFile dialog in e.g. notepad accesses it
I came up with attached patch, which adds a check:
                if (pIconDir->idReserved == 0 && pIconDir->idType == 1)


But I am unsure if that blocks also other legitimate resource types.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 59301] winehq wine 11.1 winemenubuilder.exe has encountered a serious problem

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=59301

--- Comment #2 from Bernhard Übelacker <[e-mail]> ---
Created attachment 80265
  --> http://bugs.winehq.org/attachment.cgi?id=80265
details

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 59301] winehq wine 11.1 winemenubuilder.exe has encountered a serious problem

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=59301

--- Comment #3 from Bernhard Übelacker <[e-mail]> ---
Created attachment 80266
  --> http://bugs.winehq.org/attachment.cgi?id=80266
59301_winemenubuilder-avoid-crash.patch

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 59301] winehq wine 11.1 winemenubuilder.exe has encountered a serious problem

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=59301

--- Comment #4 from [e-mail] ---
Thank you. I think I understand what is happening here now. I need to look
closer at the other machine I have running winehq-stable with a slightly
different way of running PFX as that one doesn't generate the error message.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.