[Bug 57072] New: Window is flashing when painting transluent effects
https://bugs.winehq.org/show_bug.cgi?id=57072 Bug ID: 57072 Summary: Window is flashing when painting transluent effects Product: Wine Version: 9.15 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: dmitry(a)baikal.ru CC: z.figura12(a)gmail.com Regression SHA1: 46c8a637525d0f1cf67830295fb460c819b800b6 Distribution: --- An application that I have here draws transluent effects when mouse moves over some of its text items and that leads to huge flashing. It looks like top level window is constantly recreated. This is a regression caused by commit 46c8a637525d0f1cf67830295fb460c819b800b6 Author: Elizabeth Figura <zfigura(a)codeweavers.com> Date: Fri Jan 20 16:23:42 2023 -0600 winex11: Separately store the internal pixel format set by WGL_WINE_pixel_format_passthrough. Reverting just single line of this commit @@ -1402,12 +1402,12 @@ static BOOL set_win_format( HWND hwnd, const struct wgl_ pixel_format *format, BO XFlush( gdi_display ); release_gl_drawable( gl ); - win32u_set_window_pixel_format( hwnd, pixel_format_index( format ), FALSE ) ; + win32u_set_window_pixel_format( hwnd, pixel_format_index( format ), interna l ); completely fixes the problem. Could that be an inadvertent change or oversight? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57072 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57072 --- Comment #1 from Zeb Figura <z.figura12(a)gmail.com> --- No, that's pretty much the point of the change. Specifically, as described in <https://gitlab.winehq.org/wine/wine/-/merge_requests/2217>, we want wined3d to be able to set the "internal" pixel format while still knowing whether the application has set the "public" pixel format. I can try to debug from a +gdi,+wgl,+d3d,+ddraw,+d3d8,+d3d9,+d3d11 log, although without access to the application I'm not sure I'll be able to figure out what's wrong. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57072 --- Comment #2 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Zeb Figura from comment #1)
No, that's pretty much the point of the change. Specifically, as described in <https://gitlab.winehq.org/wine/wine/-/merge_requests/2217>, we want wined3d to be able to set the "internal" pixel format while still knowing whether the application has set the "public" pixel format.
I can try to debug from a +gdi,+wgl,+d3d,+ddraw,+d3d8,+d3d9,+d3d11 log, although without access to the application I'm not sure I'll be able to figure out what's wrong.
I could privately provide an archive with the application and instructions how to setup a prefix. Just let me know how to share it with you. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57072 --- Comment #3 from Zeb Figura <z.figura12(a)gmail.com> --- (In reply to Dmitry Timoshkov from comment #2)
(In reply to Zeb Figura from comment #1)
No, that's pretty much the point of the change. Specifically, as described in <https://gitlab.winehq.org/wine/wine/-/merge_requests/2217>, we want wined3d to be able to set the "internal" pixel format while still knowing whether the application has set the "public" pixel format.
I can try to debug from a +gdi,+wgl,+d3d,+ddraw,+d3d8,+d3d9,+d3d11 log, although without access to the application I'm not sure I'll be able to figure out what's wrong.
I could privately provide an archive with the application and instructions how to setup a prefix. Just let me know how to share it with you.
Sure, if email works for you please go ahead and send me one. Alternatively I can at least give the log a try first. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57072 --- Comment #4 from Zeb Figura <z.figura12(a)gmail.com> --- The application is constantly rendering to two different swapchains on two different windows. wined3d keeps track of whether it has set the internal pixel format on a swapchain, but that's a per-context flag and when the context switches windows it needs to be invalidated. We should avoid redundantly setting the pixel format, or at least recreating the GL drawable when the pixel format is set redundantly. I'm not sure that explains why flickering happens though; I'd only expect it to have performance implications? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57072 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |8923eb51ea56329bfccd572b95b | |80175352d3b55 Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- After 8923eb51ea56329bfccd572b95b80175352d3b55 I can't reproduce flickering. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57072 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 9.22. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla