[Bug 36186] New: valgrind shows a potential leak in wmiutils/tests/path.c
https://bugs.winehq.org/show_bug.cgi?id=36186 Bug ID: 36186 Summary: valgrind shows a potential leak in wmiutils/tests/path.c Product: Wine Version: 1.7.17 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: wmi&wbemprox Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com ==2566== 28 bytes in 1 blocks are possibly lost in loss record 164 of 592 ==2566== at 0x7BC4C6B7: notify_alloc (heap.c:255) ==2566== by 0x7BC50EFB: RtlAllocateHeap (heap.c:1716) ==2566== by 0x4FC483E: COMPOBJ_DllList_Add (compobj.c:526) ==2566== by 0x4FC6B7A: apartment_getclassobject (compobj.c:1335) ==2566== by 0x4FCA2C4: get_inproc_class_object (compobj.c:2894) ==2566== by 0x4FCA783: CoGetClassObject (compobj.c:3032) ==2566== by 0x4FCAD45: CoCreateInstance (compobj.c:3197) ==2566== by 0x4E78E44: create_path (path.c:81) ==2566== by 0x4E78E9E: test_IWbemPath_SetText (path.c:132) ==2566== by 0x4E7F004: func_path (path.c:869) ==2566== by 0x4E7FE31: run_test (test.h:584) ==2566== by 0x4E8021F: main (test.h:654) ==2566== follow up to bug 36161 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36186 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |valgrind -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36186 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- I think this simply means that object dll is not unloaded immediately after last object got released. If I'm not mistaken we have similar warnings all over. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=36186 --- Comment #2 from Ken Sharp <imwellcushtymelike@gmail.com> --- Valgrind is happy with the latest git. So do we mark this as fixed? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=36186 --- Comment #3 from Hans Leidekker <hans@meelstraat.net> --- (In reply to Ken Sharp from comment #2)
Valgrind is happy with the latest git. So do we mark this as fixed?
If Nikolay was right then this should still be there. What output do you get? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=36186 --- Comment #4 from Nikolay Sivov <bunglehead@gmail.com> --- I'm not sure you can even easily get valgrind to work in latest git. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=36186 --- Comment #5 from Ken Sharp <imwellcushtymelike@gmail.com> --- Created attachment 81906 --> http://bugs.winehq.org/attachment.cgi?id=81906 valgrind make test Attached. Am I running it wrong? Does it need to be run as the entire test suite? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=36186 --- Comment #6 from Hans Leidekker <hans@meelstraat.net> --- (In reply to Nikolay Sivov from comment #4)
I'm not sure you can even easily get valgrind to work in latest git.
We should perhaps consider abandoning valgrind bugs. Many developers will have switched to PE builds by now and they may not bother doing a non-PE build just to check these valgrind bugs, even if it works. And we have working ASan reports now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=36186 --- Comment #7 from Austin English <austinenglish@gmail.com> --- (In reply to Hans Leidekker from comment #6)
(In reply to Nikolay Sivov from comment #4)
I'm not sure you can even easily get valgrind to work in latest git.
We should perhaps consider abandoning valgrind bugs. Many developers will have switched to PE builds by now and they may not bother doing a non-PE build just to check these valgrind bugs, even if it works. And we have working ASan reports now.
I've been thinking the same recently; it hasn't been useful in some time. It will be a bit of noise, there are 239 bugs with valgrind keyword (many, but not all, are mine). And some are for better valgrind compatibility, which may or may not still be valid.. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=36186 --- Comment #8 from Nikolay Sivov <bunglehead@gmail.com> --- I closed some for msxml* already, that were hard to verify both because of valgrind and significant code changes. But yes, integrating ASan into CI seems more valuable at this point. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla