[Bug 31145] New: WinDirStat right clicking on a directory and selecting properties says "invalid parameter"
http://bugs.winehq.org/show_bug.cgi?id=31145 Bug #: 31145 Summary: WinDirStat right clicking on a directory and selecting properties says "invalid parameter" Product: Wine Version: 1.5.8 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: computergeoffrey(a)zoho.com Classification: Unclassified After analysis of a directory, right clicking on a directory (doesn't matter which, as long it's in the "scope" of the analysis) and selecting properties shows the error message "invalid parameter". -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31145 Geoffrey <computergeoffrey(a)zoho.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |computergeoffrey(a)zoho.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31145 --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2012-07-06 12:01:22 CDT --- Please attach terminal output. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31145 --- Comment #2 from Geoffrey <computergeoffrey(a)zoho.com> 2012-07-06 12:20:08 CDT --- Created attachment 40894 --> http://bugs.winehq.org/attachment.cgi?id=40894 Only last line is important I think -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31145 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40894|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31145 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Status|UNCONFIRMED |NEW URL| |http://windirstat.info/ CC| |00cpxxx(a)gmail.com Ever Confirmed|0 |1 --- Comment #3 from Bruno Jesus <00cpxxx(a)gmail.com> 2012-07-06 19:16:06 CDT --- Wine does not support showing directory properties (am I correct?). That message is not from the program, is from wine itself: http://source.winehq.org/source/dlls/shell32/shlexec.c#L1927 1927 if (retval <= 32 && !(sei_tmp.fMask & SEE_MASK_FLAG_NO_UI)) 1928 do_error_dialog(retval, sei_tmp.hwnd); WINEDEBUG=+exec shows this: ... trace:exec:SHELL_FindExecutable L"" trace:exec:SHELL_FindExecutable found L"" via App Paths trace:exec:SHELL_quote_and_execute L""/L"properties" => L"\"\""/L"" trace:exec:SHELL_ExecuteW Execute L"\"\"" from directory L"" trace:exec:SHELL_ExecuteW CreateProcess returned error 87 trace:exec:SHELL_ExecuteW returning 11 trace:exec:SHELL_execute retval 11 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31145 --- Comment #4 from Bruno Jesus <00cpxxx(a)gmail.com> 2012-07-06 20:14:55 CDT --- Created attachment 40900 --> http://bugs.winehq.org/attachment.cgi?id=40900 hack The attached patch is a hack that will make it open the explorer instead of showing an error. The application sets the SEE_MASK_IDLIST but does not set a list in lpIDList so wine clears the lpFile variable in SHGetPathFromIDListW and then there is the exec fail. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31145 --- Comment #5 from Geoffrey <computergeoffrey(a)zoho.com> 2012-07-08 13:03:32 CDT --- (In reply to comment #4)
Created attachment 40900 [details] hack
The attached patch is a hack that will make it open the explorer instead of showing an error.
The application sets the SEE_MASK_IDLIST but does not set a list in lpIDList so wine clears the lpFile variable in SHGetPathFromIDListW and then there is the exec fail.
Is this a desired behaviour? And isn't it possible to implement properties of a directory / file? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31145 --- Comment #6 from Bruno Jesus <00cpxxx(a)gmail.com> 2012-07-08 13:39:08 CDT --- (In reply to comment #5)
Is this a desired behaviour? And isn't it possible to implement properties of a directory / file?
The patch is simply intended to show where the problem may be. I don't have the knowledge to fix this bug (by creating the properties page), we will have to wait for someone more experienced to work in it. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31145 --- Comment #7 from Geoffrey <computergeoffrey(a)zoho.com> 2012-07-09 08:54:18 CDT --- Okay, thanks for your effort :) At least it's better than nothing. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Abandoned? --- Comment #8 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Is this still an issue in Wine 1.7.45 or later? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 --- Comment #9 from Geoffrey De Belie <computergeoffrey(a)zoho.com> --- (In reply to Ken Sharp from comment #8)
Is this still an issue in Wine 1.7.45 or later?
Yes. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 Geoffrey De Belie <computergeoffrey(a)zoho.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Abandoned? | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #10 from super_man(a)post.com --- It's still an issue I tried to dig into this too. trace:exec:SHELL_ExecuteW CreateProcess returned error 87 I used that as starting to point where to search a bug. wine 1.7.50 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 Jeff D. Hanson <jhansonxi(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jhansonxi(a)gmail.com --- Comment #11 from Jeff D. Hanson <jhansonxi(a)gmail.com> --- The hack/patch failed to apply to current Wine 1.9 git (HEAD d7e4193). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 --- Comment #12 from super_man(a)post.com --- I thought Muller's patch could help here, but it clearly fixes another area of wine. Still valid 1.9.7. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #13 from winetest(a)luukku.com --- Still valid 1.9.21-git. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 exposight <exposight(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |exposight(a)gmail.com --- Comment #14 from exposight <exposight(a)gmail.com> --- still the case in wine 4.18 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |damjan.jov(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 Damjan Jovanovic <damjan.jov(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source --- Comment #15 from Damjan Jovanovic <damjan.jov(a)gmail.com> --- It's a dogfood bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 --- Comment #16 from Damjan Jovanovic <damjan.jov(a)gmail.com> --- A +shell trace isn't very revealing, but we can use the fact that the MessageBox is modal, making the stack trace to it visible. "bt all" in winedbg gives us: ---snip--- 9 0x6ed6c3cf MessageBoxW+0x5e(text=<couldn't compute location>, title=<couldn't compute location>, type=<couldn't compute location>) [Z:\Wine\wine\dlls\user32\msgbox.c:441] in user32 (0x0021d118) 10 0x6354314a in shell32 (+0x83149) (0x0021e158) 11 0x63544343 in shell32 (+0x84342) (0x0021f938) 12 0x6354468b in shell32 (+0x8468a) (0x0021f958) 13 0x00406a4e EntryPoint+0xffffffff() in windirstat (0x0021f9dc) ---snip--- So the MessageBox is called from somewhere in shell32. A grep through there, and eliminates the places that place a hardcoded string as the message, leaves us with few candidates. Hacking the remaining places to log a FIXME before each MessageBox, we find it's called from: do_error_dialog() which is called in the "out:" part of SHELL_execute() It looks like some kind of bug in SHELL_execute(), in handling the variation of parameters passed by WinDirStat. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 Bernhard Übelacker <bernhardu(a)mailbox.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernhardu(a)mailbox.org --- Comment #17 from Bernhard Übelacker <bernhardu(a)mailbox.org> --- Created attachment 71558 --> https://bugs.winehq.org/attachment.cgi?id=71558 trace with +exec and some more backtraces Still valid with wine-7.0-rc4. ShellExecuteEx gets called with not yet supported SEE_MASK_INVOKEIDLIST. And with null sei.lpIDList, thefore sei.lpFile gets initialized in SHGetPathFromIDList, therefore the path lost. The workaround from Bruno is still valid. (Manually applied.) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=31145 --- Comment #18 from Austin English <austinenglish(a)gmail.com> --- Still present in 9.0. 6fa92dd2ca691c11dfbfc0a239e34369897a7fab windirstat1_1_2_setup.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31145 KRosUser <kyle.kcsoftwares@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.kcsoftwares@gmail.com --- Comment #19 from KRosUser <kyle.kcsoftwares@gmail.com> --- Wine 11.7 : Invalid descriptor -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (3)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla
-
WineHQ Bugzilla