[Bug 46823] New: in wcmd.exe, trailing slash in "if exist SomeDir/" cause always false

https://bugs.winehq.org/show_bug.cgi?id=46823

            Bug ID: 46823
           Summary: in wcmd.exe, trailing slash in "if exist SomeDir/"
                    cause always false
           Product: Wine
           Version: 4.3
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: cmd
          Assignee: wine-bugs(a)winehq.org
          Reporter: alter(a)ukr.net
      Distribution: ---

Created attachment 63849
  --> https://bugs.winehq.org/attachment.cgi?id=63849
fix issue with instant false due to trailing slash in 'if exist SomeDir/'

if exist SomeDir/ do-smth.cmd
statement (with ending slash) always return false since
'if exist' CMD implementation start using FindFirstFileW() instead of
GetFileAttributesW() in builtins.c
Such condition appears in MS VisualStudio generated makefiles
There is special case for trailing '\\', but there is no handling for '/'.
The patch proposed fixes this issue and adds corresponding tests for
if exist SomeDir/ do-smth.cmd
if exist "SomeDir/" do-smth.cmd
cases

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 46823] in wcmd.exe, trailing slash in "if exist SomeDir/" cause always false

https://bugs.winehq.org/show_bug.cgi?id=46823

Mikhail <mikhail.v.gavrilov(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikhail.v.gavrilov(a)gmail.co
                   |                            |m

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 46823] in wcmd.exe, trailing slash in "if exist SomeDir/" cause always false

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46823

François Gouget <fgouget(a)codeweavers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fgouget(a)codeweavers.com
           Keywords|                            |patch, source, testcase

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 46823] in wcmd.exe, trailing slash in "if exist SomeDir/" cause always false

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=46823

Eric Pouech <eric.pouech(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.pouech(a)gmail.com
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |5e2f9996baedbe389df93255a4d
                   |                            |d1188cbdb6c56

--- Comment #1 from Eric Pouech <eric.pouech(a)gmail.com> ---
fixed by 5e2f9996baedbe389df93255a4dd1188cbdb6c56

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 46823] in wcmd.exe, trailing slash in "if exist SomeDir/" cause always false

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=46823

Alexandre Julliard <julliard(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard <julliard(a)winehq.org> ---
Closing bugs fixed in 10.17.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.