[Bug 12425] New: win16 test suite: user32 comm16 test fails
http://bugs.winehq.org/show_bug.cgi?id=12425 Summary: win16 test suite: user32 comm16 test fails Product: Wine Version: CVS/GIT Platform: Other URL: http://win16test.googlecode.com OS/Version: other Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: user32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: austinenglish(a)gmail.com Created an attachment (id=11964) --> (http://bugs.winehq.org/attachment.cgi?id=11964) Backtrace +++ This bug was initially created as a clone of Bug #9850 +++ The code can be downloaded from http://win16test.googlecode.com with svn, and is quite easy to run; see http://win16test.googlecode.com/svn/trunk/src/README for instructions. The kernel comm test hangs in current git. Attached is the backtrace in current git. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12425 --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2008-04-08 01:46:16 --- (In reply to comment #0)
Created an attachment (id=11964) --> (http://bugs.winehq.org/attachment.cgi?id=11964) [details] Backtrace
+++ This bug was initially created as a clone of Bug #9850 +++ The code can be downloaded from http://win16test.googlecode.com with svn, and is quite easy to run; see http://win16test.googlecode.com/svn/trunk/src/README for instructions.
The kernel comm test hangs in current git. Attached is the backtrace in current git.
Should be user, not kernel... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12425 --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2008-08-11 23:56:59 --- Still present in git. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12425 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified --- Comment #3 from Austin English <austinenglish(a)gmail.com> 2009-01-19 15:14:56 --- Removing deprecated CVS/GIT version tag. Please retest in current git. If the bug is still present in today's wine, but was not present in some earlier version of wine, please update version field to earliest known version of wine that had the bug. Thanks! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12425 Niko Sandschneider <nsandschn(a)gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nsandschn(a)gmx.de --- Comment #4 from Niko Sandschneider <nsandschn(a)gmx.de> 2009-08-03 11:45:59 --- Still present in wine 1.1.26. The install_openwatcom script mentioned in the README file is broken, by the way. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12425 --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2009-08-03 11:55:23 --- (In reply to comment #4)
Still present in wine 1.1.26. The install_openwatcom script mentioned in the README file is broken, by the way.
I didn't write this stuff originally, but I'll take a look. I suppose this could be automated better into appinstall...hmm. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12425 --- Comment #6 from Niko Sandschneider <nsandschn(a)gmx.de> 2009-08-03 12:16:34 --- There are just some minor issues with the script. The following changes will make it work: - WINETRICKS_CACHE=$HOME/winetrickscache + WINETRICKS_CACHE=$HOME/.winetrickscache - download "http://ftp.openwatcom.org/ftp/open-watcom-c-win32-1.7.exe" + download "http://ftp.openwatcom.org/ftp/open-watcom-c-win32-1.8.exe" - try cp $WINETRICKS_CACHE/open-watcom-c-win32-1.7.exe ~/.wine/drive_c/Program\ Files/ + try cp $WINETRICKS_CACHE/open-watcom-c-win32-1.8.exe ~/.wine/drive_c/Program\ Files/ The openwatcom version in the install_openwatcom.ahk file has to be replaced by 1.8, too. Then everything works fine. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12425 --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2009-08-03 13:47:59 --- (In reply to comment #6)
There are just some minor issues with the script. The following changes will make it work:
- WINETRICKS_CACHE=$HOME/winetrickscache + WINETRICKS_CACHE=$HOME/.winetrickscache
- download "http://ftp.openwatcom.org/ftp/open-watcom-c-win32-1.7.exe" + download "http://ftp.openwatcom.org/ftp/open-watcom-c-win32-1.8.exe"
- try cp $WINETRICKS_CACHE/open-watcom-c-win32-1.7.exe ~/.wine/drive_c/Program\ Files/ + try cp $WINETRICKS_CACHE/open-watcom-c-win32-1.8.exe ~/.wine/drive_c/Program\ Files/
The openwatcom version in the install_openwatcom.ahk file has to be replaced by 1.8, too. Then everything works fine.
Ah, broken links...gotcha. I'll fix it later this evening. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12425 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dank(a)kegel.com Summary|win16 test suite: user32 |win16 test suite: user32 |comm16 test fails |comm16 test crashes/hangs --- Comment #8 from Dan Kegel <dank(a)kegel.com> 2009-08-18 00:18:22 --- The script looks fixed now, and winetricks openwatcom works (but don't use -q, and do select a full install). Changing description to mention that it's a crash. Still happening with 1.1.27. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12425 Xavier Vachon <xvachon(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xvachon(a)gmail.com --- Comment #9 from Xavier Vachon <xvachon(a)gmail.com> 2010-10-27 14:43:54 CDT --- I attempted to compile the tests today, and it fails. Openwatcom was installed through winetricks as a full install. xavier(a)environnement ~/Downloads/win16-tests1 $ make all wine wcc -D_X86_ -DSTANDALONE '-i=C:\WATCOM\h\win;C:\WATCOM\h'-zW -e25 -zq -od -d2 -w4 -wcd=126 -wcd=102 -wcd=112 -bw-bt=windows alloc.c alloc.c(83): Error! E1010: Type mismatch alloc.c(83): Error! E1151: Parameter count does not agree with previous definition alloc.c(83): Note! N2002: 'winetest_ok' defined in: test.h(271) alloc.c(105): Error! E1010: Type mismatch alloc.c(113): Error! E1010: Type mismatch alloc.c(113): Error! E1151: Parameter count does not agree with previous definition alloc.c(113): Note! N2002: 'winetest_ok' defined in: test.h(271) alloc.c(116): Error! E1010: Type mismatch alloc.c(116): Error! E1151: Parameter count does not agree with previous definition alloc.c(116): Note! N2002: 'winetest_ok' defined in: test.h(271) alloc.c(118): Error! E1010: Type mismatch alloc.c(118): Error! E1151: Parameter count does not agree with previous definition alloc.c(118): Note! N2002: 'winetest_ok' defined in: test.h(271) alloc.c(133): Error! E1010: Type mismatch alloc.c(141): Error! E1010: Type mismatch alloc.c(164): Error! E1010: Type mismatch alloc.c(168): Error! E1010: Type mismatch alloc.c(173): Error! E1010: Type mismatch alloc.c(195): Error! E1010: Type mismatch alloc.c(195): Error! E1151: Parameter count does not agree with previous definition alloc.c(195): Note! N2002: 'winetest_ok' defined in: test.h(271) alloc.c(202): Error! E1010: Type mismatch alloc.c(202): Error! E1151: Parameter count does not agree with previous definition alloc.c(202): Note! N2002: 'winetest_ok' defined in: test.h(271) alloc.c(205): Error! E1010: Type mismatch alloc.c(205): Error! E1151: Parameter count does not agree with previous definition alloc.c(205): Note! N2002: 'winetest_ok' defined in: test.h(271) alloc.c(207): Error! E1010: Type mismatch alloc.c(207): Error! E1151: Parameter count does not agree with previous definition alloc.c(207): Note! N2002: 'winetest_ok' defined in: test.h(271) make: *** [alloc.obj] Error 8 Any clue why? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12425 butraxz(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |butraxz(a)gmail.com --- Comment #10 from butraxz(a)gmail.com 2013-04-22 14:45:45 CDT --- This bug has not been touched for over 900 days. Is this still relevant ? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=12425 Vijay Kamuju <infyquest(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |infyquest(a)gmail.com --- Comment #11 from Vijay Kamuju <infyquest(a)gmail.com> --- win16 testsuite is unavailable, can we close this ticket -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=12425 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://win16test.googlecode |https://github.com/austin98 |.com |7/win16test/ --- Comment #12 from Dan Kegel <dank(a)kegel.com> --- Updated URL to Austin's export. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12425 --- Comment #13 from Janne <janne.kekkonen@gmail.com> --- Hello, I tested this with Wine 11.14 on a clean 32-bit prefix configured as Windows 2000. The Win16 test suite was compiled with OpenWatcom 2.0. The Makefile was modified from this: CFLAGS =-D_X86_ -DSTANDALONE '-i=C:\WATCOM\h\win;C:\WATCOM\h'-zW -e25 -zq -od -d2 -w4 -wcd=126 -wcd=102 -wcd=112 -bw-bt=windows to this: CFLAGS =-D_X86_ -DSTANDALONE -DNULL=0 '-i=C:\WATCOM\h\win;C:\WATCOM\h' -zW -e25 -zq -od -d2 -w4 -wcd=126 -wcd=102 -wcd=112 -bw-bt=windows Building with the modified Makefile was successful. comm16.exe was started with this command: WINETEST_PLATFORM=wine wine comm16.exe --log && ! grep ' [0-9]*[1-9] failures' *.log && touch comm16.ok A crash occurred with this line at the top of the backtrace: =>0 0x77873664 BuildCommDCB16+0x54(device="COM1:2400,n,8,1", lpdcb=00000000) [/usr/src/packages/BUILD/dlls/user.exe16/comm.c:427] in user.exe16 (0x0123fb68) The backtrace and source code show that lpDCB was/is NULL: https://github.com/austin987/win16test/blob/master/src/comm16.c#L63 In Wine, there is no check for lpDCB being NULL before calling memset: https://gitlab.winehq.org/wine/wine/-/blob/wine-11.15/dlls/user.exe16/comm.c... Would adding a check before memset resolve this? For example: if (lpdcb == NULL) { return -1; } -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12425 --- Comment #14 from Janne <janne.kekkonen@gmail.com> --- Created attachment 81841 --> http://bugs.winehq.org/attachment.cgi?id=81841 patch for BuildComm16 Hello, patch attached for BuildCommDCB16 which prevents crash. Tested with Wine11.15 in 32-bit prefix configured as Windows 2000. comm16 test suite gave these failures: comm16.c:93: Test failed: DCB only device: failed comm16.c:113: Test failed: DCB only device:baudrate failed comm16.c:127: Test failed: DCB only device baudrate failed comm16.c:147: Test failed: DCB only device: baudrate failed comm16.c:199: Test failed: DCB space #1 in parameter failed comm16.c:216: Test failed: DCB space #2 in parameter failed comm16.c:244: Test failed: DCB trailing spaces failed comm16.c:266: Test failed: DCB trailing garbage #3 failed comm16: 26 tests executed (0 marked as todo, 8 failures), 0 skipped, status 8.
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla