[Bug 49894] New: Regression in "kernelbase: Use conhost to handle Unix consoles."
https://bugs.winehq.org/show_bug.cgi?id=49894 Bug ID: 49894 Summary: Regression in "kernelbase: Use conhost to handle Unix consoles." Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: kernel32 Assignee: wine-bugs(a)winehq.org Reporter: martin(a)martin.st Distribution: --- Since 54e117018cd4cc58c258da92686bfad13946bde2, "kernelbase: Use conhost to handle Unix consoles.", the wine console misbehaves, when run within an existing unix terminal (in my case, ssh from a mac Terminal.app/bash shell to a linux host, running wine on linux within that ssh session) - i.e. when running "wine64 cmd" to get an interactive shell. On aarch64 on Debian 8, the effect is that typing individual chars do work, but when pressing enter, I get a ^M printed instead of executing the individual line. On x86_64 on Ubuntu 20.04, I get "wine: Unhandled page fault on write access to 00007F424DD5B2E0 at address 000000006EB8D3F0 (thread 0104), starting debugger..." directly when I type a single character. I.e., the testcase is to just run "wine64 cmd", then try to type "exit<enter>" to exit it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49894 Martin Storsjö <martin(a)martin.st> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacek(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49894 --- Comment #1 from Jacek Caban <jacek(a)codeweavers.com> --- Could you please attach console,conhost,server,seh logs? It works fine for me, so I can't reproduce. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49894 --- Comment #2 from Martin Storsjö <martin(a)martin.st> --- (In reply to Jacek Caban from comment #1)
Could you please attach console,conhost,server,seh logs? It works fine for me, so I can't reproduce.
Is it possible to redirect them to a file, without redirecting stdout/stderr of the process (which quite possibly affects how it behaves as a console pretty significantly)? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49894 --- Comment #3 from Martin Storsjö <martin(a)martin.st> --- Does configuring with "--without-x --without-freetype" help with reproducing it - as that's the configuration I'm using? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49894 --- Comment #4 from Jacek Caban <jacek(a)codeweavers.com> --- Created attachment 68250 --> https://bugs.winehq.org/attachment.cgi?id=68250 patch It's possible to redirect only stderr. This is enough for logs, while cmd will use stdout. I can reproduce the problem with enter by setting an invalid DISPLAY. The problem of pressing enter is that we use VkKeyScanW in this case to find virtual key code, which fails without a display driver. The attached patch fixes that. We could consider better support for VkKeyScanW in null driver or maybe not even go through display driver in cases like \r. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49894 --- Comment #5 from Martin Storsjö <martin(a)martin.st> --- (In reply to Jacek Caban from comment #4)
Created attachment 68250 [details] patch
It's possible to redirect only stderr. This is enough for logs, while cmd will use stdout. I can reproduce the problem with enter by setting an invalid DISPLAY.
The problem of pressing enter is that we use VkKeyScanW in this case to find virtual key code, which fails without a display driver. The attached patch fixes that. We could consider better support for VkKeyScanW in null driver or maybe not even go through display driver in cases like \r.
Thanks! With this applied on current master, it seems to work in both configs. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49894 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |54e117018cd4cc58c258da92686 | |bfad13946bde2 Keywords| |download, patch, regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49894 --- Comment #6 from Jacek Caban <jacek(a)codeweavers.com> --- A better fix is in Wine, please retest: https://source.winehq.org/git/wine.git/commitdiff/14d97c261b5172f84d9d8a935f... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49894 Martin Storsjö <martin(a)martin.st> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #7 from Martin Storsjö <martin(a)martin.st> --- Indeed, I can confirm that it's fixed by the committed patch as well. Thank you! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49894 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |14d97c261b5172f84d9d8a935f7 | |f72b8a83bf7e6 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49894 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.19. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla