[Bug 59809] New: XF86VidModeSetGamma BadValue X error can terminate process

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=59809

            Bug ID: 59809
           Summary: XF86VidModeSetGamma BadValue X error can terminate
                    process
           Product: Wine
           Version: 11.10
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winex11.drv
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

XF86VidModeSetGamma may raise a BadValue X error for out-of-range gamma values.
In winex11.drv, X11DRV_XF86VM_SetGamma() calls pXF86VidModeSetGamma() without
wrapping the request in Wine's X error
    handling path.

  Other XF86VidMode requests in this area use X11DRV_expect_error() /
X11DRV_check_error(). Without the guard, the X error can escape to Xlib's
default handler and terminate the process.

  Observed issue:
  - X Error of failed request: BadValue (integer parameter out of range for
operation)
  - Major opcode: XFree86-VidModeExtension
  - Minor opcode: XF86VidModeSetGamma

  Expected behavior:
  Wine should handle the X error and return failure from the gamma call instead
of allowing the process to terminate.

  One possible fix would be to wrap pXF86VidModeSetGamma() with
X11DRV_expect_error(gdi_display, XVidModeErrorHandler, NULL), synchronize when
needed, check X11DRV_check_error(), and return FALSE on X errors.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.