[Bug 52301] New: Firefox installer shows black rectangles
https://bugs.winehq.org/show_bug.cgi?id=52301 Bug ID: 52301 Summary: Firefox installer shows black rectangles Product: Wine Version: 7.0-rc3 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: rpisl(a)seznam.cz Distribution: --- Created attachment 71455 --> https://bugs.winehq.org/attachment.cgi?id=71455 Black rectangle in Firefox installer Firefox 91 ESR 64bit installer shows black rectangles. It is just a minor issue not affecting functionality. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52301 Roman Pišl <rpisl(a)seznam.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://download-installer. | |cdn.mozilla.net/pub/firefox | |/releases/91.4.1esr/win64/e | |n-US/Firefox%20Setup%2091.4 | |.1esr.exe CC| |rpisl(a)seznam.cz Keywords| |download -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52301 --- Comment #1 from Roman Pišl <rpisl(a)seznam.cz> --- Created attachment 71456 --> https://bugs.winehq.org/attachment.cgi?id=71456 Black rectangle in Firefox installer #2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52301 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> --- It's using LoadImageW() with a full path to load some bmp files. Something goes wrong in there. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52301 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52301 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> --- Confirming. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52301 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52301 Bernhard Übelacker <bernhardu(a)mailbox.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernhardu(a)mailbox.org --- Comment #4 from Bernhard Übelacker <bernhardu(a)mailbox.org> --- The HBITMAP returned by LoadImage is set via SendMessage(STM_SETIMAGE). But a moment later the same bitmap file is opened via OleLoadPicturePath followed by some image manipulation functions, and also set via SendMessage(STM_SETIMAGE). Just as a test, if OleLoadPicturePath is modified to return failure the installer shows a picture. I think the magic happens in this NSIS script: https://github.com/mozilla/gecko-dev/blob/dfc0dea63a16b73078a46b6ae49b2a626b... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52301 --- Comment #5 from Roman Pišl <rpisl(a)seznam.cz> --- Created attachment 71522 --> https://bugs.winehq.org/attachment.cgi?id=71522 Fix This fixes it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52301 --- Comment #6 from Bernhard Übelacker <bernhardu(a)mailbox.org> --- (In reply to Roman Pišl from comment #5)
This fixes it.
Confirming, this shows the bitmap instead of the black square. But one thing I noticed is that it shows it mirrored now, the yellow part is at the bottom, the red part at the top. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52301 --- Comment #7 from Roman Pišl <rpisl(a)seznam.cz> --- (In reply to Bernhard Übelacker from comment #6)
(In reply to Roman Pišl from comment #5)
This fixes it.
Confirming, this shows the bitmap instead of the black square. But one thing I noticed is that it shows it mirrored now, the yellow part is at the bottom, the red part at the top.
Yes, it's rather a hack that avoids nsis passing lpBits==NULL into StretchDIBits. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52301 --- Comment #8 from Bernhard Übelacker <bernhardu(a)mailbox.org> --- Still visible with wine-9.0-204-gd81c4ce1ba7. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=52301 --- Comment #9 from Bernhard Übelacker <bernhardu@mailbox.org> --- 9.0.0~trixie-1 black 10.0.0~trixie-1 black 10.1~trixie-1 black wine-10.1-228-g5c7fcc13885 black wine-10.1-229-gb7ca09bd649 working (but upside-down) wine-10.2 working (but upside-down) 11.0.0~trixie-1 working (but upside-down) 11.9~trixie-1 working (but upside-down) The black rectangles got fixed with this commit: b7ca09bd6498155dd3cbcf3f6f81afd5103428f9 is the first working commit commit b7ca09bd6498155dd3cbcf3f6f81afd5103428f9 Author: Dmitry Timoshkov <dmitry@baikal.ru> Date: Thu Apr 21 14:40:58 2016 +0800 oleaut32: Make OleLoadPicture load DIBs using WIC decoder. Application in the bug 39474 depends on this (GetObject/bmBits should not be NULL, otherwise it crashes). Also, since CreateDIBSection doesn't support RLE compressed bitmaps it's necessary to decompress it in memory in advance. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39474 Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru> But unfortunately the image is now rendered upside-down, should this get it's own bug report? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla