[Bug 51130] New: user32:win test_SetActiveWindow() has 2 failures on Vista to Windows 8.1
https://bugs.winehq.org/show_bug.cgi?id=51130 Bug ID: 51130 Summary: user32:win test_SetActiveWindow() has 2 failures on Vista to Windows 8.1 Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com user32:win test_SetActiveWindow() has 2 systematic failures on Vista to Windows 8.1 which don't happen on Windows 10: https://test.winehq.org/data/patterns.html#user32:win win.c:3191: Test failed: GetActiveWindow() = 00000000 win.c:3191: Test failed: GetFocus() = 00000000 The failing test was introduced by this commit: commit e188d66251e6f9693629fe3e1bfa4bd2e9a534cf Author: Zebediah Figura <z.figura12(a)gmail.com> AuthorDate: Tue Dec 19 18:29:30 2017 -0600 Commit: Alexandre Julliard <julliard(a)winehq.org> CommitDate: Wed Dec 20 17:48:57 2017 +0100 user32/tests: Add more tests for SetActiveWindow(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51130 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |e188d66251e6f9693629fe3e1bf | |a4bd2e9a534cf Keywords| |source, testcase -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51130 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51130 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.0-rc3 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51130 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51130 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51130 --- Comment #1 from Zebediah Figura <z.figura12(a)gmail.com> --- Not sure why this isn't a regression? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51130 --- Comment #2 from François Gouget <fgouget(a)codeweavers.com> --- It is a regression in the conformance tests so I think it's ok to set the 'Regression SHA1' property. But this does not impact running Windows applications in Wine so I'm not sure the regression keyword is applicable. The keyword definitions are not very clear. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51130 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51130 --- Comment #3 from Zebediah Figura <z.figura12(a)gmail.com> --- It doesn't happen when running the tests by themselves, which suggests that it may be an earlier test leaving a foreground window open or otherwise corrupting state. I don't know why leaving a foreground window open would break those tests specifically, though. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51130 Rémi Bernon <rbernon(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbernon(a)codeweavers.com Fixed by SHA1| |ebe3cea01d127de612171b6276c | |473a2b455266d Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Rémi Bernon <rbernon(a)codeweavers.com> --- I think the problem was coming from SetActiveWindow(0) calls, which were done on various occasion, trying to de-activate the active window. The problem is that on older (< Win10), SetActiveWindow(0) succeeds but tries to give the foreground to another applications (or requests it back on the second call), possibly losing it. I'm not completely sure if this was a bug or a feature, and I'm a bit surprised that you could get the foreground back as easily (although I haven't tried what an user action could change). But this has clearly been removed since Win10. The call now returns 0 (which should be understood as a failure I guess, although it doesn't change last error). I added proper testing of this behavior, and removed the calls where they were done as it's a bit unpredictable. I believe the failure should not happen anymore after ebe3cea01d127de612171b6276c473a2b455266d (although there may still be GetActiveWindow failures elsewhere for other reasons). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51130 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla