[Bug 56516] New: winhlp32 needs MACRO_PopupContext() to be implemented for HOMM3 map editor to show help popups
https://bugs.winehq.org/show_bug.cgi?id=56516 Bug ID: 56516 Summary: winhlp32 needs MACRO_PopupContext() to be implemented for HOMM3 map editor to show help popups Product: Wine Version: 9.5 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: programs Assignee: wine-bugs(a)winehq.org Reporter: damjan.jov(a)gmail.com Distribution: --- As discussed on https://forum.winehq.org/viewtopic.php?t=38331 The user reports how in the "Heroes of Might and Magic III" map editor: "When you right click an object in the editor, a small window pops up with extra info on it, and this uses the old WinXP help system." "In Wine, when I call "Help" in this editor, I get the little "Failed to launch Help" error message, and after that, all help, on all (old) Windows programs, is broken until I restart Wine." It was traced to a missing implementation of MACRO_PopupContext(). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=56516 Stian Low <wineryyyyy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wineryyyyy@gmail.com --- Comment #1 from Stian Low <wineryyyyy@gmail.com> --- Created attachment 81444 --> http://bugs.winehq.org/attachment.cgi?id=81444 Screenshot of help popup working via patch. Patch supports right-click for map sidebar to open help popup with correct context loaded. diff --git a/programs/winhlp32/macro.c b/programs/winhlp32/macro.c index 36bda654afd..b97d6fbae22 100644 --- a/programs/winhlp32/macro.c +++ b/programs/winhlp32/macro.c @@ -672,6 +672,7 @@ static void CALLBACK MACRO_NoShow(void) void CALLBACK MACRO_PopupContext(LPCSTR str, LONG u) { WINE_FIXME("(%s, %lu)\n", debugstr_a(str), u); + MACRO_JumpContext (str, "main", u); } static void CALLBACK MACRO_PopupHash(LPCSTR str, LONG u) Text readability is poor but content is correct. Maybe winetricks fixes font issues? Help zoom also seems broken for vanilla wine which causes characters to collide. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=56516 --- Comment #2 from Stian Low <wineryyyyy@gmail.com> --- https://gitlab.winehq.org/wine/wine/-/merge_requests/11400 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=56516 --- Comment #3 from Stian Low <wineryyyyy@gmail.com> --- (In reply to Stian Low from comment #2)
MR-56516 displays popup but the style will be bugged until `riched20 ME_SendRequestResize ME_TextEditor` bugs are fixed which will be handled by a separate merge request. Therefore this bug is still pending fixes for riched20 texteditor so that popup is at least positioned under the control and text appears without having to scroll and reasonably similar to Window screenshot: https://gitlab.winehq.org/wine/wine/-/merge_requests/11400#note_145810 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla