[Bug 51614] New: NtGdiSetLayout is missing call to release_dc_ptr(dc)
https://bugs.winehq.org/show_bug.cgi?id=51614 Bug ID: 51614 Summary: NtGdiSetLayout is missing call to release_dc_ptr(dc) Product: Wine Version: 6.15 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: major Priority: P2 Component: gdi32 Assignee: wine-bugs(a)winehq.org Reporter: jinoh.kang.kr(a)gmail.com CC: huw(a)codeweavers.com, jacek(a)codeweavers.com, julliard(a)winehq.org Regression SHA1: 22df510eff3ee66bf02230b46eefef64a5bd8f74 Distribution: --- Created attachment 70467 --> https://bugs.winehq.org/attachment.cgi?id=70467 Patch to add back release_dc_ptr(dc) to appropriate place The commit 22df510eff3ee66bf02230b46eefef64a5bd8f74 (gdi32: Use ntgdi interface for SetLayout implementation.) deletes a call to release_dc_ptr(dc) following get_dc_ptr(hdc) in NtGdiSetLayout(HDC,LONG,DWORD). The thread calling NtGdiSetLayout therefore holds the DC lock indefinitely, preventing other threads from accessing the device context. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51614 Jinoh Kang <jinoh.kang.kr(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51614 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- Thank you, confirming. Please submit this patch to wine-devel mailing list, instructions are here https://wiki.winehq.org/Submitting_Patches. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51614 --- Comment #2 from Jacek Caban <jacek(a)codeweavers.com> --- Thanks. I submitted the patch: https://source.winehq.org/patches/data/211610 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51614 Jacek Caban <jacek(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |76821849fef841d4b1c4ce44ee0 | |48d43214a3fe9 Status|NEW |RESOLVED --- Comment #3 from Jacek Caban <jacek(a)codeweavers.com> --- Fixed in git: https://source.winehq.org/git/wine.git/commitdiff/76821849fef841d4b1c4ce44ee... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51614 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 6.16. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=51614 Ken Sharp <imwellcushtymelike@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cedric.dewijs@eclipso.eu --- Comment #5 from Ken Sharp <imwellcushtymelike@gmail.com> --- *** Bug 51637 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla