[Bug 55421] New: Fallout Tactics graphics glitches only with winehq-devel
https://bugs.winehq.org/show_bug.cgi?id=55421 Bug ID: 55421 Summary: Fallout Tactics graphics glitches only with winehq-devel Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: darkranger_red(a)hotmail.com Distribution: --- The game 'Fallout Tactics: Brotherhood of Steel' is fully playable with Wine. But recently I am not sure from which Wine version, the game shows some noticeable graphics glitches, which the previous Wine version doesn't have. So I uninstalled Wine from Fedora's repo, and use the WineHQ's repo instead. It turns out that the game's graphics runs normally with winehq-stable(8.0.2), but has some glitches with winehq-devel(8.13). The attached screenshots show the launcher menu differences between Wine 8.0.2 and 8.13. Besides that, the in-game graphics also has more glitches with winehq-devel, but usually happen in very short time and difficult to capture the screenshots. OS: Fedora Linux 38 (Workstation Edition) x86_64 Kernel: 6.4.7-200.fc38.x86_64 Uptime: 2 hours, 9 mins Packages: 2703 (rpm) Shell: bash 5.2.15 Resolution: 1920x1080 DE: GNOME 44.3 WM: Mutter WM Theme: Adwaita Theme: Adwaita [GTK2/3] Icons: Adwaita [GTK2/3] Terminal: gnome-terminal CPU: AMD FX-8350 (8) @ 4.000GHz GPU: NVIDIA GeForce GTX 660 Memory: 5130MiB / 15932MiB -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 --- Comment #1 from Red Shen <darkranger_red(a)hotmail.com> --- Created attachment 74981 --> https://bugs.winehq.org/attachment.cgi?id=74981 Fallout Tactics launcher menu with Wine 8.0.2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 --- Comment #2 from Red Shen <darkranger_red(a)hotmail.com> --- Created attachment 74982 --> https://bugs.winehq.org/attachment.cgi?id=74982 Fallout Tactics launcher menu with Wine 8.13 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- I can also reproduce this issue using Fallout Tactics from GOG. The issue first appears in wine-8.9. It works fine in wine-8.8. I'll try to bisect it completely. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |8.9 Summary|Fallout Tactics graphics |Fallout Tactics launcher |glitches only with |has graphics glitches |winehq-devel | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |413fc34be7fca948dc53b3eb8cd | |1a08e951f2b4e Component|-unknown |gdiplus CC| |gang65(a)poczta.onet.pl --- Comment #4 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Bisection revealed: 413fc34be7fca948dc53b3eb8cd1a08e951f2b4e is the first bad commit commit 413fc34be7fca948dc53b3eb8cd1a08e951f2b4e Author: Bartosz Kosiorek <gang65(a)poczta.onet.pl> Date: Thu May 18 21:49:15 2023 +0200 gdiplus: Fix GdipGetGenericFontFamily functions according to native gdiplus.dll. dlls/gdiplus/font.c | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 --- Comment #5 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Reverting the offending commit on current wine-git also fixes the issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 --- Comment #6 from Bartosz <gang65(a)poczta.onet.pl> --- I will prepare patch soon. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 --- Comment #7 from Bartosz <gang65(a)poczta.onet.pl> --- Created attachment 75021 --> https://bugs.winehq.org/attachment.cgi?id=75021 logs from wine-8.13 with glitches reproduced -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 --- Comment #8 from Bartosz <gang65(a)poczta.onet.pl> --- Interesting logs from Wine 8.13: 173.705:00f0:trace:gdiplus:GdipGetGenericFontFamilySansSerif (0000000000CD0760) 173.705:00f0:trace:gdiplus:GdipCreateFontFamilyFromName L"Microsoft Sans Serif", 0000000000000000 0000000000CD0760 173.705:00f0:trace:gdiplus:GdipNewInstalledFontCollection (000000000011D768) 173.705:00f0:trace:gdiplus:GdipCreateFontFamilyFromName L"Arial", 0000000000000000 0000000000CD0760 173.705:00f0:trace:gdiplus:GdipNewInstalledFontCollection (000000000011D768) 173.705:00f0:trace:gdiplus:GdipCloneFontFamily 00000000007D15F0 (L"Arial"), 0000000000CD0760 173.705:00f0:trace:gdiplus:GdipCreateFontFamilyFromName <-- 00000000007D15F0 173.705:00f0:trace:gdiplus:GdipGetFamilyName 00000000007D15F0, 000000000011D7B0, 0 173.705:00f0:trace:gdiplus:GdipCreateFont 00000000007D15F0 (L"Arial"), 8.250000, 0, 3, 0000000000CA75C0 173.705:00f0:trace:gdiplus:GdipGetFamilyName 00000000007D15F0, 000000000011D6DC, 0 173.705:00f0:trace:gdiplus:GdipCloneFontFamily 00000000007D15F0 (L"Arial"), 00000000007E2760 173.705:00f0:trace:gdiplus:GdipCreateFont <-- 00000000007E2760 173.721:00f0:trace:gdiplus:GdipCreateFromHDC (0000000014010042, 000000000011D778) 173.721:00f0:trace:gdiplus:GdipCreateFromHDC2 (0000000014010042, 0000000000000000, 000000000011D778) 173.721:00f0:trace:gdiplus:GdipSetMatrixElements (00000000007E28B4(0.00,0.00,0.00,0.00,0.00,0.00), 1.00, 0.00, 0.00, 1.00, 0.00, 0.00) 173.721:00f0:trace:gdiplus:GdipCreateRegion 00000000007E28D0 173.721:00f0:trace:gdiplus:GdipCreateRegion => 00000000007DF9C0 173.721:00f0:trace:gdiplus:GdipSetMatrixElements (00000000007E2904(0.00,0.00,0.00,0.00,0.00,0.00), 1.00, 0.00, 0.00, 1.00, 0.00, 0.00) 173.721:00f0:trace:gdiplus:GdipCreateFromHDC2 <-- 00000000007E2860 173.721:00f0:trace:gdiplus:GdipGetLogFontW (00000000007E2760, 00000000007E2860, 00000000007DAEB0) 173.721:00f0:trace:gdiplus:GdipTransformMatrixPoints (000000000011D590(1.00,0.00,0.00,1.00,0.00,0.00), 000000000011D5B0, 3) 173.721:00f0:trace:gdiplus:GdipGetLogFontW => L"Arial",-11 173.721:00f0:trace:gdiplus:GdipDeleteGraphics (00000000007E2860) 173.721:00f0:trace:gdiplus:GdipDeleteRegion 00000000007DF9C0 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 --- Comment #9 from Bartosz <gang65(a)poczta.onet.pl> --- With previous implementation the Tahoma font was taken in case MS Sans Serif is missing: 720.292:0114:trace:gdiplus:GdipGetGenericFontFamilySansSerif (0000000000CD0760) 720.292:0114:trace:gdiplus:GdipCreateFontFamilyFromName L"Microsoft Sans Serif", 0000000000000000 0000000000CD0760 720.292:0114:trace:gdiplus:GdipNewInstalledFontCollection (000000000011D768) 720.292:0114:trace:gdiplus:GdipCreateFontFamilyFromName L"Tahoma", 0000000000000000 0000000000CD0760 720.292:0114:trace:gdiplus:GdipNewInstalledFontCollection (000000000011D7A8) 720.292:0114:trace:gdiplus:GdipCloneFontFamily 0000000000850040 (L"Tahoma"), 0000000000CD0760 720.292:0114:trace:gdiplus:GdipCreateFontFamilyFromName <-- 0000000000850040 720.292:0114:trace:gdiplus:GdipGetFamilyName 0000000000850040, 000000000011D7B0, 0 720.292:0114:trace:gdiplus:GdipCreateFont 0000000000850040 (L"Tahoma"), 8.250000, 0, 3, 0000000000CA75C0 720.292:0114:trace:gdiplus:GdipGetFamilyName 0000000000850040, 000000000011D6DC, 0 720.292:0114:trace:gdiplus:GdipCloneFontFamily 0000000000850040 (L"Tahoma"), 00000000007DCC80 720.292:0114:trace:gdiplus:GdipCreateFont <-- 00000000007DCC80 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 Jeff Smith <whydoubt(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |whydoubt(a)gmail.com --- Comment #10 from Jeff Smith <whydoubt(a)gmail.com> ---
From those logs, it appears that the glitches show up when wine picks Arial over Tahoma. Assuming the analysis in https://gitlab.winehq.org/wine/wine/-/merge_requests/2850 is correct, removing "Microsoft Sans Serif" should make Windows fall back to Arial. Testing the game then would show whether Arial causes the glitches in native as well, or whether it is wine mishandling something when Arial is used.
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 --- Comment #11 from Bartosz <gang65(a)poczta.onet.pl> --- The issue is present also with native gdiplus. On Linux after copying Microsoft Sans Serif font into `/usr/share/fonts/msfonts/micross.ttf` location, both native and buildin wine is working perfectly fine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 --- Comment #12 from Bartosz <gang65(a)poczta.onet.pl> --- More information about font: https://learn.microsoft.com/pl-pl/typography/font-list/microsoft-sans-serif -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 --- Comment #13 from Jeff Smith <whydoubt(a)gmail.com> --- I have also tested adjusting the registry on Windows so that "Microsoft Sans Serif" is no longer picked. Thus Windows picks Arial, and the same glitches are present. So in all cases where Arial is the chosen font, the glitches are present. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 --- Comment #14 from Esme Povirk <madewokherd(a)gmail.com> --- Tahoma works by coincidence. We need a metric-compatible replacement for Microsoft Sans Serif. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 --- Comment #15 from Esme Povirk <madewokherd(a)gmail.com> --- Made an MR with a partial revert: https://gitlab.winehq.org/wine/wine/-/merge_requests/4949 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 Julian Rüger <jr98(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jr98(a)gmx.net -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED Fixed by SHA1| |294efcdf444ed90ee6bb39889dd | |0a2f33f3eff74 --- Comment #16 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- (In reply to Esme Povirk from comment #15)
Made an MR with a partial revert: https://gitlab.winehq.org/wine/wine/-/merge_requests/4949
This PR was accepted upstream as: https://gitlab.winehq.org/wine/wine/-/commit/294efcdf444ed90ee6bb39889dd0a2f... Glitches are fixed for me, marking FIXED. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #17 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 9.5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=55421 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |9.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=55421 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|9.0.x |--- --- Comment #18 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 9.0.x milestone from bug fixes included in 9.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla