[Bug 27559] New: ImgBurn crash at startup when Wine's 'Windows Version' is set to 'Vista' (or newer)
http://bugs.winehq.org/show_bug.cgi?id=27559 Summary: ImgBurn crash at startup when Wine's 'Windows Version' is set to 'Vista' (or newer) Product: Wine Version: 1.3.22 Platform: x86 URL: http://www.imgburn.com/ OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: lightning_uk(a)imgburn.com I've had a bunch of crash logs sent to me over the past year where ImgBurn crashes unrecoverably on startup when users are running it under Wine but was never able to reproduce the error until today. It turns out that if Wine's 'Windows Version' is set to 'XP' (default and what I'd always been using) everything works fine. The second it's changed to 'Vista' (or newer), the app crashes at startup. I've managed to get a crash call stack via madExcept / Eurekalog and have now traced the problem back to the 'Explorer' style component it uses in the 'Disc Layout Editor' window ('TVirtualExplorerTree' by MustangPeak). It looks like it's related to namespace stuff and therefore the shell? I've made/attached a Delphi demo app with a single form and single instance of 'TVirtualExplorerTree' to hopefully make testing and debugging this issue a little easier. Without fail, it'll crash when Wine's 'Windows Version' is set to 'Vista' but it's fine as 'XP'. I'm using Wine in Ubuntu 11.04 for testing. The programs (ImgBurn and demo app) work fine on a real Windows XP, Vista or 7 installation. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #1 from LIGHTNING UK! <lightning_uk(a)imgburn.com> 2011-06-22 11:13:27 CDT --- Attachment was too large so I've uploaded it here: http://www.2shared.com/file/rIx6odBZ/VirtualExplorerTreeTest.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Severity|normal |minor --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2011-06-22 11:30:22 CDT --- Confirming: fixme:shell:FileIconInit (true) fixme:shell:SHGetFileInfoW set icon to shell size, stub fixme:shell:SHGetFileInfoW set icon to shell size, stub err:win:DefWindowProcA called for other process window 0x3008e fixme:win:EnumDisplayDevicesW ((null),0,0xd8dc00,0x00000000), stub! though no backtrace, as the application has its own exception handler. Any chance you could disable that? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #3 from LIGHTNING UK! <lightning_uk(a)imgburn.com> 2011-06-22 11:54:40 CDT --- Bah and there's me thinking the exception handler thing might actually be useful! Here's a version of the app without it... http://www.2shared.com/file/MFjaIFC4/VirtualExplorerTreeTest.html I appreciate you taking a look. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #4 from LIGHTNING UK! <lightning_uk(a)imgburn.com> 2011-07-27 09:39:03 CDT --- Ok so I've done a bit of digging around today and I have now found the cause for this crash. Wine doesn't seem to have any code for 'SHGetKnownFolderIDList'. It's a new function that was first available in Windows Vista. The 'TVirtualExplorerTree' component wants (and expects to be able) to use it on Vista+ OS's but GetProcAddress(Shell32DLL, "SHGetKnownFolderIDList") just returns null. Without it, lots of things end up being invalid (null/nil) pointers and that's what causes the crash. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 Andy <andysem(a)mail.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andysem(a)mail.ru --- Comment #5 from Andy <andysem(a)mail.ru> 2011-11-20 03:57:55 CST --- I'm having crashes even with Windows Version set to XP. My Wine is 1.3.33, but it was the same with 1.3.32. At some prior Wine version ImgBurn worked fine. I'm attaching crash report that was produced when the application crashed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #6 from Andy <andysem(a)mail.ru> 2011-11-20 03:59:32 CST --- Created attachment 37546 --> http://bugs.winehq.org/attachment.cgi?id=37546 Crash report of ImgBurn -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |focht(a)gmx.net Component|-unknown |shell32 Summary|ImgBurn crash at startup |ImgBurn crashes on startup |when Wine's 'Windows |when run with WinVer >= |Version' is set to 'Vista' |Vista, needs |(or newer) |shell32.SHGetKnownFolderIDL | |ist() --- Comment #7 from Anastasius Focht <focht(a)gmx.net> 2011-11-20 04:39:10 CST --- Hello, @Andy, your problem is completely unrelated to this bug. --- snip --- main thread ($31): 00a3ee9e +035a ImgBurn.exe madExcept _17211 7bc785ec +001c ntdll.dll NtRaiseException 00a3ee96 +0352 ImgBurn.exe madExcept _17211 00a3f005 +0035 ImgBurn.exe madExcept _17213 7b874b5c +004c KERNEL32.dll CreateThread 7e47730d +017d rpcrt4.dll RpcServerRegisterIf2 7e47780e +005e rpcrt4.dll RpcServerRegisterIfEx 7e503789 +0639 ole32.dll CoMarshalInterface 7e50a2e8 +0228 ole32.dll RegisterDragDrop 008a3cb0 +0098 ImgBurn.exe OleDropTarget.cpp 139 +18 TOleDropTarget.SetEnabled 0074b4db +11b3 ImgBurn.exe Main.cpp 393 +320 TfrmMain.Create 0094c316 +006e ImgBurn.exe Forms 8182 +7 TApplication.CreateForm 006f713d +002d ImgBurn.exe ImgBurn.cpp 1883 +4 CreateForms 006ef1ce +036a ImgBurn.exe ImgBurn.cpp 185 +80 WinMain 00a72fb4 +014c ImgBurn.exe __startup 7bc78b39 +01e9 ntdll.dll RtlCaptureStackBackTrace --- snip --- That issue is bug 28753 which was fixed a some weeks ago. If that still happens your Wine build is broken ("-fno-omit-frame-pointer" should be added by default on x86 arch). Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 Marcus Meissner <marcus(a)jet.franken.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marcus(a)jet.franken.de --- Comment #8 from Marcus Meissner <marcus(a)jet.franken.de> 2011-11-21 07:08:18 CST --- if you had a known good version of Wine, could you list it? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #9 from Andy <andysem(a)mail.ru> 2011-11-21 12:49:45 CST --- (In reply to comment #8)
if you had a known good version of Wine, could you list it?
I'm using Wine 1.3.33 x86-64 from openSUSE 12.1 repository: http://en.opensuse.org/Wine#Repositories I've e-mailed package maintainer about this issue, no reply yet. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #10 from Andy <andysem(a)mail.ru> 2011-11-21 13:07:24 CST --- (In reply to comment #8)
if you had a known good version of Wine, could you list it?
I was a bit hasty. I got the reply, which says that -fno-omit-frame-pointer is present for the 1.3.33 build. Should this report be extracted to a separate bug then? I can't remember the exact Wine version that worked, it should have broken in the recent few releases. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #11 from Anastasius Focht <focht(a)gmx.net> 2011-11-21 15:43:56 CST --- Hello Andy, --- quote --- I was a bit hasty. I got the reply, which says that -fno-omit-frame-pointer is present for the 1.3.33 build. Should this report be extracted to a separate bug then? --- quote --- I downloaded the openSUSE 32 bit Wine RPM "wine-32bit-1.3.33-2.1.i586.rpm" from http://software.opensuse.org/search?q=wine&baseproject=openSUSE%3A12.1 and extracted everything "offline" using "rpm2cpio wine-32bit-1.3.33-2.1.i586.rpm | cpio -vid" Disassembly of "rpcrt4.dll.so" shows the frame pointer is abused everywhere which explains the crash. Fortunately the build logs are also available online: https://build.opensuse.org/package/rawlog?arch=i586&package=wine&project=Emu... --- snip --- gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_RPCRT4_ -DCOM_NO_WINDOWS_H -DMSWMSG -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -DLDAP_DEPRECATED=1 -fomit-frame-pointer -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o rpc_server.o rpc_server.c --- snip --- "-fno-omit-frame-pointer" is passed but overridden later with "-fomit-frame-pointer". Hence all binaries are compiled as if default gcc 4.6.x setting is used, causing app breakage. The problematic .spec file snippet: --- snip --- %ifarch %ix86 # Steam hates it. export RPM_OPT_FLAGS=`echo %{optflags}|sed -e 's/-fomit-frame-pointer//'` %endif CFLAGS="-DLDAP_DEPRECATED=1 %{optflags}" \ ... --- snip --- corresponding output: --- snip --- ++ echo -fomit-frame-pointer -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g ++ sed -e s/-fomit-frame-pointer// + export 'RPM_OPT_FLAGS= -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g' + RPM_OPT_FLAGS=' -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g' + CFLAGS='-DLDAP_DEPRECATED=1 -fomit-frame-pointer -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g' --- snip --- %optflags vs. $RPM_OPT_FLAGS All openSUSE 12.x 32 bit Wine builds had this problem from the beginning. Anyway this is a packaging bug, not Wine. Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 Marcus Meissner <marcus(a)jet.franken.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #12 from Marcus Meissner <marcus(a)jet.franken.de> 2011-11-21 15:59:07 CST --- Yes, ANastasius is right, the -fomit-frame-pointer is incorrectly added. I have adjusted the spec file and checked it in right now, so the next build should work better. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #13 from Anastasius Focht <focht(a)gmx.net> 2011-11-21 16:23:07 CST --- Hello Marcus, this bug is about a _legitimate_ Wine insufficiency, see summary. With "Anyway this is a packaging bug, not Wine." I meant Andy's problem with openSUSE build of Wine that just meddled in here (starting with comment #5). Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #14 from Andy <andysem(a)mail.ru> 2011-11-21 21:20:50 CST --- I have just updated to the latest Wine build and it fixed the problem. Thanks a lot, guys. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #15 from Austin English <austinenglish(a)gmail.com> 2012-05-01 14:24:40 CDT --- A stub was committed (adc0518af74d79e45b68a4119d3532c6c4e8599e). Please retest. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |adc0518af74d79e45b68a4119d3 | |532c6c4e8599e Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #16 from Anastasius Focht <focht(a)gmx.net> 2012-05-01 16:49:27 CDT --- Hello, with the SHGetKnownFolderIDList stub the crash is gone. There are a bunch of fixme's now in Win7 mode but it seems no immediate loss of functionality. File new bug(s) if you still have problems and provide step-by-step guide to reproduce. --- snip --- ... fixme:shell:SHGetKnownFolderIDList {b4bfcc3a-db2c-424c-b029-7fe99a87c641}, 0x00000000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {b7534046-3ecb-4c18-be4e-64cd4cb7d6ac}, 0x00000000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {b4bfcc3a-db2c-424c-b029-7fe99a87c641}, 0x00001000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {0ac0837c-bbf8-452a-850d-79d08e667ca7}, 0x00000000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {76fc4e2d-d6ad-4519-a663-37bd56068185}, 0x00000000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {d9dc8a3b-b784-432e-a781-5a1130a75963}, 0x00000000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {82a74aeb-aeb4-465c-a014-d097ee346d63}, 0x00000000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {d20beec4-5ca8-4905-ae3b-bf251ea09b53}, 0x00000000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {a63293e8-664e-48db-a079-df759e0509f7}, 0x00000000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {fdd39ad0-238f-46af-adb4-6c85480369c7}, 0x00000000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {1777f761-68ad-4d8a-87bd-30b759fa33dd}, 0x00000000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {3eb685db-65f9-4cf6-a03a-e3ef65729f3d}, 0x00000000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {905e63b6-c1bf-494e-b29c-65b732d3d21a}, 0x00000000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {cac52c1a-b53d-4edc-92d7-6b2e8ac19434}, 0x00001000, (nil), 0x146fdd0 fixme:shell:SHGetKnownFolderIDList {a302545d-deff-464b-abe8-61c8648d939b}, 0x00001000, (nil), 0x146fdd0 ... --- snip --- $ du -sh SetupImgBurn_2.5.7.0.exe 5.9M SetupImgBurn_2.5.7.0.exe $ sha1sum SetupImgBurn_2.5.7.0.exe 13ddfa1862b74bdbbc06fc8766b36b9b73b25760 SetupImgBurn_2.5.7.0.exe $ wine --version wine-1.5.3-73-g93a0ca7 Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #17 from LIGHTNING UK! <lightning_uk(a)imgburn.com> 2012-05-02 02:56:34 CDT --- Sorry to be a pain but you'd have to retest with ImgBurn 2.5.5.0 or earlier. All versions after that (i.e. 2.5.6.0 and 2.5.7.0) have a workaround for this problem - as noted in the changelog. I'm not convinced anything other than a full implementation of 'SHGetKnownFolderIDList' would work properly as the call is basically still failing to return anything useful and 'TVirtualExplorerTree' doesn't check to see if the results are valid before attempting to use them. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED URL|http://www.imgburn.com/ |http://www.oldapps.com/imgb | |urn.php?old_imgburn=16?down | |load Resolution|FIXED | Summary|ImgBurn crashes on startup |ImgBurn 2.5.5.0 and earlier |when run with WinVer >= |needs |Vista, needs |shell32.SHGetKnownFolderIDL |shell32.SHGetKnownFolderIDL |ist() implementation when |ist() |run with WinVer >= Vista --- Comment #18 from Anastasius Focht <focht(a)gmx.net> 2012-05-02 04:09:28 CDT --- Hello, --- quote --- All versions after that (i.e. 2.5.6.0 and 2.5.7.0) have a workaround for this problem - as noted in the changelog. --- quote --- this is something you should have explicitly mentioned in the bug and summary. You can't expect that people read application/developer changelogs in search of Wine 'workarounds'. Changing download to point to old 2.5.5 version: http://www.oldapps.com/imgburn.php?old_imgburn=16?download Reopening to target the shell32.SHGetKnownFolderIDList() stub implementation. --- quote --- I'm not convinced anything other than a full implementation of 'SHGetKnownFolderIDList' would work properly as the call is basically still failing to return anything useful and 'TVirtualExplorerTree' doesn't check to see if the results are valid before attempting to use them. --- quote --- Then you might also want to add a step-by-step guide how to verify the missing functionality (which menu/dialog to select? screenshots for comparison etc). Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #19 from LIGHTNING UK! <lightning_uk(a)imgburn.com> 2012-05-02 04:35:01 CDT --- --- quote --- this is something you should have explicitly mentioned in the bug and summary. You can't expect that people read application/developer changelogs in search of Wine 'workarounds'. --- quote --- How could I mention something that didn't exist at the time?! This report is almost a year old now. I added a test program in comment 1 and then an updated version in comment 3 (with built in exception handling disabled). You don't need to do anything except run the test program, it crashes instantly. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lukasz.wojnilowicz(a)gmail.co | |m --- Comment #20 from Anastasius Focht <focht(a)gmx.net> 2013-05-20 15:36:30 CDT --- *** Bug 33627 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #21 from super_man(a)post.com --- Steps to test this bug. 1. Download the exe. 2. Install 3. Change windows version to vista 4. Try to run the imgburn exe I just tested this. Runs in xp mode, but crashes in vista mode changing back to xp mode fixes the crash. Assuming that the analyze is correct. No known patch for this? wine 1.9.5 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 Robert Walker <bob.mt.wya(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob.mt.wya(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #22 from Nikolay Sivov <bunglehead(a)gmail.com> --- Function itself is implemented with http://source.winehq.org/git/wine.git/commit/80d28abdc8cadb6dc5e35c36c2d9f71.... I still get stack overflow for Vista+ though. Maybe author can clarify what's going on. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #23 from winetest(a)luukku.com --- I think the program has regressed. See bug 40992. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xerox_xerox2000(a)yahoo.co.uk --- Comment #24 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> --- A user reported same problems with this app in wine-forum, so still present. The hack below makes it start for me in Windows 7, so there`s still some work to do on this function SHGetKnownFolderIDList diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c index 9230623..b9dceca 100644 --- a/dlls/shell32/shellpath.c +++ b/dlls/shell32/shellpath.c @@ -5867,8 +5867,8 @@ HRESULT WINAPI SHGetKnownFolderIDList(REFKNOWNFOLDERID rfid, DWORD flags, HANDLE if (!pidl) return E_INVALIDARG; - if (flags) - FIXME("unsupported flags: 0x%08x\n", flags); + if (flags){ + FIXME("unsupported flags: 0x%08x\n", flags);return E_FAIL;} if (token) FIXME("user token is not used.\n"); -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #25 from Nikolay Sivov <bunglehead(a)gmail.com> --- Could you attach +shell log? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wine.bugzilla(a)andrew.rf-ent | |.com --- Comment #26 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> --- *** Bug 40992 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #27 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> --- Created attachment 56758 --> https://bugs.winehq.org/attachment.cgi?id=56758 + shell log Here it is, (I control C^d to quit the hang up app) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #28 from Nikolay Sivov <bunglehead(a)gmail.com> --- --- trace:shell:SHGetKnownFolderIDList {cac52c1a-b53d-4edc-92d7-6b2e8ac19434}, 0x00001000, (nil), 0x149fdd0 fixme:shell:SHGetKnownFolderIDList unsupported flags: 0x00001000 trace:shell:SHGetKnownFolderPath {cac52c1a-b53d-4edc-92d7-6b2e8ac19434}, 0x00001000, (nil), 0x149fd68 trace:shell:SHGetKnownFolderPath Failed to get folder path, 0x80070057. trace:shell:SHGetKnownFolderIDList {a302545d-deff-464b-abe8-61c8648d939b}, 0x00001000, (nil), 0x149fdd0 fixme:shell:SHGetKnownFolderIDList unsupported flags: 0x00001000 trace:shell:SHGetKnownFolderPath {a302545d-deff-464b-abe8-61c8648d939b}, 0x00001000, (nil), 0x149fd68 trace:shell:SHGetKnownFolderPath Failed to get folder path, 0x80070057. --- Failed to get folder path means CSIDL_Type_Disallowed in this case, it's not necessarily wrong. Hacking it to fail on unsupported flags most likely skips the rest of logic, and is not a real issue here. I think it's possible it's another instance of bug 36866, but I haven't tested thoroughly. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 NSLW <lukasz.wojnilowicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|lukasz.wojnilowicz(a)gmail.co | |m | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #29 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> --- Ok. For completeness I add tested version: sha1sum SetupImgBurn_2.5.8.0.exe 49cb5e216f7b17d3955043cd18b1aed0ca3464e5 SetupImgBurn_2.5.8.0.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://www.oldapps.com/imgb |https://web.archive.org/web |urn.php?old_imgburn=16?down |/20121010043453/http://down |load |load.oldapps.com/ImgBurn/Se | |tupImgBurn_2.5.5.0.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #30 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- Created attachment 74526 --> https://bugs.winehq.org/attachment.cgi?id=74526 ImgBurn 2.5.8.0 wine 8.7 WINEDEBUG=+shell terminal output. Hello, Issue resurfaced for me with wine 8.2 forcing win10 version on prefix update. Still present with wine 8.7. sha1sum SetupImgBurn_2.5.8.0.exe 5ca96a0c243390c378dee1a629684ea261e2cfc4 SetupImgBurn_2.5.8.0.exe Regards. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 Bernhard Übelacker <bernhardu@mailbox.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernhardu@mailbox.org --- Comment #31 from Bernhard Übelacker <bernhardu@mailbox.org> --- Created attachment 82420 --> http://bugs.winehq.org/attachment.cgi?id=82420 shell32: Respect the flag KF_FLAG_NO_ALIAS in SHGetKnownFolderIDList. By attempting to investigate bug #60540, I got also this error: err:virtual:virtual_setup_exception stack overflow 1472 bytes ... I want to share a few interesting things: ImgBurn.exe seems to be UPX compressed. By "upx -d ImgBurn.exe" the uncompressed executable can be retrieved and with that gdb is able to show a slightly better backtrace: (rr) bt 0 0x0089813c in ImgBurn!@Mpshellutilities@TNamespace@GetNameForParsing$qqrv 1 0x0089815f in ImgBurn!@Mpshellutilities@TNamespace@GetNameForParsing$qqrv ... 5 0x0089815f in ImgBurn!@Mpshellutilities@TNamespace@GetNameForParsing$qqrv 6 0x0089114e in ImgBurn!@Mpshellutilities@PotentialMappedDrive$qqrp27Mpshellutilities@TNamespace 7 0x0089cefa in ImgBurn!@Mpshellutilities@TNamespace@GetValid$qqrv 8 0x009c532c in ImgBurn!@@Updownedit@Finalize ... 31 0x0070c1e3 in ImgBurn!@@Imagequeue@Finalize 32 0x00a80acf in madTraceProcess 33 0x00000000 in ?? (rr) This GetNameForParsing line gets invoked over and over again until the stack is exhausted. The source of it or a similar version seems to be available here: https://github.com/TurboPack/MustangpeakCommonLib/blob/master/Source/MPShell... This shows if the "IsDesktop" call returns true another call to NameForParsing/GetNameForParsing, that seems to match our recursion. In the end, this "IsDesktop" function seems to be only a check, if "Result := APIDL.mkid.cb = 0". https://github.com/TurboPack/MustangpeakCommonLib/blob/master/Source/MPCommo... Then I noticed this bug report is about SHGetKnownFolderIDList, which threw a warning to me in the console output: fixme:shell:SHGetKnownFolderIDList unsupported flags: 0x00001000 This flag is KF_FLAG_NO_ALIAS and it looks like this is where Wine behaves differently than native. Wine always returns the pidl generated by _ILCreateDesktop, which has mkid.cb == 0. With attached patch applied, versions 2.5.5.0 and 2.5.8.0 do no longer show this stack overflow, maybe you can verify. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=27559 --- Comment #32 from Bernhard Übelacker <bernhardu@mailbox.org> --- Submitted a merge request: https://gitlab.winehq.org/wine/wine/-/merge_requests/12406 (Looks like I came to the same fix already in bug #55405, but never submitted it.) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (3)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla
-
WineHQ Bugzilla