[Bug 51296] New: Cogmind: Mouse cursor is a black square
https://bugs.winehq.org/show_bug.cgi?id=51296 Bug ID: 51296 Summary: Cogmind: Mouse cursor is a black square Product: Wine Version: 6.10 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: jan.steffens(a)gmail.com CC: z.figura12(a)gmail.com Regression SHA1: db2b266c57b73e1a16785213ce923b749c84400e Distribution: ArchLinux Cogmind (a 2D SDL 1.2 game) sets a custom, monochrome mouse cursor. Since Wine 6.10, this cursor is broken and displays as a black square. Cogmind Beta 10.2 Wine 6.9 (good), 6.10 (bad), 6.11 (bad) GNOME 40.2 (no difference between Xorg and Wayland) Arch Linux db2b266c57b73e1a16785213ce923b749c84400e (user32: Handle monochrome icons in CreateIcon() and CreateCursor() instead of CreateIconIndirect().) is the first bad commit. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 luca.cunegondi(a)ocme.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luca.cunegondi(a)ocme.com --- Comment #1 from luca.cunegondi(a)ocme.com --- same problem here with wine-staging on Arch Linux, using a commercial 2D CAD. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Leseratte10(a)vodafone.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Leseratte10(a)vodafone.de --- Comment #2 from Leseratte10(a)vodafone.de --- Same problem on Ubuntu 20.04 (same broken commit db2b266c57b73e1a16785213ce923b749c84400e) in the German chess game "Fritz und Fertig", a demo version of that game can be downloaded here if this is needed to reproduce: https://www.chip.de/downloads/Fritz-Fertig-Folge-1_42308782.html -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |reserv0(a)yahoo.com --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- *** Bug 51611 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #4 from Fabian Maurer <dark.shadow4(a)web.de> --- @Leseratte10 I can't seem to get the demo to work, it crashes when playing "Try". Anything I'm missing here? FWIW, here an internet archive link to the game, just in case: https://web.archive.org/web/20210819181726/https://securedl.cdn.chip.de/down... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #5 from Leseratte10(a)vodafone.de --- Damnit, looks like I stupidly didn't actually test if the demo version even works. I thought I had done that before posting it here. The demo is also crashing for me when I try to run it, so the bug can probably only be reproduced in the full version of the game. Is there any logs I can provide (from the full game) to help find and fix the bug? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #6 from Leseratte10(a)vodafone.de --- Putting this executable into the same folder as the game and then running that instead of the main "Fritz und Fertig.exe" executable should get the demo running. The audio is playing weird and it will probably crash once there's actual gameplay because it's not the correct executable, but it does get you to the "welcome" screen where you have to enter your name and you can see the cursor being broken. https://web.archive.org/web/20210819191744/https://download1589.mediafire.co... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #7 from Leseratte10(a)vodafone.de --- Hm. That seems to not work either on a fresh install. I hate games where copy protections break everything even in a demo version ... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #8 from Jan Alexander Steffens (heftig) <jan.steffens(a)gmail.com> --- @zfigura: I'm sure the developer of Cogmind would be happy to send you a copy if you need it for debugging: gridsagegames(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de --- Comment #9 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 70507 --> https://bugs.winehq.org/attachment.cgi?id=70507 Test cases Attaching a patch containing a few interesting test cases. As I see it, there's two issues here: 1) create_masked_bitmap fails to create working bitmaps on wine at all (the first window that is shown using paint_window) 2) create_masked_bitmap needs to be line by line (because of DWORD alignment) and probably the lines in reverse. @Zebediah Figura I'll continue to look at this, although I wouldn't mind some advice from you :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #10 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 70517 --> https://bugs.winehq.org/attachment.cgi?id=70517 Potential fix Attaching a potential that fixes the issues I found. Would you mind testing with the real program/game to see if that works as well? Please also check if the cursor actually looks like it should, not distorted/flipped/etc. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70517|0 |1 is obsolete| | --- Comment #11 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 70518 --> https://bugs.winehq.org/attachment.cgi?id=70518 Potential fix, try 2 Correction: This should be the correct approach. Please test this if you have time. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #12 from Leseratte10(a)vodafone.de --- This second bugfix does fix the mouse cursor in "Fritz und Fertig". Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, regression, testcase -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #13 from reserv0(a)yahoo.com --- Yep, that patch also fixes the black square mouse cursor bug in Poser 7. Great job ! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #14 from Jan Alexander Steffens (heftig) <jan.steffens(a)gmail.com> --- (In reply to Fabian Maurer from comment #11)
Created attachment 70518 [details] Potential fix, try 2
Correction: This should be the correct approach. Please test this if you have time.
The patch (applied to 6.15) also fixes Cogmind. Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Artem S. Tashkinov <aros(a)gmx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aros(a)gmx.com --- Comment #15 from Artem S. Tashkinov <aros(a)gmx.com> --- *** Bug 51497 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #16 from Artem S. Tashkinov <aros(a)gmx.com> --- (In reply to Fabian Maurer from comment #11)
Created attachment 70518 [details] Potential fix, try 2
Correction: This should be the correct approach. Please test this if you have time.
Fixes Adobe Photoshop cursors as well. Please merge. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lanthruster(a)gmail.com --- Comment #17 from Fabian Maurer <dark.shadow4(a)web.de> --- *** Bug 51737 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cogmind: Mouse cursor is a |Multiple applications |black square |(Cogmind, Photoshop, ...) | |render mouse cursor as | |black square Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #18 from Fabian Maurer <dark.shadow4(a)web.de> --- New patchset is in review... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slayersnet2012(a)gmail.com --- Comment #19 from Fabian Maurer <dark.shadow4(a)web.de> --- *** Bug 51448 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Sagawa <sagawa.aki+winebugs(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sagawa.aki+winebugs(a)gmail.c | |om -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #20 from Artem S. Tashkinov <aros(a)gmx.com> --- (In reply to Fabian Maurer from comment #18)
New patchset is in review...
Where can it be found? Wine 6.19 has just been released and it's still affected. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #21 from Fabian Maurer <dark.shadow4(a)web.de> ---
Where can it be found?
Patch 1: https://source.winehq.org/patches/data/214036 Patch 2: https://source.winehq.org/patches/data/214035 Patch 3: https://source.winehq.org/patches/data/214038
Wine 6.19 has just been released and it's still affected.
Sorry, nothing I can do - I'm waiting and waiting but the patchset is seemingly ignored. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Artem S. Tashkinov <aros(a)gmx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julliard(a)winehq.org --- Comment #22 from Artem S. Tashkinov <aros(a)gmx.com> --- Alexandre, this is quite a serious regression, why is not getting the required attention? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #23 from Artem S. Tashkinov <aros(a)gmx.com> --- If these patches need to revised, can we at least revert the bad commit for a while? Of course I've done that locally but thousands of other people cannot and will not. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #24 from Fabian Maurer <dark.shadow4(a)web.de> --- Latest answer I got is here: https://www.winehq.org/pipermail/wine-devel/2021-October/198150.html Now idea what to make with that though. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Andrey Gusev <andrey.goosev(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a0939712328(a)gmail.com --- Comment #25 from Andrey Gusev <andrey.goosev(a)gmail.com> --- *** Bug 51830 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #26 from Artem S. Tashkinov <aros(a)gmx.com> --- Alexandre Julliard wrote:
If we have to do that sort of thing, I think it shows that using a DIB was not the right choice here.
Two dozen of applications have been identified to be broken by the original commit, can we please do something about that? Maybe revert it since there's no consensus how to proceed from here? Pretty much all Adobe image editing applications are now broken. Multiple games are broken. This is the first time in my life such a drastic regression in Wine has not been addressed or reverted more than four months in a row. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #27 from Fabian Maurer <dark.shadow4(a)web.de> --- I could provide a different patch, if I knew what was needed... Until then, I don't think my patches are a bad solution, FWIW. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #28 from Fabian Maurer <dark.shadow4(a)web.de> --- Any news on how to proceed? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 --- Comment #29 from Artem S. Tashkinov <aros(a)gmx.com> --- (In reply to Fabian Maurer from comment #28)
Any news on how to proceed?
I hope Alexander won't mind me citing his reply from a private email:
Hello Alexandre!
Could you please do something about bug 51296?
The corresponding regression breaks quite a large number of applications.
Two sets of patches have been offered, looks like you've rejected both.
Well yes, someone will have to fix this correctly. Probably it's one of the regression that will be addressed during code freeze.
Honestly I've no idea what it means and what to do. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Guilherme S. <oguilherme(a)protonmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oguilherme(a)protonmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Debucquoy Anthony <d.tonitch(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |d.tonitch(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Илья Индиго <ilya(a)ilya.pp.ua> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ilya(a)ilya.pp.ua --- Comment #30 from Илья Индиго <ilya(a)ilya.pp.ua> --- I noticed today the same problem with the cursors in the game Plants vs Zombies. This patch fixed the problem. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |197f2ee6c0e2dd70cfac6e15ede | |7fc0e38948188 Resolution|--- |FIXED --- Comment #31 from Zebediah Figura <z.figura12(a)gmail.com> --- Should be fixed upstream by <https://source.winehq.org/git/wine.git/commitdiff/197f2ee6c0e2dd70cfac6e15ed...>. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51296 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #32 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.0-rc2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla