[Bug 57031] New: Mouse "tremble" in Robin Hood: The Legend of Sherwood (GoG).
https://bugs.winehq.org/show_bug.cgi?id=57031 Bug ID: 57031 Summary: Mouse "tremble" in Robin Hood: The Legend of Sherwood (GoG). Product: Wine-staging Version: 9.1 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: flaubertSt(a)gmail.com CC: leslie_alistair(a)hotmail.com, z.figura12(a)gmail.com Distribution: --- Installed GoG version of Robin Hood: The Legend of Sherwood. All works, but mouse tremble when in game (it DOESN'T with menu screens). Tried "mouse warp override -all options-but it didnt solve. Strangely, I changed from WINE-9.1-staging to 9.0 stable version and it doesn't tremble anymore, but now it has some lag when exit from pause: see Bug 39513). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57031 Béla Gyebrószki <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://archive.org/downloa | |d/RobinHoodTheLegendOfSherw | |oodDemo/Setup_us.exe CC| |gyebro69(a)gmail.com Keywords| |download --- Comment #1 from Béla Gyebrószki <gyebro69(a)gmail.com> --- I'm pretty sure the problem is there in vanilla Wine too as anyone can test and reproduce the problem with the demo version: https://archive.org/download/RobinHoodTheLegendOfSherwoodDemo/Setup_us.exe Setup_us.exe (81 M) md5sum: a8c4df5cbf009f3381ba582e6fe6c5f2 As for being a regression, I ended up my regression test with this (between wine-9.3 and 9.4): commit 5b833c83beadcad2ace5f27e95554c164f6f7c86 server: Stop waiting on LL-hooks for non-injected input. I must say, even before that commit there was something odd about the way the mouse pointer moved when I alt-tabbed and back to the game window in virtual desktop mode, but commit 5b833c83 is the one which makes the problem highly noticeable. wine-9.14-99-geb7bbf9858b X.Org X Server 1.21.1.13 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57031 --- Comment #2 from Flaubert <flaubertSt(a)gmail.com> --- Versión that fails forms is also 9.14 (staging). Versión 9.0 (system, in Ubuntu 22.04) works with just ocasional "lag after pauses" bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 Lukáš Linhart <l.linhos@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |l.linhos@gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 joaopa <jeremielapuree@yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr --- Comment #3 from joaopa <jeremielapuree@yahoo.fr> --- I confirm the bug with wine-11.3 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 --- Comment #4 from Lukáš Linhart <l.linhos@gmail.com> --- I confirm that after reverting the changes from commit 5b833c83beadcad2ace5f27e95554c164f6f7c86 and building the current master branch, the problem disappeared. Now it's up to someone who understands queue processing to come up with a fix. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 y5kXCS6RgtQp <jacobbrett+winehqbugs@jacobbrett.id.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacobbrett+winehqbugs@jacob | |brett.id.au --- Comment #5 from y5kXCS6RgtQp <jacobbrett+winehqbugs@jacobbrett.id.au> --- I suspect this issue is related to a similar issue with Star Trek: Away Team. Working normally with Wine 8.6, but broken in a similar fashion under Wine 10/11. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 --- Comment #6 from y5kXCS6RgtQp <jacobbrett+winehqbugs@jacobbrett.id.au> --- Excuse my last comment, I meant to say "similar issue with Starship Troopers: Terran Ascendancy". -- I mixed up my test results. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 Antoine Le Gonidec <accounts.winehq@vv221.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |accounts.winehq@vv221.fr -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 Andrei <funnylittleelephant@proton.me> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |funnylittleelephant@proton. | |me --- Comment #7 from Andrei <funnylittleelephant@proton.me> --- Created attachment 82321 --> http://bugs.winehq.org/attachment.cgi?id=82321 AI analysis -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 --- Comment #8 from Andrei <funnylittleelephant@proton.me> --- I have the same problem, and I think I found the cause and a one-line fix. The game uses DirectInput 7, but in dlls/dinput/mouse.c Wine only uses raw input for DirectInput 8 mice: - if (dinput->dwVersion >= 0x0800) impl->base.use_raw_input = TRUE; + impl->base.use_raw_input = TRUE; For older versions dinput gets mouse movement from a low-level mouse hook, by comparing the hook position with GetCursorPos(). Since 5b833c83 input no longer waits for that hook. The cursor position it compares against can therefore be out of date, and the movement comes out wrong, sometimes even backwards. That's the trembling, and it's why reverting 5b833c83 helps. With the change the mouse uses raw input like in DirectInput 8 games, no hook is involved, and the problem is gone for me. Tested with GE-Proton10-34 (Wine 10 based), the same code is in current master. I've attached the patch and a longer write-up of the analysis, which I put together with help from Claude. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 Andrei <funnylittleelephant@proton.me> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82321|0 |1 is obsolete| | --- Comment #9 from Andrei <funnylittleelephant@proton.me> --- Created attachment 82334 --> http://bugs.winehq.org/attachment.cgi?id=82334 AI analysis v2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 --- Comment #10 from Andrei <funnylittleelephant@proton.me> --- Sorry, the fix I described in my previous comment was actually a workaround, and the distinction between DirectInput 7 and DirectInput 8 seems truthful to what Windows library does. It works, but it doesn't address the root problem. I dug deeper using Claude and it looks like Rémi Bernon's change in 5b833c83 was an optimization which opened two races. The serialized behavior is what Windows did prior to DirectInput 8, so games that relied on it worked fine, but the optimization allowed essentially stale state of the cursor to affect the deltas, therefore mouse jittering. I managed to fix the races with Claude, or at least it now works for me, without removing the `if (dinput->dwVersion >= 0x0800)`, attaching an updated AI-generated summary. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 --- Comment #11 from Andrei <funnylittleelephant@proton.me> --- Created attachment 82335 --> http://bugs.winehq.org/attachment.cgi?id=82335 AI -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 Andrei <funnylittleelephant@proton.me> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82334|0 |1 is obsolete| | Attachment #82335|0 |1 is obsolete| | --- Comment #12 from Andrei <funnylittleelephant@proton.me> --- Created attachment 82336 --> http://bugs.winehq.org/attachment.cgi?id=82336 AI analysis v3 Cleaned up the analysis, now it's easier to read and it's focused on the races. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 --- Comment #13 from Antoine Le Gonidec <accounts.winehq@vv221.fr> --- Please refrain from spamming bug reports with so-called "AI" output. If we wanted to run ChatGPT or Claude on WINE bug reports, we are smart enough to do it ourselves. In addition there is no good reason to think these tools never had access to private Microsoft source code, making even something as simple as reading their output enough for a developer to no longer be fit to contribute to WINE development. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57031 --- Comment #14 from Andrei <funnylittleelephant@proton.me> ---
In addition there is no good reason to think these tools never had access to private Microsoft source code, making even something as simple as reading their output enough for a developer to no longer be fit to contribute to WINE development.
I'm sincerely sorry, I didn't know this is such a serious concern regarding AI tools, will of course refrain from doing so in the future. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla