[Bug 60254] New: Merging versions is now ridiculous

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=60254

            Bug ID: 60254
           Summary: Merging versions is now ridiculous
           Product: WineHQ Apps Database
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: major
          Priority: P2
         Component: appdb-unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
  Target Milestone: ---
      Distribution: ---

1. Open an app version
2. Click "move child objects"

What used to happen:
Versions of the app were listed.

What happens now:
Every version of every app is listed.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 60254] Merging versions is now ridiculous

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=60254

Stian Low <[e-mail]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Stian Low <[e-mail]> ---
Thanks for reporting.  

Ridiculous indeed and caused by my latest changes to support paging to fix SQL
timeouts.

I hoped paging could be supported via minimal changes but unfortunately it
seems more are necessary to properly support paging for all webpages that need
it.

MR-51 pending fixes paging for version move child objects listing:
- https://gitlab.winehq.org/winehq/appdb/-/merge_requests/51

This required changing changing objectGetEntries() and objectGetEntriesCount()
for version class from static to non-static which in turn required changing all
static calls which spans across more files.

Previous logic that listed versions was reused to support paging but needed to
be tweaked so that query accounts for appId when exists as part of SQL WHERE
filter.

Places that previously called static methods should work the same as before
with only the webpages needing support for paging applying the appId filter to
narrow the list instead of listing all versions for all apps.

Sorry for inconvenience in meantime.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 60254] Merging versions is now ridiculous

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=60254

Ken Sharp <[e-mail]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.