[Bug 48545] New: SDL GameControllerAddMapping registry keys do not work
https://bugs.winehq.org/show_bug.cgi?id=48545 Bug ID: 48545 Summary: SDL GameControllerAddMapping registry keys do not work Product: Wine Version: 5.0 Hardware: x86 OS: Mac OS X Status: UNCONFIRMED Severity: normal Priority: P2 Component: hid Assignee: wine-bugs(a)winehq.org Reporter: zakk(a)rsdio.com The registry entries to add SDL controller mappings do not work (HKLM/CurrentControlSet/Services/WineBus/Map) I've discovered the enumeration of the subkeys fails with ERROR_ACCESS_DENIED If I change the RegOpenKeyExW call (line 1039 of bus_sdl.c) to use KEY_READ instead of KEY_ENUMERATE_SUB_KEYS the enumeration succeeds and the controller mappings are passed to SDL. The registry keys were created with the stock wine regedit program. I can provide a diff if really required, but I feel like this might be an issue that needs solving somewhere else (perhaps the default permissions on registry key creation need tweaking?) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48545 braiamp(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |braiamp(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48545 --- Comment #1 from braiamp(a)gmail.com --- I can confirm, Map keys are ignored. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48545 --- Comment #2 from Hans Leidekker <hans(a)meelstraat.net> --- (In reply to Zakk from comment #0)
The registry entries to add SDL controller mappings do not work (HKLM/CurrentControlSet/Services/WineBus/Map)
I've discovered the enumeration of the subkeys fails with ERROR_ACCESS_DENIED
If I change the RegOpenKeyExW call (line 1039 of bus_sdl.c) to use KEY_READ instead of KEY_ENUMERATE_SUB_KEYS the enumeration succeeds and the controller mappings are passed to SDL.
The registry keys were created with the stock wine regedit program.
I can provide a diff if really required, but I feel like this might be an issue that needs solving somewhere else (perhaps the default permissions on registry key creation need tweaking?)
No, KEY_ENUMERATE_SUB_KEYS is wrong. It should be KEY_READ as you suggested. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48545 --- Comment #3 from Hans Leidekker <hans(a)meelstraat.net> --- Created attachment 68670 --> https://bugs.winehq.org/attachment.cgi?id=68670 patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48545 Hans Leidekker <hans(a)meelstraat.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |6ce03d93135247fce4e9b231931 | |9c8e989fd3767 Resolution|--- |FIXED --- Comment #4 from Hans Leidekker <hans(a)meelstraat.net> --- Fix committed as 6ce03d93135247fce4e9b2319319c8e989fd3767. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48545 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 6.0-rc1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48545 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48545 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|5.0.x |--- --- Comment #6 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 5.0.x milestone from bug fixes included in 5.0.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla