[Bug 40811] New: WINESERVER variable is only used if @bindir@/ wineserver does not exist

https://bugs.winehq.org/show_bug.cgi?id=40811

            Bug ID: 40811
           Summary: WINESERVER variable is only used if
                    @bindir@/wineserver does not exist
           Product: Wine
           Version: 1.9.12
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wineserver
          Assignee: wine-bugs(a)winehq.org
          Reporter: jre.winesim(a)gmail.com
      Distribution: ---

Wine seems to *always* use @bindir@/wineserver as wineserver if it exists. The
environment variable WINESERVER seems to be ignored as long as the former
exists.

$ alias pswineserver='ps aux|grep wineserver|grep -v grep|sed "s|.* ||"'

$ sudo cp /opt/wine-devel/bin/wineserver /opt/wine-devel/test/
$ pswineserver
$ WINESERVER="/opt/wine-devel/test/wineserver" /opt/wine-devel/bin/winecfg
$ pswineserver
/opt/wine-devel/bin/wineserver

$ sudo rm /opt/wine-devel/bin/wineserver
$ pswineserver
$ WINESERVER="/opt/wine-devel/test/wineserver" /opt/wine-devel/bin/winecfg
$ pswineserver
/opt/wine-devel/test/wineserver

Found in winehq-devel (1.9.12~stretch) from winehq, and wine (1.8.2-1) and
wine-development (1.9.12-1) from Debian.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 40811] WINESERVER variable is only used if @bindir@/ wineserver does not exist

https://bugs.winehq.org/show_bug.cgi?id=40811

Jens Reyer <jre.winesim(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jre.winesim(a)gmail.com

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 40811] WINESERVER variable is only used if @bindir@/wineserver does not exist

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=40811

Ken Sharp <[e-mail]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
           Severity|normal                      |enhancement
           Keywords|                            |download, source
     Ever confirmed|0                           |1

--- Comment #1 from Ken Sharp <[e-mail]> ---
This is still true in Wine 11.13, but why would you want this not to be the
case?

WINESERVER= is useful for telling Wine where to find its wineserver if it is
not in the standard location. Is there a reason to override this logic?

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 40811] WINESERVER variable is only used if @bindir@/wineserver does not exist

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=40811

--- Comment #2 from Jens Reyer <[e-mail]> ---
Generally as best practice in coding I'd say values of variables should always
be used first, before trying any logic.

I don't remember exactly why I filed this bug, but at the time I was Debian
maintainer for the Wine packages.

It was either something about the Debian alternatives system, where wine-stable
and wine-development may both be installed and the user can choose which one
provides wine.  So /usr/bin/wine is a link to either /usr/bin/wine-stable or
/usr/bin/wine-development, the same for wineserver.

Since those are either wrapper scripts or links to BINDIR (/usr/lib/wine-stable
or /usr/lib/wine-development), I see no real issue here.  Otherwise (maybe what
led me to filing this bug) I might see this scenario: if wine-stable points to
wine, but the user wants to test something with wine-development:
/usr/bin/wine-development would use /usr/bin/wineserver which points to
/usr/bin/wineserver-stable, which is bad.

Another scenario with the old WoW64 setup back then, where the 32-bit binaries
were built on i386-buildservers, and 64-bit binaries on amd64-buildservers and
the resulting packages co-installed.  There I might have BINDIR/wineserver
being a wrapper script to call either the binary wineserver32 or wineserver64. 
This wrapper script might do something else, then what I want when I call wine
and can set the WINESERVER variable.

Long story short, although I solved the issue for the Debian packaging in the
end, there was some issue that prompted me to filing this bug.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 40811] WINESERVER variable is only used if @bindir@/wineserver does not exist

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=40811

Alexandre Julliard <[e-mail]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEEDINFO                    |RESOLVED

--- Comment #3 from Alexandre Julliard <[e-mail]> ---
Actually WINESERVER already takes precedence over @bindir@/wineserver and PATH
lookups.

It doesn't take precedence over the ntdll-relative lookup, because that's the
most likely to do the right thing in all kinds of setups, and it avoids lots of
user errors.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.