[Bug 49535] New: Final Fantasy XI Online: Incorrect Opening Movie Colours
https://bugs.winehq.org/show_bug.cgi?id=49535 Bug ID: 49535 Summary: Final Fantasy XI Online: Incorrect Opening Movie Colours Product: Wine Version: 5.12 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winegstreamer Assignee: wine-bugs(a)winehq.org Reporter: escomk3(a)hotmail.com Distribution: --- After fd25ba65 [1], the opening movie has too little red, and too much blue. 1. https://source.winehq.org/git/wine.git/commit/fd25ba65e0eb9fedfb2cdfa2b7a4b1... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Chiitoo <escomk3(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |fd25ba65e0eb9fedfb2cdfa2b7a | |4b16e0401dfdf Distribution|--- |Gentoo -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |z.figura12(a)gmail.com --- Comment #1 from Zebediah Figura <z.figura12(a)gmail.com> --- Can you please attach a log with WINEDEBUG=+quartz,+gstreamer,+strmbase,+d3d9,+d3d? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #2 from Chiitoo <escomk3(a)hotmail.com> --- Created attachment 67667 --> https://bugs.winehq.org/attachment.cgi?id=67667 ffxi-intro_colours-quartz_gstreamer_strmbase_d3d9_d3d There will be a single trace line I added for this build: trace:gstreamer:init_new_decoded_pad Avoid expensive color matrix conversions. I hope that's okay. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #3 from Zebediah Figura <z.figura12(a)gmail.com> --- Eh, I guess I misidentified the commit ID; I thought this was a different problem... This is kind of an expected side effect of the linked commit, i.e. colorimetry is a little different. There's not really anything we can do except to revert the commit. I'd be kind of curious to see if Windows (or even native quartz) produces different colors for this application. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #4 from Chiitoo <escomk3(a)hotmail.com> --- Native 'quartz' results into the same overly green and/or purple colours. I'll see if I can set up a Windows test at some point. It may take a while, but I would also be able to tell if there's another issue with the video, in that the aspect ratio isn't preserved (the image is stretched horizontally). It might be due to the resolution settings, however, since some things in the game only know 4:3 still. Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #5 from Chiitoo <escomk3(a)hotmail.com> --- Forgot to add that the videos of this over at the tubes seem the same (colour-wise) as with Wine before this commit. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Final Fantasy XI Online: |Multiple applications have |Incorrect Opening Movie |overly green and purple |Colours |videos due to bad YUV -> | |RGB conversion (Final | |Fantasy XI Online, Megarace | |3) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 soredake <gi85qht0z(a)relay.firefox.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gi85qht0z(a)relay.firefox.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Dmitry Skvortsov (Iglu47) <lvb.crd(a)protonmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lvb.crd(a)protonmail.com --- Comment #6 from Dmitry Skvortsov (Iglu47) <lvb.crd(a)protonmail.com> --- Created attachment 68560 --> https://bugs.winehq.org/attachment.cgi?id=68560 bbct-image-example-before-and-after-commits add please this also affects the 'BlazBlue Calamity Trigger' reverting fd25ba65e0eb9fedfb2cdfa2b7a4b16e0401dfdf and 930dc23c7c9a9221aad19ebf468c3838f86427b3 helps (did not check which one) I previously posted the output from current wine master (5.20) here: https://bugs.winehq.org/show_bug.cgi?id=25329#attach_68557 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick(a)piezo-forte.be Summary|Multiple applications have |Multiple applications have |overly green and purple |overly green and purple |videos due to bad YUV -> |videos due to bad YUV -> |RGB conversion (Final |RGB conversion (Final |Fantasy XI Online, Megarace |Fantasy XI Online, Megarace |3) |3, BlazBlue Calamity | |Trigger) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Sagawa <sagawa.aki+winebugs(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sagawa.aki+winebugs(a)gmail.c | |om --- Comment #7 from Sagawa <sagawa.aki+winebugs(a)gmail.com> --- I'm working on this issue. Hopefully, I'll send a patch in a few weeks later. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #8 from Dmitry Skvortsov (Iglu47) <lvb.crd(a)protonmail.com> --- I looked over and more 'quartz-games': 'BlazBlue Calamity Trigger' 'Guilty Gear X2 Reload' 'Dead or Alive 5 Last Round'. It turned out that reverting fd25ba65e0eb9fedfb2cdfa2b7a4b16e0401dfdf helps with the colors in the video for all of them. Also for the latest Wine (currently 5.21) this is no longer enough, so I additionally had to cancel 0542a34c247f029a0394f308f9f44c5c41d904fc e484056171bfd57473660243bc75935409320f37 9afc5ed72eaf109726be8f558294a1a21502c496 e47b45e2f55ea33790aa60fdf207cafa53c9adb0 (did not check which ones are specific in this set of patches). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #9 from Dmitry Skvortsov (Iglu47) <lvb.crd(a)protonmail.com> --- Created attachment 68637 --> https://bugs.winehq.org/attachment.cgi?id=68637 doa5-wine-5.21.r69.gb940c5e7c91+yuvfixup.log I checked https://source.winehq.org/patches/data/195961 on b940c5e7c91bff963336dd7d2c4defc3a82c75a1. With the yuvfixup patch, colors now look normal in all 3 games I wrote about above. I attach the terminal output from Dead or Alive 5 along with Steam(version for Windows). Thank You, Akihiro Sagawa -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Keywords| |patch Status|UNCONFIRMED |NEW Summary|Multiple applications have |Multiple applications have |overly green and purple |overly green and purple |videos due to bad YUV -> |videos due to bad YUV -> |RGB conversion (Final |RGB conversion (Final |Fantasy XI Online, Megarace |Fantasy XI Online, Megarace |3, BlazBlue Calamity |3, BlazBlue Calamity |Trigger) |Trigger, Mafia: The City of | |Lost Heaven) --- Comment #10 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Confirming, also affects Mafia: The City of Lost Heaven. (See Bug 48850) Also adding patch keyword and after this I'll attach a rebased version of Akihiro Sagawa's patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #11 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Created attachment 68793 --> https://bugs.winehq.org/attachment.cgi?id=68793 rebased patch by Akihiro Sagawa -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Lunknown <SolisX007(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |SolisX007(a)yahoo.com --- Comment #12 from Lunknown <SolisX007(a)yahoo.com> --- *** Bug 50266 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |251262a44a8f8403fd963e7bb51 | |0da778944af1b Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #13 from Zebediah Figura <z.figura12(a)gmail.com> --- This should be fixed by <https://source.winehq.org/git/wine.git/commitdiff/251262a44a8f8403fd963e7bb5...>. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #14 from Dmitry Skvortsov (Iglu47) <lvb.crd(a)protonmail.com> --- (In reply to Dmitry Skvortsov (Iglu47) from comment #8)
Also for the latest Wine (currently 5.21) this is no longer enough, so I additionally had to cancel
Sorry, I didn't quite write. I meant that just `git revert --no-commit fd25ba65e0eb9fedfb2cdfa2b7a4b16e0401dfdf` was no longer enough, because instead of returning it gives a conflict. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #15 from Chiitoo <escomk3(a)hotmail.com> --- (In reply to Zebediah Figura from comment #13)
This should be fixed by <https://source.winehq.org/git/wine.git/commitdiff/ 251262a44a8f8403fd963e7bb510da778944af1b>.
Quite curiously, the colours in FFXI are still wonky. I've made pretty sure that I'm building at fac1e40aaf0 [1], and that the particular line isn't there any longer, but maybe I'm just not seeing something that I should... Will investigate more, hopefully sooner rather than later. Anyone else see this with the other affected applications? 1. https://source.winehq.org/git/wine.git/commit/fac1e40aaf0726a3e328a922cb4969... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #16 from Dmitry Skvortsov (Iglu47) <lvb.crd(a)protonmail.com> --- Created attachment 68860 --> https://bugs.winehq.org/attachment.cgi?id=68860 additional removing Please ignore my previous comment: https://bugs.winehq.org/show_bug.cgi?id=49535#c14 I confused this with another issue. In fact, if you check - no conflict exists. I found out that among those four commits, additionally undoing e484056171bfd57473660243bc75935409320f37 helps. This is still relevant for the current wine, or removing this 1 line helps: https://source.winehq.org/git/wine.git/blob/251262a44a8f8403fd963e7bb510da77... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|1 |0 Resolution|FIXED |--- Status|RESOLVED |UNCONFIRMED --- Comment #17 from Zebediah Figura <z.figura12(a)gmail.com> --- Sorry, that was indeed premature. I've sent another patch which removes the other matrix-mode setting. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #18 from Chiitoo <escomk3(a)hotmail.com> --- Cool. For fun I tried re-adding the other line, while removing this one, and that alone seems to fix the thing for FFXI. Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #19 from Dmitry Skvortsov (Iglu47) <lvb.crd(a)protonmail.com> --- (In reply to Chiitoo from comment #18)
For fun I tried re-adding the other line, while removing this one, and that alone seems to fix the thing for FFXI.
Yes - I did not notice that the presence or absence of the first problematic commit somehow noticeably affects the 'BlazBlue Calamity Trigger', 'Guilty Gear X2 Reload' and 'Dead or Alive 5 Last Round' in the latest versions of Wine. Currently the main thing for them is only - https://source.winehq.org/patches/data/197380. If it can reduce resource consumption between internal Gstreamer links - then it makes sense for weak machines. However, it looks like applying such a thing to the last link in the output is not well received by the application. (if I understood everything correctly) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 --- Comment #20 from Dmitry Skvortsov (Iglu47) <lvb.crd(a)protonmail.com> --- I mean, not necessarily the last link, but the link where the last color transformation takes place - after all, after it there is no explicit `matrix-mode` restore or something like that. (again if I understood everything correctly) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #21 from joaopa <jeremielapuree(a)yahoo.fr> --- *** Bug 50145 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1|251262a44a8f8403fd963e7bb51 |6f158754435f403864052e595ab |0da778944af1b |627dadac2666f Status|UNCONFIRMED |RESOLVED --- Comment #22 from Zebediah Figura <z.figura12(a)gmail.com> --- Actually fixed by <https://source.winehq.org/git/wine.git/commitdiff/6f158754435f403864052e595a...>. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 andy <andy86(a)fastwebnet.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andy86(a)fastwebnet.it --- Comment #23 from andy <andy86(a)fastwebnet.it> --- *** Bug 50286 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #24 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 6.0-rc2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |focht(a)gmx.net URL| |https://web.archive.org/web | |/20210214111943/http://down | |load.fileplanet.com/ftp1/ga | |medemos/arcade/megarace3_de | |mo.zip?st=NWsgWlFvxM2auaDQ1 | |j2fmQ&e=1613312332 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49535 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla