[Bug 44677] New: Property dialogs in Visio 2003 are not working with Wine 3.2/3.3
https://bugs.winehq.org/show_bug.cgi?id=44677 Bug ID: 44677 Summary: Property dialogs in Visio 2003 are not working with Wine 3.2/3.3 Product: Wine Version: 3.3 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: christianuceda(a)yahoo.com Distribution: --- Property dialogs in Visio 2003 are not working with Wine 3.2/3.3 In order to make Visio run I have set the following overrides: gdiplus (native) riched20 (native, builtin) Up until version 2.21 (that I can tell) Visio 2003 ran perfectly, however starting with newer versions 3.2 and 3.3 the property dialogues don't show regardless of override or not. The problem can be recreated by creating a new empty diagram, draw something like a line, then right click on the line and from the menu, choose "format->line" on Wine 2.21 the dialog opens without problem, on Wine 3.3 no window opens and Visio remains in an inconsistent state where you can't click on menus or toolbars. I have reverted back to Wine 2.21 and visio works perfectly again with the same prefix I used with Wine 3.x. My computer runs Ubuntu 16.04.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |dark.shadow4(a)web.de --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Can you perform a regression test to find the faulty commit? Also, is there a free version of the program available for testing? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #2 from Christian Uceda <christianuceda(a)yahoo.com> --- Hi Fabian, I have no clue on how to perform a regression test, I have seen people mentioning it before but I have no personal experience doing that, is there any website that documents the process so I can learn? Running Visio 2003 is vital for me, I'm wiling to go the extra mile and do whatever is required to help fix this. There is no available version of Visio 2003 that I know of as a demo, I can privately share a bottle with the application installed, but I'm not sure if that's a good idea. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- Sure, the wiki has a page dedicated to this: https://wiki.winehq.org/Regression_Testing Basically, you only need to compile wine from source multiple times and test - and git does the rest. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #4 from Christian Uceda <christianuceda(a)yahoo.com> --- Hi, I think I found the commit: 662f727a7914fa1996c2fe19e2063a81fc079653 is the first bad commit commit 662f727a7914fa1996c2fe19e2063a81fc079653 Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Feb 1 10:09:05 2018 +0300 comctl32: Introduce Edit control. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> :040000 040000 2a1f7bea9e3fa77a629b23f5bd69f32d1523d3b5 b22c25bdebd40c56edcf83090cf0f8d248412d38 M dlls It can be found on: "wine-3.0-280-g662f727" If I revert it while on that tag the bug dissapears. I tried to revert the patch from the latest HEAD and git complains about paths. Please let me know if I can do anything more. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #5 from Christian Uceda <christianuceda(a)yahoo.com> --- Just in case I tested with 3.4 and the bug is still there. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- Unfortunately I'm unable to install using Visio 2003 image I have, installer crashes almost immediately in rpcrt4. Could you attach +win,+actctx,+class,+edit log running Wine 3.4? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #7 from Christian Uceda <christianuceda(a)yahoo.com> --- Created attachment 60797 --> https://bugs.winehq.org/attachment.cgi?id=60797 +win,+actctx,+class,+edit log running Wine 3.4 Hi, please find attached the required log, let me know if you need anything else. I can privately share my wine bottle if required. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> --- Created attachment 60803 --> https://bugs.winehq.org/attachment.cgi?id=60803 patch Please try this patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #9 from Christian Uceda <christianuceda(a)yahoo.com> --- Created attachment 60804 --> https://bugs.winehq.org/attachment.cgi?id=60804 Line properties dialog with non-clickable buttons Hi, thanks for the patch, it does "almost" work. The property windows now open, the text properties window in particluar, works fine. The line properties window has some problems, while it now does open, the buttons at the bottom of the window are not click-able and at times drawn on inverse (depressed). The buttons work with the tab key and the keyboard though, it is just clicking with the mouse what does not work. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #10 from Christian Uceda <christianuceda(a)yahoo.com> --- (In reply to Christian Uceda from comment #9)
Created attachment 60804 [details] Line properties dialog with non-clickable buttons
Hi, thanks for the patch, it does "almost" work.
The property windows now open, the text properties window in particluar, works fine.
The line properties window has some problems, while it now does open, the buttons at the bottom of the window are not click-able and at times drawn on inverse (depressed).
The buttons work with the tab key and the keyboard though, it is just clicking with the mouse what does not work.
Also I just noticed, if you try to click Ok/Cancel buttons any other control in the form becomes non-click-able too. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #11 from Nikolay Sivov <bunglehead(a)gmail.com> --- Does it make any difference if you set dwHoverTime to HOVER_DEFAULT in WM_MOUSEMOVE handler in comctl32/button.c, or if you remove TrackMouseEvent() stuff completely from there? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |user32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #12 from Christian Uceda <christianuceda(a)yahoo.com> --- Hi Nikolay, I'm a bit at a lost here, I don't have any familiarity with the code, I had a look at dlls/comctl32/button.c but I'm unsure on how to apply the changes you mention on post 11. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #13 from Nikolay Sivov <bunglehead(a)gmail.com> --- Sure, let's wait for the main part to get in wine-git, and then I'll attach some more patches for you to test. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60803|0 |1 is obsolete| | --- Comment #14 from Nikolay Sivov <bunglehead(a)gmail.com> --- Created attachment 60816 --> https://bugs.winehq.org/attachment.cgi?id=60816 patch2 Main problem is fixed now, https://source.winehq.org/git/wine.git/commit/9b9f97e3f668c9d291b4f9fa2944dd.... Let's see if it's a new Button code that's broken, please run with attached patch, it reverts to original Button in user32. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #15 from Christian Uceda <christianuceda(a)yahoo.com> --- Hi Nikolay, With the current GIT version and the patch on comment 14 everything is back to normal with the property windows. However while testing Visio I have noticed another issue this time with the fonts. The GIT copy of visio only shows a subset of the fonts I have installed on my system. If I open a previously existing diagram any font in use not in the list is replaced in the diagram. Shall I open another bug report for this? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #16 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Christian Uceda from comment #15)
Hi Nikolay,
With the current GIT version and the patch on comment 14 everything is back to normal with the property windows.
Ok, good.
However while testing Visio I have noticed another issue this time with the fonts.
The GIT copy of visio only shows a subset of the fonts I have installed on my system.
If I open a previously existing diagram any font in use not in the list is replaced in the diagram.
Shall I open another bug report for this?
Yes, please. Unless it's the same regression, which you can easily test by adding Edit/ComboBox/ComboLBox to is_builtin_class(), in alphabetical order, same way last patch adds Button. That will revert to classic user controls unconditionally. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 --- Comment #17 from Christian Uceda <christianuceda(a)yahoo.com> --- Hi Nikolay, I just tested with your suggested change: static BOOL is_builtin_class( const WCHAR *name ) { static const WCHAR classesW[][20] = { {'B','u','t','t','o','n',0}, {'C','o','m','b','o','B','o','x',0}, {'C','o','m','b','o','L','B','o','x',0}, {'E','d','i','t',0}, {'I','M','E',0}, {'M','D','I','C','l','i','e','n','t',0}, {'S','c','r','o','l','l','b','a','r',0}, }; It did not made any change, the list of fonts is not the correct one and the drawing gets any font not listed changed to Arial which ruins the text layout on drawings. I will open another bug report for this. Thank you very much for all your help with this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |44857 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |9b9f97e3f668c9d291b4f9fa294 | |4ddb11509970f Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #18 from Nikolay Sivov <bunglehead(a)gmail.com> --- I'm marking this one fixed, next is bug 44857. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #19 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44677 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |662f727a7914fa1996c2fe19e20 | |63a81fc079653 CC| |mstefani(a)winehq.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org