[Bug 52180] New: Significant performance regression in The Sims 2
https://bugs.winehq.org/show_bug.cgi?id=52180 Bug ID: 52180 Summary: Significant performance regression in The Sims 2 Product: Wine Version: 6.23 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: sashok.olen(a)gmail.com CC: huw(a)codeweavers.com, jacek(a)codeweavers.com Regression SHA1: c4b258eff75d54fdc0eb9b1843db5f77318f836c Distribution: --- Hi, between Wine 6.22 and Wine 6.23, The Sims 2 suffered a significant performance decrease. Through bisect, I've discovered multiple changes that contributed to this. Here is the progress of performance degradation between 6.22 and 6.23 version, tested on a machine with AMD Ryzen 3800X by loading into the "Pleasant" family in the "Pleasantville" neighborhood and focusing on one of the household members and zooming the camera out all the way out during clear weather. The graphical backend used during tests was DXVK due to Wined3d not working with the game (only wine-staging does, and even that has a lot of graphical issues and is a lot slower). And while Sims 2 doesn't have a built-in benchmark tool, I've found that the value differences have been quite consistent and reliably reproduced. wine-6.22 - 47-44 fps commit d7133c97d91a0dbc746a4c9711831f45704c8b43 - 9-1 fps commit 318673405c6296342ef49177de26440f69a4b0be - 44-39 fps commit c4b258eff75d54fdc0eb9b1843db5f77318f836c - 36-30 fps wine-6.23 - 36-30 fps I was not sure which commit to specify as the offender so I specified c4b258eff75d54fdc0eb9b1843db5f77318f836c as one. It should be noted that the game suffered a similar performance regression in the past (see https://bugs.winehq.org/show_bug.cgi?id=51047), which might be related or give a clue as to what the issue is. And while it's not really relevant, it should be noted that the game is generally very CPU-bound and runs quite a lot slower with wine+DXVK than Windows10+DXVK, roughly 2-3 times slower. In case it might be useful, here's an apitrace of the game: https://drive.google.com/file/d/158QpcQ98n2h2xCSkpvPFpiwqYkydIRqk/view?usp=s... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52180 Alexandr Oleynikov <sashok.olen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52180 Alexandr Oleynikov <sashok.olen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sashok.olen(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52180 --- Comment #1 from Alexandr Oleynikov <sashok.olen(a)gmail.com> --- Created attachment 71248 --> https://bugs.winehq.org/attachment.cgi?id=71248 sims2-6.23-perf-patches I've found that the patches from the attached archives created by Torge Matthies applied to 6.23 release tag restore the original performance. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52180 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, performance -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52180 --- Comment #2 from Jacek Caban <jacek(a)codeweavers.com> --- Created attachment 71306 --> https://bugs.winehq.org/attachment.cgi?id=71306 fix Please try the attached patches. There is still room for improvements, but this should be a bit faster than pre-win32u code. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52180 --- Comment #3 from Alexandr Oleynikov <sashok.olen(a)gmail.com> --- It is indeed faster than pre-6.23 and it def solves the issue in 6.23-7.0-rc1, thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52180 Jacek Caban <jacek(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |e63f7b7aa1226e304a84a457029 | |883dfe97a79c1 Resolution|--- |FIXED --- Comment #4 from Jacek Caban <jacek(a)codeweavers.com> --- Fixed in git with a different version of the patch: https://source.winehq.org/git/wine.git/commitdiff/e63f7b7aa1226e304a84a45702... Thanks for the report and testing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52180 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.0-rc3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla