[Bug 48832] New: Magic The Gathering Online does not start due to long file names
https://bugs.winehq.org/show_bug.cgi?id=48832 Bug ID: 48832 Summary: Magic The Gathering Online does not start due to long file names Product: Wine Version: 5.4 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: panard(a)inzenet.org Distribution: --- Created attachment 66749 --> https://bugs.winehq.org/attachment.cgi?id=66749 increase OFS_MAXPATHNAME Since the 2020-03-25 update of MTGO client, wine fails to start the program. It is actually due to filenames which exceed OFS_MAXPATHNAME (128). See debug at https://github.com/pauleve/docker-mtgo/issues/79#issuecomment-605118041 Increasing OFS_MAXPATHNAME256 (see patch) fixed the issue and MTGO works again. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 Panard <panard(a)inzenet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair(a)hotmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 --- Comment #1 from Panard <panard(a)inzenet.org> --- Any chance to have this patch in staging? (if not upstream ?) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 --- Comment #2 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- This patch is wrong, that value cannot be changed as it is 128 in the Windows SDK. A possible solution which I haven't tested, is to convert the filename to a dos format type "C:\Progr~1\", and store in that format. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 --- Comment #3 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Created attachment 66753 --> https://bugs.winehq.org/attachment.cgi?id=66753 Possible Solution Can you please try the attached patch? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 --- Comment #4 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Alistair Leslie-Hughes from comment #3)
Created attachment 66753 [details] Possible Solution
Can you please try the attached patch?
Adding FILE_FLAG_OVERLAPPED doesn't make sence, also you probably should try to translate pmmioinfo->dwFlags in a similar way like OpenFile() does it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66753|0 |1 is obsolete| | --- Comment #5 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Created attachment 66754 --> https://bugs.winehq.org/attachment.cgi?id=66754 Possible Solution 2 Thanks Dmitry, Turns out that _lopen does exactly what I was trying to do. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 --- Comment #6 from Panard <panard(a)inzenet.org> --- The patch seems to work, thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/winmm-Replace_Op | |enFile Status|UNCONFIRMED |STAGED -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |winmm&mci -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|STAGED |RESOLVED --- Comment #7 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Fixed by https://source.winehq.org/git/wine.git/?a=commit;h=5ee2ef52175c8bf506c4eb9a6... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Magic The Gathering Online |Magic The Gathering Online: |does not start due to long |client does not start due |file names |to long file names since | |2020-03-25 update CC| |focht(a)gmx.net Fixed by SHA1| |5ee2ef52175c8bf506c4eb9a67b | |de4cb72a93853 URL| |https://web.archive.org/web | |/20200407084540/http://mtgo | |clientdepot.onlinegaming.wi | |zards.com/setup.exe Keywords| |download -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.6. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48832 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|5.0.x |--- --- Comment #9 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 5.0.x milestone from bug fixes that didn't make it into 5.0.x. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla