[Bug 58067] New: [Regression] comctl32/edit: Unable to enter values in Adobe Lightroom Classic 10.4
https://bugs.winehq.org/show_bug.cgi?id=58067 Bug ID: 58067 Summary: [Regression] comctl32/edit: Unable to enter values in Adobe Lightroom Classic 10.4 Product: Wine Version: 10.4 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: bugs(a)bzatek.net CC: bunglehead(a)gmail.com Regression SHA1: d18a1fded2e2024ae2c8cdc4235654ff2d8dd5e9 Distribution: --- Created attachment 78320 --> https://bugs.winehq.org/attachment.cgi?id=78320 the tool on mouseover bug 56108 resp. https://gitlab.winehq.org/wine/wine/-/merge_requests/7606 has broken ability to enter values in some of the edit boxes in Adobe Lightroom Classic 10.4. Reverting the two mentioned changes fixes the issue. FWIW, Adobe often modifies widget look and behaviour. In this case the particular tool's value looks like a label, clicking and dragging the label will change value of the slider on the left. Single click will turn the label into an edit, which then acts normally - enter letters and numbers, either confirm by the Enter key or cancel by the Escape key. Tested against wine-10.5 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=58067 --- Comment #1 from Tomáš Bžatek <bugs(a)bzatek.net> --- Created attachment 78321 --> https://bugs.winehq.org/attachment.cgi?id=78321 the tool after click -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=58067 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[Regression] comctl32/edit: |comctl32/edit: Unable to |Unable to enter values in |enter values in Adobe |Adobe Lightroom Classic |Lightroom Classic 10.4 |10.4 | Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=58067 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Tomáš Bžatek from comment #0)
FWIW, Adobe often modifies widget look and behaviour. In this case the particular tool's value looks like a label, clicking and dragging the label will change value of the slider on the left. Single click will turn the label into an edit, which then acts normally - enter letters and numbers, either confirm by the Enter key or cancel by the Escape key.
Thanks for the report. Are you describing here how it should work or how it current works on Wine with this regression? Which case does not work - dragging while holding the mouse button or entering edit mode? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 --- Comment #3 from Tomáš Bžatek <bugs(a)bzatek.net> ---
Are you describing here how it should work or how it current works on Wine with this regression?
What I've described is how it's supposed to work and how it actually used to work before the change.
Which case does not work - dragging while holding the mouse button or entering edit mode?
The only thing that doesn't work is entering characters once the tool enters edit mode (and the editable widget is displayed and in focus). In other words, what I was trying to say, is that simply checking bCaptureState may not be enough, or in case when the application modifies the standard edit box behaviour. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bunglehead(a)gmail.com | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> --- Created attachment 78394 --> http://bugs.winehq.org/attachment.cgi?id=78394 patch Hi, Tomáš. Could you please try this patch? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> --- Tomáš, any chance for you test with the patch I mentioned? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 --- Comment #7 from Nikolay Sivov <bunglehead(a)gmail.com> --- Great. Let me know how it goes, and I'll send the fix. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 --- Comment #6 from Tomáš Bžatek <bugs(a)bzatek.net> --- Appears to be working fine, thanks! I'll keep an eye on possible difference the next few days. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 --- Comment #8 from Tomáš Bžatek <bugs(a)bzatek.net> --- Tested against vanilla wine-10.7 and also on wine-staging-10.7 in combination with two different Lightroom versions - all working fine! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 --- Comment #9 from Nikolay Sivov <bunglehead(a)gmail.com> --- Just checking - you mean wine 10.7 + this patch, right? Because it wasn't included in 10.7. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 --- Comment #10 from Tomáš Bžatek <bugs(a)bzatek.net> --- (In reply to Nikolay Sivov from comment #9)
Just checking - you mean wine 10.7 + this patch, right? Because it wasn't included in 10.7.
Correct, official wine releases + this patch applied on top. Haven't retested 10.6 or 10.7 without the patch - let me know if you want me to do so to be on a safe side. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 --- Comment #11 from Nikolay Sivov <bunglehead(a)gmail.com> --- No, no need, thank you. I submitted it https://gitlab.winehq.org/wine/wine/-/merge_requests/8011. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |a9ad9199453e2c3e035508fac7e | |cef7e4c1bdf07 Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #12 from Nikolay Sivov <bunglehead(a)gmail.com> --- This should work again in the next release, wine 10.8, once it's out. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 --- Comment #13 from Tomáš Bžatek <bugs(a)bzatek.net> --- Nice, thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58067 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #14 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.8. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla